This is an archive of the discontinued LLVM Phabricator instance.

Differential D135274

[libc++] Remove _LIBCPP_HAS_NO_CXX20_COROUTINES
ClosedPublic

Authored by ldionne on Oct 5 2022, 8:36 AM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rG3fe2db8cf90c: [libc++] Remove _LIBCPP_HAS_NO_CXX20_COROUTINES
Summary

As far as I can tell, all the compilers we support have support for
C++20 coroutines now.

Diff Detail

Event Timeline

ldionne created this revision.Oct 5 2022, 8:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 5 2022, 8:36 AM
Herald added a subscriber: ChuanqiXu. · View Herald Transcript
ldionne requested review of this revision.Oct 5 2022, 8:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 5 2022, 8:36 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Mordante accepted this revision.Oct 5 2022, 9:55 AM
Mordante added a subscriber: Mordante.

LGTM!

This revision is now accepted and ready to land.Oct 5 2022, 9:55 AM
Harbormaster completed remote builds in B190501: Diff 465416.Oct 5 2022, 11:24 AM
Closed by commit rG3fe2db8cf90c: [libc++] Remove _LIBCPP_HAS_NO_CXX20_COROUTINES (authored by ldionne). · Explain WhyOct 12 2022, 7:42 AM
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rG3fe2db8cf90c: [libc++] Remove _LIBCPP_HAS_NO_CXX20_COROUTINES.

Revision Contents

PathSize
libcxx/
include/
4 lines
__coroutine/
4 lines
4 lines
4 lines
4 lines

Diff 467144

libcxx/include/__config

Show First 20 Lines • Show All 1,074 Lines • ▼ Show 20 Lines
# define _LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_MEMBERS # define _LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_MEMBERS
# define _LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_VOID_SPECIALIZATION # define _LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_VOID_SPECIALIZATION
# define _LIBCPP_ENABLE_CXX20_REMOVED_BINDER_TYPEDEFS # define _LIBCPP_ENABLE_CXX20_REMOVED_BINDER_TYPEDEFS
# define _LIBCPP_ENABLE_CXX20_REMOVED_NEGATORS # define _LIBCPP_ENABLE_CXX20_REMOVED_NEGATORS
# define _LIBCPP_ENABLE_CXX20_REMOVED_RAW_STORAGE_ITERATOR # define _LIBCPP_ENABLE_CXX20_REMOVED_RAW_STORAGE_ITERATOR
# define _LIBCPP_ENABLE_CXX20_REMOVED_TYPE_TRAITS # define _LIBCPP_ENABLE_CXX20_REMOVED_TYPE_TRAITS
# endif // _LIBCPP_ENABLE_CXX20_REMOVED_FEATURES # endif // _LIBCPP_ENABLE_CXX20_REMOVED_FEATURES
# if !defined(__cpp_impl_coroutine) || __cpp_impl_coroutine < 201902L
# define _LIBCPP_HAS_NO_CXX20_COROUTINES
# endif
# define _LIBCPP_PUSH_MACROS _Pragma("push_macro(\"min\")") _Pragma("push_macro(\"max\")") # define _LIBCPP_PUSH_MACROS _Pragma("push_macro(\"min\")") _Pragma("push_macro(\"max\")")
# define _LIBCPP_POP_MACROS _Pragma("pop_macro(\"min\")") _Pragma("pop_macro(\"max\")") # define _LIBCPP_POP_MACROS _Pragma("pop_macro(\"min\")") _Pragma("pop_macro(\"max\")")
# ifndef _LIBCPP_NO_AUTO_LINK # ifndef _LIBCPP_NO_AUTO_LINK
# if defined(_LIBCPP_ABI_MICROSOFT) && !defined(_LIBCPP_BUILDING_LIBRARY) # if defined(_LIBCPP_ABI_MICROSOFT) && !defined(_LIBCPP_BUILDING_LIBRARY)
# if !defined(_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS) # if !defined(_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS)
# pragma comment(lib, "c++.lib") # pragma comment(lib, "c++.lib")
# else # else
▲ Show 20 Lines • Show All 121 Lines • Show Last 20 Lines

libcxx/include/__coroutine/coroutine_handle.h

Show All 14 Lines
#include <__memory/addressof.h> #include <__memory/addressof.h>
#include <compare> #include <compare>
#include <type_traits> #include <type_traits>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
#if _LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_CXX20_COROUTINES) #if _LIBCPP_STD_VER > 17
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
// [coroutine.handle] // [coroutine.handle]
template <class _Promise = void> template <class _Promise = void>
struct _LIBCPP_TEMPLATE_VIS coroutine_handle; struct _LIBCPP_TEMPLATE_VIS coroutine_handle;
template <> template <>
▲ Show 20 Lines • Show All 160 Lines • ▼ Show 20 Lines
template <class _Tp> template <class _Tp>
struct hash<coroutine_handle<_Tp>> { struct hash<coroutine_handle<_Tp>> {
_LIBCPP_HIDE_FROM_ABI _LIBCPP_HIDE_FROM_ABI
size_t operator()(const coroutine_handle<_Tp>& __v) const noexcept { return hash<void*>()(__v.address()); } size_t operator()(const coroutine_handle<_Tp>& __v) const noexcept { return hash<void*>()(__v.address()); }
}; };
_LIBCPP_END_NAMESPACE_STD _LIBCPP_END_NAMESPACE_STD
#endif // __LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_CXX20_COROUTINES) #endif // __LIBCPP_STD_VER > 17
#endif // _LIBCPP___COROUTINE_COROUTINE_HANDLE_H #endif // _LIBCPP___COROUTINE_COROUTINE_HANDLE_H

libcxx/include/__coroutine/coroutine_traits.h

Show All 10 Lines
#include <__config> #include <__config>
#include <type_traits> #include <type_traits>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
#if _LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_CXX20_COROUTINES) #if _LIBCPP_STD_VER > 17
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
// [coroutine.traits] // [coroutine.traits]
// [coroutine.traits.primary] // [coroutine.traits.primary]
// The header <coroutine> defined the primary template coroutine_traits such that // The header <coroutine> defined the primary template coroutine_traits such that
// if ArgTypes is a parameter pack of types and if the qualified-id R::promise_type // if ArgTypes is a parameter pack of types and if the qualified-id R::promise_type
// is valid and denotes a type ([temp.deduct]), then coroutine_traits<R, ArgTypes...> // is valid and denotes a type ([temp.deduct]), then coroutine_traits<R, ArgTypes...>
Show All 15 Lines
template <class _Ret, class... _Args> template <class _Ret, class... _Args>
struct coroutine_traits struct coroutine_traits
: public __coroutine_traits_sfinae<_Ret> : public __coroutine_traits_sfinae<_Ret>
{ {
}; };
_LIBCPP_END_NAMESPACE_STD _LIBCPP_END_NAMESPACE_STD
#endif // __LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_CXX20_COROUTINES) #endif // __LIBCPP_STD_VER > 17
#endif // _LIBCPP___COROUTINE_COROUTINE_TRAITS_H #endif // _LIBCPP___COROUTINE_COROUTINE_TRAITS_H

libcxx/include/__coroutine/noop_coroutine_handle.h

Show All 10 Lines
#include <__config> #include <__config>
#include <__coroutine/coroutine_handle.h> #include <__coroutine/coroutine_handle.h>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
#if _LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_CXX20_COROUTINES) #if _LIBCPP_STD_VER > 17
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
#if __has_builtin(__builtin_coro_noop) || defined(_LIBCPP_COMPILER_GCC) #if __has_builtin(__builtin_coro_noop) || defined(_LIBCPP_COMPILER_GCC)
// [coroutine.noop] // [coroutine.noop]
// [coroutine.promise.noop] // [coroutine.promise.noop]
struct noop_coroutine_promise {}; struct noop_coroutine_promise {};
▲ Show 20 Lines • Show All 74 Lines • ▼ Show 20 Lines
// [coroutine.noop.coroutine] // [coroutine.noop.coroutine]
inline _LIBCPP_HIDE_FROM_ABI inline _LIBCPP_HIDE_FROM_ABI
noop_coroutine_handle noop_coroutine() noexcept { return noop_coroutine_handle(); } noop_coroutine_handle noop_coroutine() noexcept { return noop_coroutine_handle(); }
#endif // __has_builtin(__builtin_coro_noop) || defined(_LIBCPP_COMPILER_GCC) #endif // __has_builtin(__builtin_coro_noop) || defined(_LIBCPP_COMPILER_GCC)
_LIBCPP_END_NAMESPACE_STD _LIBCPP_END_NAMESPACE_STD
#endif // __LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_CXX20_COROUTINES) #endif // __LIBCPP_STD_VER > 17
#endif // _LIBCPP___COROUTINE_NOOP_COROUTINE_HANDLE_H #endif // _LIBCPP___COROUTINE_NOOP_COROUTINE_HANDLE_H

libcxx/include/__coroutine/trivial_awaitables.h

Show All 10 Lines
#include <__config> #include <__config>
#include <__coroutine/coroutine_handle.h> #include <__coroutine/coroutine_handle.h>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
#if _LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_CXX20_COROUTINES) #if _LIBCPP_STD_VER > 17
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
// [coroutine.trivial.awaitables] // [coroutine.trivial.awaitables]
struct suspend_never { struct suspend_never {
_LIBCPP_HIDE_FROM_ABI _LIBCPP_HIDE_FROM_ABI
constexpr bool await_ready() const noexcept { return true; } constexpr bool await_ready() const noexcept { return true; }
_LIBCPP_HIDE_FROM_ABI _LIBCPP_HIDE_FROM_ABI
constexpr void await_suspend(coroutine_handle<>) const noexcept {} constexpr void await_suspend(coroutine_handle<>) const noexcept {}
_LIBCPP_HIDE_FROM_ABI _LIBCPP_HIDE_FROM_ABI
constexpr void await_resume() const noexcept {} constexpr void await_resume() const noexcept {}
}; };
struct suspend_always { struct suspend_always {
_LIBCPP_HIDE_FROM_ABI _LIBCPP_HIDE_FROM_ABI
constexpr bool await_ready() const noexcept { return false; } constexpr bool await_ready() const noexcept { return false; }
_LIBCPP_HIDE_FROM_ABI _LIBCPP_HIDE_FROM_ABI
constexpr void await_suspend(coroutine_handle<>) const noexcept {} constexpr void await_suspend(coroutine_handle<>) const noexcept {}
_LIBCPP_HIDE_FROM_ABI _LIBCPP_HIDE_FROM_ABI
constexpr void await_resume() const noexcept {} constexpr void await_resume() const noexcept {}
}; };
_LIBCPP_END_NAMESPACE_STD _LIBCPP_END_NAMESPACE_STD
#endif // __LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_CXX20_COROUTINES) #endif // __LIBCPP_STD_VER > 17
#endif // __LIBCPP___COROUTINE_TRIVIAL_AWAITABLES_H #endif // __LIBCPP___COROUTINE_TRIVIAL_AWAITABLES_H