diff --git a/llvm/lib/Target/AArch64/AArch64FrameLowering.cpp b/llvm/lib/Target/AArch64/AArch64FrameLowering.cpp --- a/llvm/lib/Target/AArch64/AArch64FrameLowering.cpp +++ b/llvm/lib/Target/AArch64/AArch64FrameLowering.cpp @@ -1864,8 +1864,9 @@ // From v8.3a onwards there are optimised authenticate LR and return // instructions, namely RETA{A,B}, that can be used instead. In this case the // DW_CFA_AARCH64_negate_ra_state can't be emitted. - if (Subtarget.hasPAuth() && MBBI != MBB.end() && - MBBI->getOpcode() == AArch64::RET_ReallyLR) { + if (Subtarget.hasPAuth() && + !MF.getFunction().hasFnAttribute(Attribute::ShadowCallStack) && + MBBI != MBB.end() && MBBI->getOpcode() == AArch64::RET_ReallyLR) { BuildMI(MBB, MBBI, DL, TII->get(MFI.shouldSignWithBKey() ? AArch64::RETAB : AArch64::RETAA)) .copyImplicitOps(*MBBI); diff --git a/llvm/test/CodeGen/AArch64/sign-return-address.ll b/llvm/test/CodeGen/AArch64/sign-return-address.ll --- a/llvm/test/CodeGen/AArch64/sign-return-address.ll +++ b/llvm/test/CodeGen/AArch64/sign-return-address.ll @@ -79,6 +79,13 @@ ret i32 %call } +; CHECK-LABEL: @non_leaf_scs +; CHECK-NOT: retaa +define i32 @non_leaf_scs(i32 %x) "sign-return-address"="non-leaf" shadowcallstack "target-features"="+v8.3a,+reserve-x18" { + %call = call i32 @foo(i32 %x) + ret i32 %call +} + ; CHECK-LABEL: @leaf_sign_all_v83 ; CHECK: pacia x30, sp ; CHECK-NEXT: .cfi_negate_ra_state