diff --git a/clang/lib/Driver/ToolChains/CommonArgs.cpp b/clang/lib/Driver/ToolChains/CommonArgs.cpp --- a/clang/lib/Driver/ToolChains/CommonArgs.cpp +++ b/clang/lib/Driver/ToolChains/CommonArgs.cpp @@ -66,16 +66,16 @@ static void renderRpassOptions(const ArgList &Args, ArgStringList &CmdArgs) { if (const Arg *A = Args.getLastArg(options::OPT_Rpass_EQ)) - CmdArgs.push_back(Args.MakeArgString(Twine("--plugin-opt=-pass-remarks=") + + CmdArgs.push_back(Args.MakeArgString(Twine("-plugin-opt=-pass-remarks=") + A->getValue())); if (const Arg *A = Args.getLastArg(options::OPT_Rpass_missed_EQ)) CmdArgs.push_back(Args.MakeArgString( - Twine("--plugin-opt=-pass-remarks-missed=") + A->getValue())); + Twine("-plugin-opt=-pass-remarks-missed=") + A->getValue())); if (const Arg *A = Args.getLastArg(options::OPT_Rpass_analysis_EQ)) CmdArgs.push_back(Args.MakeArgString( - Twine("--plugin-opt=-pass-remarks-analysis=") + A->getValue())); + Twine("-plugin-opt=-pass-remarks-analysis=") + A->getValue())); } static void renderRemarksOptions(const ArgList &Args, ArgStringList &CmdArgs, @@ -96,28 +96,28 @@ assert(!F.empty() && "Cannot determine remarks output name."); // Append "opt.ld." to the end of the file name. CmdArgs.push_back( - Args.MakeArgString(Twine("--plugin-opt=opt-remarks-filename=") + F + + Args.MakeArgString(Twine("-plugin-opt=opt-remarks-filename=") + F + Twine(".opt.ld.") + Format)); if (const Arg *A = Args.getLastArg(options::OPT_foptimization_record_passes_EQ)) CmdArgs.push_back(Args.MakeArgString( - Twine("--plugin-opt=opt-remarks-passes=") + A->getValue())); + Twine("-plugin-opt=opt-remarks-passes=") + A->getValue())); CmdArgs.push_back(Args.MakeArgString( - Twine("--plugin-opt=opt-remarks-format=") + Format.data())); + Twine("-plugin-opt=opt-remarks-format=") + Format.data())); } static void renderRemarksHotnessOptions(const ArgList &Args, ArgStringList &CmdArgs) { if (Args.hasFlag(options::OPT_fdiagnostics_show_hotness, options::OPT_fno_diagnostics_show_hotness, false)) - CmdArgs.push_back("--plugin-opt=opt-remarks-with-hotness"); + CmdArgs.push_back("-plugin-opt=opt-remarks-with-hotness"); if (const Arg *A = Args.getLastArg(options::OPT_fdiagnostics_hotness_threshold_EQ)) CmdArgs.push_back(Args.MakeArgString( - Twine("--plugin-opt=opt-remarks-hotness-threshold=") + A->getValue())); + Twine("-plugin-opt=opt-remarks-hotness-threshold=") + A->getValue())); } void tools::addPathIfExists(const Driver &D, const Twine &Path, diff --git a/clang/test/Driver/opt-record.c b/clang/test/Driver/opt-record.c --- a/clang/test/Driver/opt-record.c +++ b/clang/test/Driver/opt-record.c @@ -53,28 +53,28 @@ // RUN: %clang -target x86_64-linux -### -o FOO -fuse-ld=lld -flto=thin -fdiagnostics-hotness-threshold=100 -Rpass=inline -Rpass-missed=inline -Rpass-analysis=inline %s 2>&1 | FileCheck %s -check-prefix=CHECK-PASS-RPASS // RUN: %clang -target x86_64-linux -### -o FOO -fuse-ld=lld -flto=thin -fdiagnostics-hotness-threshold=auto -Rpass=inline -Rpass-missed=inline -Rpass-analysis=inline %s 2>&1 | FileCheck %s -check-prefix=CHECK-PASS-AUTO -// CHECK-NOPASS-NOT: "--plugin-opt=opt-remarks-filename=" -// CHECK-NOPASS-NOT: "--plugin-opt=opt-remarks-passes=inline" -// CHECK-NOPASS-NOT: "--plugin-opt=opt-remarks-format=yaml" -// CHECK-NOPASS-NOT: "--plugin-opt=opt-remarks-hotness-threshold=100" - -// CHECK-PASS-A: "--plugin-opt=opt-remarks-filename=a.out.opt.ld.yaml" -// CHECK-PASS-A-SAME: "--plugin-opt=opt-remarks-passes=inline" -// CHECK-PASS-A-SAME: "--plugin-opt=opt-remarks-format=yaml" -// CHECK-PASS-A-SAME: "--plugin-opt=opt-remarks-hotness-threshold=100" - -// CHECK-PASS: "--plugin-opt=opt-remarks-filename=FOO.opt.ld.yaml" -// CHECK-PASS-SAME: "--plugin-opt=opt-remarks-passes=inline" -// CHECK-PASS-SAME: "--plugin-opt=opt-remarks-format=yaml" -// CHECK-PASS-SAME: "--plugin-opt=opt-remarks-hotness-threshold=100" - -// CHECK-PASS-CUSTOM: "--plugin-opt=opt-remarks-filename=FOO.txt.opt.ld.some-format" -// CHECK-PASS-CUSTOM-SAME: "--plugin-opt=opt-remarks-format=some-format" -// CHECK-PASS-CUSTOM-SAME: "--plugin-opt=opt-remarks-hotness-threshold=100" - -// CHECK-PASS-RPASS: "--plugin-opt=-pass-remarks=inline" -// CHECK-PASS-RPASS-SAME: "--plugin-opt=-pass-remarks-missed=inline" -// CHECK-PASS-RPASS-SAME: "--plugin-opt=-pass-remarks-analysis=inline" -// CHECK-PASS-RPASS-SAME: "--plugin-opt=opt-remarks-hotness-threshold=100" - -// CHECK-PASS-AUTO: "--plugin-opt=opt-remarks-hotness-threshold=auto" +// CHECK-NOPASS-NOT: "-plugin-opt=opt-remarks-filename=" +// CHECK-NOPASS-NOT: "-plugin-opt=opt-remarks-passes=inline" +// CHECK-NOPASS-NOT: "-plugin-opt=opt-remarks-format=yaml" +// CHECK-NOPASS-NOT: "-plugin-opt=opt-remarks-hotness-threshold=100" + +// CHECK-PASS-A: "-plugin-opt=opt-remarks-filename=a.out.opt.ld.yaml" +// CHECK-PASS-A-SAME: "-plugin-opt=opt-remarks-passes=inline" +// CHECK-PASS-A-SAME: "-plugin-opt=opt-remarks-format=yaml" +// CHECK-PASS-A-SAME: "-plugin-opt=opt-remarks-hotness-threshold=100" + +// CHECK-PASS: "-plugin-opt=opt-remarks-filename=FOO.opt.ld.yaml" +// CHECK-PASS-SAME: "-plugin-opt=opt-remarks-passes=inline" +// CHECK-PASS-SAME: "-plugin-opt=opt-remarks-format=yaml" +// CHECK-PASS-SAME: "-plugin-opt=opt-remarks-hotness-threshold=100" + +// CHECK-PASS-CUSTOM: "-plugin-opt=opt-remarks-filename=FOO.txt.opt.ld.some-format" +// CHECK-PASS-CUSTOM-SAME: "-plugin-opt=opt-remarks-format=some-format" +// CHECK-PASS-CUSTOM-SAME: "-plugin-opt=opt-remarks-hotness-threshold=100" + +// CHECK-PASS-RPASS: "-plugin-opt=-pass-remarks=inline" +// CHECK-PASS-RPASS-SAME: "-plugin-opt=-pass-remarks-missed=inline" +// CHECK-PASS-RPASS-SAME: "-plugin-opt=-pass-remarks-analysis=inline" +// CHECK-PASS-RPASS-SAME: "-plugin-opt=opt-remarks-hotness-threshold=100" + +// CHECK-PASS-AUTO: "-plugin-opt=opt-remarks-hotness-threshold=auto"