diff --git a/libcxx/include/__functional/hash.h b/libcxx/include/__functional/hash.h --- a/libcxx/include/__functional/hash.h +++ b/libcxx/include/__functional/hash.h @@ -135,7 +135,7 @@ if (__len >= 4) { const uint32_t __a = __loadword(__s); const uint32_t __b = __loadword(__s + __len - 4); - return __hash_len_16(__len + (__a << 3), __b); + return __hash_len_16(__len + (static_cast<_Size>(__a) << 3), __b); } if (__len > 0) { const unsigned char __a = static_cast(__s[0]); diff --git a/libcxx/test/libcxx/utilities/utility/__murmur2_or_cityhash.pass.cpp b/libcxx/test/libcxx/utilities/utility/__murmur2_or_cityhash.pass.cpp new file mode 100644 --- /dev/null +++ b/libcxx/test/libcxx/utilities/utility/__murmur2_or_cityhash.pass.cpp @@ -0,0 +1,36 @@ +//===----------------------------------------------------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +// Test the CityHash implementation is correct. + +// UNSUPPORTED: c++03 + +#include +#include +#include + +#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ +# define CHOOSE_BY_ENDIANESS(little, big) (little) +#else +# define CHOOSE_BY_ENDIANESS(little, big) (big) +#endif + +int main(int, char**) { + const std::pair TestCases[] = { + {"abcdefgh", CHOOSE_BY_ENDIANESS(0x4382a8d0fe8edb17ULL, 0xca84e809bef16fbcULL)}, + {"abcDefgh", CHOOSE_BY_ENDIANESS(0xecefb080a6854061ULL, 0xd7feb824250272dcULL)}, + {"CityHash", CHOOSE_BY_ENDIANESS(0x169ea3aebf908d6dULL, 0xea8cef3ca6f6e368ULL)}, + {"CitYHash", CHOOSE_BY_ENDIANESS(0xe18298a2760f09faULL, 0xf33a7700bb7a94a8ULL)}, + }; + + std::__murmur2_or_cityhash h64; + for (const auto& test_case : TestCases) { + assert(h64(test_case.first.data(), test_case.first.size()) == test_case.second); + } + return 0; +}