diff --git a/clang/lib/Format/WhitespaceManager.cpp b/clang/lib/Format/WhitespaceManager.cpp --- a/clang/lib/Format/WhitespaceManager.cpp +++ b/clang/lib/Format/WhitespaceManager.cpp @@ -522,6 +522,13 @@ ? Changes[StartAt].indentAndNestingLevel() : std::tuple(); + // Keep track if the first token has a non-zero indent and nesting level. + // This can happen when aligning the contents of "#else" preprocessor blocks, + // which is done separately. + bool HasInitialIndentAndNesting = + StartAt == 0 && + IndentAndNestingLevel > std::tuple(); + // Keep track of the number of commas before the matching tokens, we will only // align a sequence of matching tokens if they are preceded by the same number // of commas. @@ -556,8 +563,19 @@ unsigned i = StartAt; for (unsigned e = Changes.size(); i != e; ++i) { - if (Changes[i].indentAndNestingLevel() < IndentAndNestingLevel) - break; + if (Changes[i].indentAndNestingLevel() < IndentAndNestingLevel) { + if (!HasInitialIndentAndNesting) + break; + // The contents of preprocessor blocks are aligned separately. + // If the initial preprocessor block is indented or nested (e.g. it's in + // a function), do not align and exit after finishing this scope block. + // Instead, align, and then lower the baseline indent and nesting level + // in order to continue aligning subsequent blocks. + EndOfSequence = i; + AlignCurrentSequence(); + IndentAndNestingLevel = + Changes[i].indentAndNestingLevel(); // new baseline + } if (Changes[i].NewlinesBefore != 0) { CommasBeforeMatch = 0; diff --git a/clang/unittests/Format/FormatTest.cpp b/clang/unittests/Format/FormatTest.cpp --- a/clang/unittests/Format/FormatTest.cpp +++ b/clang/unittests/Format/FormatTest.cpp @@ -5825,6 +5825,98 @@ Style); } +TEST_F(FormatTest, FormatAlignInsidePreprocessorElseBlock) { + FormatStyle Style = getLLVMStyle(); + Style.AlignConsecutiveAssignments.Enabled = true; + Style.AlignConsecutiveDeclarations.Enabled = true; + + // Test with just #if blocks. + verifyFormat("void f1() {\n" + "#if 1\n" + " int foo = 1;\n" + " int foobar = 2;\n" + "#endif\n" + "}\n" + "#if 1\n" + "int baz = 3;\n" + "#endif\n" + "void f2() {\n" + "#if 1\n" + " char *foobarbaz = \"foobarbaz\";\n" + " int quux = 4;\n" + "}", + Style); + + // Test with just #else blocks. + verifyFormat("void f1() {\n" + "#if 1\n" + "#else\n" + " int foo = 1;\n" + " int foobar = 2;\n" + "#endif\n" + "}\n" + "#if 1\n" + "#else\n" + "int baz = 3;\n" + "#endif\n" + "void f2() {\n" + "#if 1\n" + "#else\n" + " char *foobarbaz = \"foobarbaz\";\n" + " int quux = 4;\n" + "}", + Style); + + // Test with a mix of #if and #else blocks. + verifyFormat("void f1() {\n" + "#if 1\n" + "#else\n" + " int foo = 1;\n" + " int foobar = 2;\n" + "#endif\n" + "}\n" + "#if 1\n" + "int baz = 3;\n" + "#endif\n" + "void f2() {\n" + "#if 1\n" + "#else\n" + " // prevent alignment with #else in f1\n" + " char *foobarbaz = \"foobarbaz\";\n" + " int quux = 4;\n" + "}", + Style); + + // Test with nested #if and #else blocks. + verifyFormat("void f1() {\n" + "#if 1\n" + "#else\n" + "#if 2\n" + "#else\n" + " int foo = 1;\n" + " int foobar = 2;\n" + "#endif\n" + "#endif\n" + "}\n" + "#if 1\n" + "#else\n" + "#if 2\n" + "int baz = 3;\n" + "#endif\n" + "#endif\n" + "void f2() {\n" + "#if 1\n" + "#if 2\n" + "#else\n" + " // prevent alignment with #else in f1\n" + " char *foobarbaz = \"foobarbaz\";\n" + " int quux = 4;\n" + "#endif\n" + "#endif\n" + "}", + Style); +} + TEST_F(FormatTest, FormatHashIfNotAtStartOfLine) { verifyFormat("{\n { a #c; }\n}"); }