[libc++] Remove old CI configurations and update the supported compiler versions

[philnik]

Summary

_LIBCPP_REMOVE_TRANSITIVE_INCLUDES doesn't do anything anymore in C++23 mode, so it's now just a duplicate of the C++23 configuration.
Also add new steps to the post-release checklist for updating the supported compilers.

[ldionne]

Please coordinate with @Mordante. I just approved a patch that removed support for Clang 13. I think this could become only a removal of the generic-no-transitive-includes CI configuration.

[Mordante]

Thanks for working on this!

libcxx/docs/index.rst

107–108

I would prefer to only mention releases here. Having Clang 16 may lead to confusion since it's not released yet.
For AppleClang we already have some version 14 support.
I feel having support for the work-in-progress function can be left implicit.

libcxx/utils/ci/buildkite-pipeline.yml

243–244

This part has already landed.

454

I didn't remove this part, and I would prefer it in a separate commit; which can be this commit.

[philnik]

libcxx/docs/index.rst

107–108

I was actually always confused by the latest two stable releases. The released versions also only claim support for the last two versions, i.e. libc++14 claims compatibility with clang 12 and 13, but not 14 (see https://releases.llvm.org/14.0.0/projects/libcxx/docs/index.html), which I find very confusing. The new wording makes the situation clear.

libcxx/utils/ci/buildkite-pipeline.yml

454

I'll split it if we want to reword the supported compilers.

[Mordante]

libcxx/docs/index.rst

107–108

I see what you mean. However I think this wording doesn't work. When LLVM 16 will be released and current trunk would refer to LLVM 17. So that means LLVM 16 supports 14, 15, and 17. Still not 16. Maybe then we should list it like suggested.

Then we need to make sure we update this just prior to a release. How about adding a pre-release checklist here https://libcxx.llvm.org/Contributing.html?

[ldionne]

Is this still relevant? If not, let's close.

[philnik]

Address comments

[ldionne]

libcxx/docs/Contributing.rst

65

The summary and commit message seem outdated.

73

74

libcxx/utils/ci/buildkite-pipeline.yml

439

You need to update run-buildbot as well to remove that job.

[philnik]

Address comments

libcxx/cmake/caches/Generic-no-transitive-includes.cmake

-set(LIBCXX_TEST_PARAMS "enable_transitive_includes=False" CACHE STRING "")
-set(LIBCXXABI_TEST_PARAMS "${LIBCXX_TEST_PARAMS}" CACHE STRING "")

libcxx/docs/Contributing.rst

 
 Note that the rule for accepting as the "libc++" review group is to wait for two members
 of the group to have approved the patch, excluding the patch author. This is not a hard
 rule -- for very simple patches, use your judgement. The `"libc++" review group <https://reviews.llvm.org/project/members/64/>`__
 consists of frequent libc++ contributors with a good understanding of the project's
 guidelines -- if you would like to be added to it, please reach out on Discord.
 
 Post-release check list
 =======================
 
 After branching for an LLVM release:
 
 1. Update ``_LIBCPP_VERSION`` in ``libcxx/include/__config``
 2. Update the version number in ``libcxx/docs/conf.py``
 3. Update ``_LIBCPPABI_VERSION`` in ``libcxxabi/include/cxxabi.h``
 4. Update ``_LIBUNWIND_VERSION`` in ``libunwind/include/__libunwind_config.h``
+5. Update the list of supported clang versions in ``libcxx/docs/index.rst``
+6. Remove the in-progress warning from ``libcxx/docs/ReleaseNotes.rst``
 
 Exporting new symbols from the library
 ======================================
 
 When exporting new symbols from libc++, you must update the ABI lists located in ``lib/abi``.
 To test whether the lists are up-to-date, please run the target ``check-cxx-abilist``.
 To regenerate the lists, use the target ``generate-cxx-abilist``.
 The ABI lists must be updated for all supported platforms; currently Linux and

libcxx/docs/index.rst

 =============================
 
 Libc++ aims to support common compilers that implement the C++11 Standard. In order to strike a
 good balance between stability for users and maintenance cost, testing coverage and development
 velocity, libc++ drops support for older compilers as newer ones are released.
 
 ============ =============== ========================== =====================
 Compiler     Versions        Restrictions               Support policy
 ============ =============== ========================== =====================
-Clang        14, 15                                     latest two stable releases per `LLVM's release page <https://releases.llvm.org>`_
+Clang        14, 15, 16-git                             latest two stable releases per `LLVM's release page <https://releases.llvm.org>`_ and the development version
 AppleClang   14                                         latest stable release per `Xcode's release page <https://developer.apple.com/documentation/xcode-release-notes>`_
 Open XL      17.1 (AIX)                                 latest stable release per `Open XL's documentation page <https://www.ibm.com/docs/en/openxl-c-and-cpp-aix>`_
 GCC          12              In C++11 or later only     latest stable release per `GCC's release page <https://gcc.gnu.org/releases.html>`_
 ============ =============== ========================== =====================
 
 Libc++ also supports common platforms and architectures:
 
 =============== ========================= ============================

libcxx/utils/ci/buildkite-pipeline.yml

- label: "GCC ${GCC_STABLE_VERSION} / C++11"
     agents:
       queue: "libcxx-builders"
       os: "linux"
     retry:
       automatic:
         - exit_status: -1  # Agent was lost
           limit: 2
     timeout_in_minutes: 120
 
   - label: "Clang 14"
     command: "libcxx/utils/ci/run-buildbot generic-cxx2b"
     artifact_paths:
       - "**/test-results.xml"
       - "**/*.abilist"
     env:
         CC: "clang-14"
         CXX: "clang++-14"
     agents:
agents:
       queue: "libcxx-builders"
       os: "linux"
     retry:
       automatic:
         - exit_status: -1  # Agent was lost
           limit: 2
     timeout_in_minutes: 120
 
-  - label: "No transitive includes"
-    command: "libcxx/utils/ci/run-buildbot generic-no-transitive-includes"
-    artifact_paths:
-      - "**/test-results.xml"
-      - "**/*.abilist"
-    env:
-        CC: "clang-${LLVM_HEAD_VERSION}"
-        CXX: "clang++-${LLVM_HEAD_VERSION}"
-    agents:
-      queue: "libcxx-builders"
-      os: "linux"
-    retry:
-      automatic:
-        - exit_status: -1  # Agent was lost
-          limit: 2
-    timeout_in_minutes: 120
-
   - label: "With LLVM's libunwind"
     command: "libcxx/utils/ci/run-buildbot generic-with_llvm_unwinder"
     artifact_paths:
       - "**/test-results.xml"
       - "**/*.abilist"
     env:
         CC: "clang-${LLVM_HEAD_VERSION}"
         CXX: "clang++-${LLVM_HEAD_VERSION}"

libcxx/utils/ci/run-buildbot

generic-assertions)
     check-abi-list
 ;;
 generic-debug-mode)
     clean
     generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Generic-debug-mode.cmake"
     check-runtimes
     # We don't check the ABI lists because the debug mode ABI is not stable
 ;;
-generic-no-transitive-includes)
-    clean
-    generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Generic-no-transitive-includes.cmake"
-    check-runtimes
-;;
 generic-with_llvm_unwinder)
     clean
     generate-cmake -DLIBCXXABI_USE_LLVM_UNWINDER=ON
     check-runtimes
 ;;
 generic-modules)
     clean
     generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Generic-modules.cmake"