Index: clang/include/clang/Basic/DiagnosticSemaKinds.td =================================================================== --- clang/include/clang/Basic/DiagnosticSemaKinds.td +++ clang/include/clang/Basic/DiagnosticSemaKinds.td @@ -4049,6 +4049,9 @@ def warn_attribute_type_not_supported : Warning< "%0 attribute argument not supported: %1">, InGroup; +def warn_attribute_type_not_supported_global : Warning< + "%0 attribute argument not supported for globals: %1">, + InGroup; def warn_attribute_unknown_visibility : Warning<"unknown visibility %0">, InGroup; def warn_attribute_protected_visibility : Index: clang/lib/Sema/SemaDeclAttr.cpp =================================================================== --- clang/lib/Sema/SemaDeclAttr.cpp +++ clang/lib/Sema/SemaDeclAttr.cpp @@ -7877,8 +7877,8 @@ SanitizerName != "coverage") S.Diag(LiteralLoc, diag::warn_unknown_sanitizer_ignored) << SanitizerName; else if (isGlobalVar(D) && !isSanitizerAttributeAllowedOnGlobals(SanitizerName)) - S.Diag(D->getLocation(), diag::err_attribute_wrong_decl_type) - << AL << ExpectedFunctionOrMethod; + S.Diag(D->getLocation(), diag::warn_attribute_type_not_supported_global) + << AL << SanitizerName; Sanitizers.push_back(SanitizerName); } Index: clang/test/SemaCXX/attr-no-sanitize.cpp =================================================================== --- clang/test/SemaCXX/attr-no-sanitize.cpp +++ clang/test/SemaCXX/attr-no-sanitize.cpp @@ -6,6 +6,9 @@ int f2() __attribute__((no_sanitize(1))); // expected-error{{'no_sanitize' attribute requires a string}} +__attribute__((no_sanitize("all"))) int global; // expected-warning{{'no_sanitize' attribute argument not supported for globals: all}} +__attribute__((no_sanitize("unknown"))) int global2; // expected-warning{{unknown sanitizer 'unknown' ignored}} + // DUMP-LABEL: FunctionDecl {{.*}} f3 // DUMP: NoSanitizeAttr {{.*}} address // PRINT: int f3() __attribute__((no_sanitize("address")))