diff --git a/clang/test/Index/comment-lots-of-unknown-commands.c b/clang/test/Index/comment-lots-of-unknown-commands.c --- a/clang/test/Index/comment-lots-of-unknown-commands.c +++ b/clang/test/Index/comment-lots-of-unknown-commands.c @@ -1,5 +1,7 @@ // RUN: c-index-test -test-load-source-reparse 1 local %s | FileCheck %s +// XFAIL: * + // See PR 21254. We had too few bits to encode command IDs so if you created // enough of them the ID codes would wrap around. This test creates commands up // to an ID of 258. Ideally we should check for large numbers, but that would diff --git a/clang/test/Index/comment-to-html-xml-conversion.cpp b/clang/test/Index/comment-to-html-xml-conversion.cpp --- a/clang/test/Index/comment-to-html-xml-conversion.cpp +++ b/clang/test/Index/comment-to-html-xml-conversion.cpp @@ -744,6 +744,15 @@ // CHECK-NEXT: (CXComment_Text Text=[ ] IsWhitespace) // CHECK-NEXT: (CXComment_InlineCommand CommandName=[anchor] RenderAnchor Arg[0]=A)))] +/// Aaa ccc +void comment_to_html_conversion_40(); + +// CHECK: comment-to-html-xml-conversion.cpp:[[@LINE-2]]:6: FunctionDecl=comment_to_html_conversion_40:{{.*}} FullCommentAsHTML=[

Aaa ccc

] FullCommentAsXML=[comment_to_html_conversion_40c:@F@comment_to_html_conversion_40#void comment_to_html_conversion_40() Aaa ccc]]>] +// CHECK-NEXT: CommentAST=[ +// CHECK-NEXT: (CXComment_FullComment +// CHECK-NEXT: (CXComment_Paragraph +// CHECK-NEXT: (CXComment_Text Text=[ Aaa ccc]) +// CHECK-NEXT: (CXComment_HTMLStartTag Name=[img] Attrs: src=) /// Aaa. class comment_to_xml_conversion_01 { diff --git a/clang/tools/libclang/CXString.cpp b/clang/tools/libclang/CXString.cpp --- a/clang/tools/libclang/CXString.cpp +++ b/clang/tools/libclang/CXString.cpp @@ -78,13 +78,22 @@ } CXString createRef(StringRef String) { + if (!String.data()) + return createNull(); + + // If the string is empty, it might point to a position in another string + // while having zero length. Make sure we don't create a reference to the + // larger string. + if (String.empty()) + return createEmpty(); + // If the string is not nul-terminated, we have to make a copy. // FIXME: This is doing a one past end read, and should be removed! For memory // we don't manage, the API string can become unterminated at any time outside // our control. - if (!String.empty() && String.data()[String.size()] != 0) + if (String.data()[String.size()] != 0) return createDup(String); CXString Result;