Index: clang/docs/ReleaseNotes.rst =================================================================== --- clang/docs/ReleaseNotes.rst +++ clang/docs/ReleaseNotes.rst @@ -146,6 +146,12 @@ - A SubstTemplateTypeParmType can now represent the pack index for a substitution from an expanded pack. `Issue 56099 `_ +- Fix C++17 compatibibility warning that checks for use of auto in template + parameters so that it atually has an AutoType before attempting to call + getContainedAutoType(). This Fixes + `Issue 57369 `_ + `Issue 57643 `_ + `Issue 57793 `_ Improvements to Clang's diagnostics Index: clang/lib/Sema/SemaTemplate.cpp =================================================================== --- clang/lib/Sema/SemaTemplate.cpp +++ clang/lib/Sema/SemaTemplate.cpp @@ -1531,11 +1531,11 @@ CheckValidDeclSpecifiers(); - if (TInfo->getType()->isUndeducedType()) { - Diag(D.getIdentifierLoc(), - diag::warn_cxx14_compat_template_nontype_parm_auto_type) - << QualType(TInfo->getType()->getContainedAutoType(), 0); - } + if (const auto *T = TInfo->getType()->getContainedDeducedType()) + if (isa(T)) + Diag(D.getIdentifierLoc(), + diag::warn_cxx14_compat_template_nontype_parm_auto_type) + << QualType(TInfo->getType()->getContainedAutoType(), 0); assert(S->isTemplateParamScope() && "Non-type template parameter not in template parameter scope!"); Index: clang/test/SemaTemplate/gh57362.cpp =================================================================== --- /dev/null +++ clang/test/SemaTemplate/gh57362.cpp @@ -0,0 +1,10 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++20 -Wpre-c++17-compat %s +// expected-no-diagnostics + +namespace GH57362 { +template +class TemplateClass {}; + +template // ok, no diagnostic expected +void func() {} +} Index: clang/test/SemaTemplate/temp_arg_nontype_diagnostic_cxx17.cpp =================================================================== --- /dev/null +++ clang/test/SemaTemplate/temp_arg_nontype_diagnostic_cxx17.cpp @@ -0,0 +1,7 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++17 -Wpre-c++17-compat %s + +template // expected-warning {{non-type template parameters declared with 'decltype(auto)' are incompatible with C++ standards before C++17}} +struct B{}; + +template // expected-warning {{non-type template parameters declared with 'auto' are incompatible with C++ standards before C++17}} +struct A{};