This is an archive of the discontinued LLVM Phabricator instance.

Combining invariant.group metadata bugfix
AbandonedPublic

Authored by Prazek on Sep 28 2015, 10:25 PM.

Details

Diff Detail

Event Timeline

Prazek updated this revision to Diff 35937.Sep 28 2015, 10:25 PM
Prazek retitled this revision from to Combining invariant.group metadata bugfix.
Prazek updated this object.
Prazek added reviewers: rsmith, majnemer, nlewycky.
Prazek added a subscriber: llvm-commits.
reames added a subscriber: reames.Sep 29 2015, 6:13 AM

Test case? Description of problem?

Prazek updated this revision to Diff 35993.Sep 29 2015, 10:06 AM

I could use the same IR that I got the bug on, but it will highly depend on how GVN is combining the instructions. Unfortunatelly I don't know any better approach.

Prazek updated this revision to Diff 36004.Sep 29 2015, 10:40 AM

If the GVN example is reasonable small, that would be fine. In general,
even complex scenarios can be reduced if care is taken to eliminate all
the redundant pieces.

This code is also exercised by simplify-cfg and instcombine. You might
have an easier time constructing a small case from one of those.

Philip

Well, actually I have no idea why I made extra review. I forgot that http://reviews.llvm.org/D12992 is not yet upstream. I am closing this review. I will also add test case

Prazek abandoned this revision.Sep 29 2015, 10:58 AM