Page MenuHomePhabricator

Add clang-query tool to installation targets
ClosedPublic

Authored by foutrelis on Sep 28 2015, 2:50 AM.

Details

Reviewers
klimek
Summary

It has been requested in a bug report downstream in Arch Linux to include the clang-query tool as part of our clang-tools-extra package. [1]

This point has also been brought up on the cfe-dev list and the LLVM bug tracker. [2] [3]

This diff is an attempt at upstreaming this change. Note that it only deals with clang-query since I'm not sure what other tools would be useful to install.

[1] https://bugs.archlinux.org/task/46392#comment139256
[2] http://lists.llvm.org/pipermail/cfe-dev/2015-June/043318.html
[3] https://llvm.org/bugs/show_bug.cgi?id=24046

Diff Detail

Event Timeline

foutrelis updated this revision to Diff 35847.Sep 28 2015, 2:50 AM
foutrelis retitled this revision from to Add clang-query tool to installation targets.
foutrelis updated this object.
foutrelis added a subscriber: cfe-commits.

Just a note that this change is specific to CMake since autotools already installs clang-query (along with some other tools).

klimek accepted this revision.Sep 28 2015, 6:00 AM
klimek added a reviewer: klimek.
klimek added a subscriber: klimek.

LG

As we already a) install it from auto-tools and b) this tool is useful for non-llvm/clang devs

This revision is now accepted and ready to land.Sep 28 2015, 6:00 AM

Thanks for the review.

Can you please commit the patch to clang-tools-extra/trunk (since I don't have commit rights)?

klimek closed this revision.Sep 28 2015, 6:28 AM

Submitted in r248710