diff --git a/llvm/include/llvm/Transforms/IPO/SampleContextTracker.h b/llvm/include/llvm/Transforms/IPO/SampleContextTracker.h --- a/llvm/include/llvm/Transforms/IPO/SampleContextTracker.h +++ b/llvm/include/llvm/Transforms/IPO/SampleContextTracker.h @@ -17,6 +17,7 @@ #include "llvm/ADT/StringMap.h" #include "llvm/ADT/StringRef.h" +#include "llvm/ADT/iterator.h" #include "llvm/ProfileData/SampleProf.h" #include #include @@ -143,8 +144,9 @@ return FuncToCtxtProfiles; } - class Iterator : public std::iterator { + class Iterator : public llvm::iterator_facade_base< + Iterator, std::forward_iterator_tag, ContextTrieNode *, + std::ptrdiff_t, ContextTrieNode **, ContextTrieNode *> { std::queue NodeQueue; public: @@ -159,12 +161,6 @@ return *this; } - Iterator operator++(int) { - assert(!NodeQueue.empty() && "Iterator already at the end"); - Iterator Ret = *this; - ++(*this); - return Ret; - } bool operator==(const Iterator &Other) const { if (NodeQueue.empty() && Other.NodeQueue.empty()) return true; @@ -172,7 +168,7 @@ return false; return NodeQueue.front() == Other.NodeQueue.front(); } - bool operator!=(const Iterator &Other) const { return !(*this == Other); } + ContextTrieNode *operator*() const { assert(!NodeQueue.empty() && "Invalid access to end iterator"); return NodeQueue.front(); diff --git a/llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCInstrInfo.h b/llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCInstrInfo.h --- a/llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCInstrInfo.h +++ b/llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCInstrInfo.h @@ -15,6 +15,7 @@ #include "llvm/ADT/SmallVector.h" #include "llvm/ADT/StringRef.h" +#include "llvm/ADT/iterator.h" #include "llvm/ADT/iterator_range.h" #include "llvm/MC/MCInst.h" #include "llvm/Support/MathExtras.h" @@ -41,8 +42,9 @@ namespace Hexagon { -class PacketIterator : public std::iterator { +class PacketIterator + : public llvm::iterator_facade_base< + PacketIterator, std::forward_iterator_tag, const MCInst> { MCInstrInfo const &MCII; MCInst::const_iterator BundleCurrent; MCInst::const_iterator BundleEnd; @@ -56,9 +58,6 @@ PacketIterator &operator++(); MCInst const &operator*() const; bool operator==(PacketIterator const &Other) const; - bool operator!=(PacketIterator const &Other) const { - return !(*this == Other); - } }; } // end namespace Hexagon diff --git a/llvm/unittests/ADT/IteratorTest.cpp b/llvm/unittests/ADT/IteratorTest.cpp --- a/llvm/unittests/ADT/IteratorTest.cpp +++ b/llvm/unittests/ADT/IteratorTest.cpp @@ -19,8 +19,9 @@ template struct Shadow; -struct WeirdIter : std::iterator, Shadow<1>, - Shadow<2>, Shadow<3>> {}; +struct WeirdIter + : llvm::iterator_facade_base, + Shadow<1>, Shadow<2>, Shadow<3>> {}; struct AdaptedIter : iterator_adaptor_base {};