Index: clang/docs/ReleaseNotes.rst =================================================================== --- clang/docs/ReleaseNotes.rst +++ clang/docs/ReleaseNotes.rst @@ -60,6 +60,9 @@ - No longer assert/miscompile when trying to make a vectorized ``_BitInt`` type using the ``ext_vector_type`` attribute (the ``vector_size`` attribute was already properly diagnosing this case). +- Fixed a crash-on-valid with consteval evaluation of a list-initialized + constructor for a temporary object. This fixes + `Issue 55871 `_. Improvements to Clang's diagnostics ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Index: clang/lib/CodeGen/CGExprConstant.cpp =================================================================== --- clang/lib/CodeGen/CGExprConstant.cpp +++ clang/lib/CodeGen/CGExprConstant.cpp @@ -1396,11 +1396,24 @@ if (!CE->hasAPValueResult()) return nullptr; const Expr *Inner = CE->getSubExpr()->IgnoreImplicit(); - QualType RetType; + + // In a call below, emitAbstract() calls tryEmitPrivate() and *some parts* of + // that call will use the RetType we pass in here. The parts which do make + // use of it expect that the QualType is valid, which is why we give it a + // default value here and reset the type only as needed. + QualType RetType = Inner->getType(); if (auto *Call = dyn_cast(Inner)) RetType = Call->getCallReturnType(CGM.getContext()); else if (auto *Ctor = dyn_cast(Inner)) RetType = Ctor->getType(); + else if (auto *Cast = dyn_cast(Inner)) { + // FIXME: This is working around a deficiency in template instantiation; + // see TreeTransform::TransformCXXTemporaryObjectExpr and GitHub Issue + // #55871 for more details. + RetType = Cast->getType(); + } + + assert(!RetType.isNull() && "Not certain of the constant expression's type"); llvm::Constant *Res = emitAbstract(CE->getBeginLoc(), CE->getAPValueResult(), RetType); return Res; Index: clang/test/CodeGenCXX/cxx20-consteval-crash.cpp =================================================================== --- clang/test/CodeGenCXX/cxx20-consteval-crash.cpp +++ clang/test/CodeGenCXX/cxx20-consteval-crash.cpp @@ -56,3 +56,18 @@ // CHECK: define{{.*}} signext i8 @_ZN10Issue545782f2IcEEcT_( // CHECK: ret i8 4 } + +namespace Issue55871 { +struct Item { + consteval Item(char c) :_char{c}{} + char _char; +}; + +int function(const Item& item1, const Item& item2) { + return 0; +} + +int foo() { + return function(Item{'a'}, Item{'a'}); +} +} // namespace Issue58871