diff --git a/lldb/source/Plugins/Language/ObjC/NSArray.cpp b/lldb/source/Plugins/Language/ObjC/NSArray.cpp --- a/lldb/source/Plugins/Language/ObjC/NSArray.cpp +++ b/lldb/source/Plugins/Language/ObjC/NSArray.cpp @@ -532,9 +532,8 @@ process_sp->ReadMemory(data_location, m_data_64, sizeof(D64), error); } - if (error.Fail()) - return false; - return false; + + return error.Success(); } bool @@ -675,9 +674,8 @@ process_sp->ReadMemory(data_location, m_data_64, sizeof(D64), error); } - if (error.Fail()) - return false; - return false; + + return error.Success(); } template diff --git a/lldb/source/Plugins/Language/ObjC/NSDictionary.cpp b/lldb/source/Plugins/Language/ObjC/NSDictionary.cpp --- a/lldb/source/Plugins/Language/ObjC/NSDictionary.cpp +++ b/lldb/source/Plugins/Language/ObjC/NSDictionary.cpp @@ -1121,9 +1121,8 @@ process_sp->ReadMemory(data_location, m_data_64, sizeof(D64), error); } - if (error.Fail()) - return false; - return true; + + return error.Success(); } template @@ -1284,9 +1283,8 @@ process_sp->ReadMemory(data_location, m_data_64, sizeof(DataDescriptor_64), error); } - if (error.Fail()) - return false; - return false; + + return error.Success(); } bool diff --git a/lldb/source/Plugins/Language/ObjC/NSSet.cpp b/lldb/source/Plugins/Language/ObjC/NSSet.cpp --- a/lldb/source/Plugins/Language/ObjC/NSSet.cpp +++ b/lldb/source/Plugins/Language/ObjC/NSSet.cpp @@ -461,7 +461,7 @@ if (error.Fail()) return false; m_data_ptr = data_location + m_ptr_size; - return false; + return true; } bool lldb_private::formatters::NSSetISyntheticFrontEnd::MightHaveChildren() { @@ -735,9 +735,7 @@ process_sp->ReadMemory(data_location, m_data_64, sizeof(D64), error); } - if (error.Fail()) - return false; - return false; + return error.Success(); } template