Index: llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp =================================================================== --- llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp +++ llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp @@ -1488,14 +1488,15 @@ return ReplaceInstUsesWith(I, Res); - // fold (and (cast A), (cast B)) -> (cast (and A, B)) - if (CastInst *Op0C = dyn_cast(Op0)) + if (CastInst *Op0C = dyn_cast(Op0)) { + Value *Op0COp = Op0C->getOperand(0); + Type *SrcTy = Op0COp->getType(); + // fold (and (cast A), (cast B)) -> (cast (and A, B)) if (CastInst *Op1C = dyn_cast(Op1)) { - Type *SrcTy = Op0C->getOperand(0)->getType(); if (Op0C->getOpcode() == Op1C->getOpcode() && // same cast kind ? SrcTy == Op1C->getOperand(0)->getType() && SrcTy->isIntOrIntVectorTy()) { - Value *Op0COp = Op0C->getOperand(0), *Op1COp = Op1C->getOperand(0); + Value *Op1COp = Op1C->getOperand(0); // Only do this if the casts both really cause code to be generated. if (ShouldOptimizeCast(Op0C->getOpcode(), Op0COp, I.getType()) && @@ -1520,6 +1521,20 @@ } } + // If we are masking off the sign bit of a floating-point value, convert + // this to the canonical fabs intrinsic call and cast back to integer. + // The backend should know how to optimize fabs(). + // TODO: This transform should also apply to vectors. + ConstantInt *CI; + if (isa(Op0C) && SrcTy->isFloatingPointTy() && + match(Op1, m_ConstantInt(CI)) && CI->isMaxValue(true)) { + Module *M = I.getParent()->getParent()->getParent(); + Function *Fabs = Intrinsic::getDeclaration(M, Intrinsic::fabs, SrcTy); + Value *Call = Builder->CreateCall(Fabs, Op0COp, "fabs"); + return CastInst::CreateBitOrPointerCast(Call, I.getType()); + } + } + { Value *X = nullptr; bool OpsSwapped = false; Index: llvm/trunk/test/Transforms/InstCombine/and2.ll =================================================================== --- llvm/trunk/test/Transforms/InstCombine/and2.ll +++ llvm/trunk/test/Transforms/InstCombine/and2.ll @@ -102,3 +102,46 @@ %add = add i64 %sub, %and ret i64 %add } + +define i64 @fabs_double(double %x) { +; CHECK-LABEL: @fabs_double( +; CHECK-NEXT: %fabs = call double @llvm.fabs.f64(double %x) +; CHECK-NEXT: %and = bitcast double %fabs to i64 +; CHECK-NEXT: ret i64 %and + %bc = bitcast double %x to i64 + %and = and i64 %bc, 9223372036854775807 + ret i64 %and +} + +define i64 @fabs_double_swap(double %x) { +; CHECK-LABEL: @fabs_double_swap( +; CHECK-NEXT: %fabs = call double @llvm.fabs.f64(double %x) +; CHECK-NEXT: %and = bitcast double %fabs to i64 +; CHECK-NEXT: ret i64 %and + %bc = bitcast double %x to i64 + %and = and i64 9223372036854775807, %bc + ret i64 %and +} + +define i32 @fabs_float(float %x) { +; CHECK-LABEL: @fabs_float( +; CHECK-NEXT: %fabs = call float @llvm.fabs.f32(float %x) +; CHECK-NEXT: %and = bitcast float %fabs to i32 +; CHECK-NEXT: ret i32 %and + %bc = bitcast float %x to i32 + %and = and i32 %bc, 2147483647 + ret i32 %and +} + +; Make sure that only a bitcast is transformed. + +define i64 @fabs_double_not_bitcast(double %x) { +; CHECK-LABEL: @fabs_double_not_bitcast( +; CHECK-NEXT: %bc = fptoui double %x to i64 +; CHECK-NEXT: %and = and i64 %bc, 9223372036854775807 +; CHECK-NEXT: ret i64 %and + %bc = fptoui double %x to i64 + %and = and i64 %bc, 9223372036854775807 + ret i64 %and +} +