Page MenuHomePhabricator

[llvm-readobj] Avoid SEGFAULT if a requested symbol section is absent
ClosedPublic

Authored by ikudrin on Sep 21 2015, 8:39 AM.

Details

Reviewers
rafael
Summary

Some files can have no dynamic symbols section. Others can even have no regular symbol section. The tool shouldn't crash if it's requested to show such sections.

Diff Detail

Event Timeline

ikudrin updated this revision to Diff 35259.Sep 21 2015, 8:39 AM
ikudrin retitled this revision from to [llvm-readobj] Avoid SEGFAULT if a requested symbol section is absent.
ikudrin updated this object.
ikudrin added a reviewer: rafael.
ikudrin added a subscriber: llvm-commits.
rafael accepted this revision.Sep 21 2015, 8:54 AM
rafael edited edge metadata.

LGTM

This revision is now accepted and ready to land.Sep 21 2015, 8:54 AM

Could you please apply this patch as I don't have write permissions?

ikudrin closed this revision.Sep 21 2015, 11:17 PM

Thank you a lot!