diff --git a/llvm/lib/CodeGen/TailDuplicator.cpp b/llvm/lib/CodeGen/TailDuplicator.cpp --- a/llvm/lib/CodeGen/TailDuplicator.cpp +++ b/llvm/lib/CodeGen/TailDuplicator.cpp @@ -798,6 +798,8 @@ return false; if (!PredCond.empty()) return false; + if (TailBB->isInlineAsmBrIndirectTarget()) + return false; return true; } diff --git a/llvm/test/CodeGen/AArch64/callbr-asm-obj-file.ll b/llvm/test/CodeGen/AArch64/callbr-asm-obj-file.ll --- a/llvm/test/CodeGen/AArch64/callbr-asm-obj-file.ll +++ b/llvm/test/CodeGen/AArch64/callbr-asm-obj-file.ll @@ -72,7 +72,7 @@ ; CHECK-LABEL: : ; CHECK-LABEL: <$d.9>: ; CHECK-LABEL: <$x.10>: -; CHECK-NEXT: b {{.*}} +; CHECK-NEXT: b {{.*}} <$x.12+0x4> ; CHECK-LABEL: <$x.12>: ; CHECK-NEXT: mov w0, wzr ; CHECK-NEXT: ldr x30, [sp], #16 diff --git a/llvm/test/CodeGen/X86/callbr-asm-outputs.ll b/llvm/test/CodeGen/X86/callbr-asm-outputs.ll --- a/llvm/test/CodeGen/X86/callbr-asm-outputs.ll +++ b/llvm/test/CodeGen/X86/callbr-asm-outputs.ll @@ -178,15 +178,15 @@ ; CHECK-NEXT: # %bb.2: # %asm.fallthrough2 ; CHECK-NEXT: addl %edx, %ecx ; CHECK-NEXT: movl %ecx, %eax +; CHECK-NEXT: .LBB3_4: # Block address taken +; CHECK-NEXT: # %return +; CHECK-NEXT: # Label of block must be emitted ; CHECK-NEXT: retl ; CHECK-NEXT: .LBB3_3: # Block address taken ; CHECK-NEXT: # %label_true ; CHECK-NEXT: # Label of block must be emitted ; CHECK-NEXT: movl $-2, %eax -; CHECK-NEXT: .LBB3_4: # Block address taken -; CHECK-NEXT: # %return -; CHECK-NEXT: # Label of block must be emitted -; CHECK-NEXT: retl +; CHECK-NEXT: jmp .LBB3_4 entry: %0 = callbr { i32, i32 } asm sideeffect "testl $0, $0; testl $1, $2; jne ${3:l}", "=r,=r,r,!i,!i,~{dirflag},~{fpsr},~{flags}"(i32 %out1) to label %asm.fallthrough [label %label_true, label %return] diff --git a/llvm/test/CodeGen/X86/tail-dup-asm-goto.ll b/llvm/test/CodeGen/X86/tail-dup-asm-goto.ll --- a/llvm/test/CodeGen/X86/tail-dup-asm-goto.ll +++ b/llvm/test/CodeGen/X86/tail-dup-asm-goto.ll @@ -69,3 +69,79 @@ kmem_cache_has_cpu_partial.exit: ; preds = %bb110 ret ptr %i10.1 } + +define void @ceph_con_v2_try_read(i32 %__trans_tmp_3.sroa.0.0.copyload, i1 %tobool.not.i.i) nounwind { + ; CHECK-LABEL: name: ceph_con_v2_try_read + ; CHECK: bb.0.entry: + ; CHECK-NEXT: successors: %bb.1(0x80000000) + ; CHECK-NEXT: liveins: $edi, $esi + ; CHECK-NEXT: {{ $}} + ; CHECK-NEXT: [[COPY:%[0-9]+]]:gr32 = COPY $esi + ; CHECK-NEXT: [[COPY1:%[0-9]+]]:gr32 = COPY $edi + ; CHECK-NEXT: [[COPY2:%[0-9]+]]:gr8 = COPY [[COPY]].sub_8bit + ; CHECK-NEXT: {{ $}} + ; CHECK-NEXT: bb.1.for.cond: + ; CHECK-NEXT: successors: %bb.2(0x30000000), %bb.1(0x50000000) + ; CHECK-NEXT: {{ $}} + ; CHECK-NEXT: TEST32rr [[COPY1]], [[COPY1]], implicit-def $eflags + ; CHECK-NEXT: JCC_1 %bb.1, 5, implicit $eflags + ; CHECK-NEXT: JMP_1 %bb.2 + ; CHECK-NEXT: {{ $}} + ; CHECK-NEXT: bb.2.sw.bb: + ; CHECK-NEXT: successors: %bb.3(0x40000000), %bb.4(0x40000000) + ; CHECK-NEXT: {{ $}} + ; CHECK-NEXT: ADJCALLSTACKDOWN64 0, 0, 0, implicit-def dead $rsp, implicit-def dead $eflags, implicit-def dead $ssp, implicit $rsp, implicit $ssp + ; CHECK-NEXT: [[MOV32r0_:%[0-9]+]]:gr32 = MOV32r0 implicit-def dead $eflags + ; CHECK-NEXT: [[SUBREG_TO_REG:%[0-9]+]]:gr64 = SUBREG_TO_REG 0, killed [[MOV32r0_]], %subreg.sub_32bit + ; CHECK-NEXT: [[LEA64r:%[0-9]+]]:gr64 = LEA64r %stack.0.skip.i.i, 1, $noreg, 0, $noreg + ; CHECK-NEXT: $rdi = COPY [[LEA64r]] + ; CHECK-NEXT: CALL64r killed [[SUBREG_TO_REG]], csr_64, implicit $rsp, implicit $ssp, implicit $rdi, implicit-def $rsp, implicit-def $ssp, implicit-def $eax + ; CHECK-NEXT: ADJCALLSTACKUP64 0, 0, implicit-def dead $rsp, implicit-def dead $eflags, implicit-def dead $ssp, implicit $rsp, implicit $ssp + ; CHECK-NEXT: [[COPY3:%[0-9]+]]:gr32 = COPY $eax + ; CHECK-NEXT: TEST8ri [[COPY2]], 1, implicit-def $eflags + ; CHECK-NEXT: JCC_1 %bb.4, 4, implicit $eflags + ; CHECK-NEXT: JMP_1 %bb.3 + ; CHECK-NEXT: {{ $}} + ; CHECK-NEXT: bb.3.if.else.i.i: + ; CHECK-NEXT: successors: %bb.5(0x80000000) + ; CHECK-NEXT: {{ $}} + ; CHECK-NEXT: INLINEASM_BR &"", 1 /* sideeffect attdialect */, 13 /* imm */, %bb.5 + ; CHECK-NEXT: JMP_1 %bb.5 + ; CHECK-NEXT: {{ $}} + ; CHECK-NEXT: bb.4.process_message_header.exit.i: + ; CHECK-NEXT: successors: %bb.1(0x80000000) + ; CHECK-NEXT: {{ $}} + ; CHECK-NEXT: LIFETIME_END %stack.0.skip.i.i + ; CHECK-NEXT: JMP_1 %bb.1 + ; CHECK-NEXT: {{ $}} + ; CHECK-NEXT: bb.5.if.end.i (machine-block-address-taken, inlineasm-br-indirect-target): + ; CHECK-NEXT: successors: %bb.1(0x80000000) + ; CHECK-NEXT: {{ $}} + ; CHECK-NEXT: LIFETIME_END %stack.0.skip.i.i + ; CHECK-NEXT: JMP_1 %bb.1 +entry: + %skip.i.i = alloca i32, i32 0, align 4 + %cond = icmp eq i32 %__trans_tmp_3.sroa.0.0.copyload, 0 + br label %for.cond + +for.cond: + br i1 %cond, label %sw.bb, label %for.cond + +sw.bb: + %call.i.i2 = call i32 null(ptr %skip.i.i) + br i1 %tobool.not.i.i, label %if.else.i.i, label %process_message_header.exit.i + +if.else.i.i: + callbr void asm sideeffect "", "!i"() + to label %if.end.i [label %if.end.i] + +process_message_header.exit.i: + call void @llvm.lifetime.end.p0(i64 0, ptr %skip.i.i) + br label %for.cond + +if.end.i: + call void @llvm.lifetime.end.p0(i64 0, ptr %skip.i.i) + br label %for.cond +} + +declare void @llvm.lifetime.end.p0(i64 immarg, ptr nocapture)