diff --git a/mlir/lib/TableGen/AttrOrTypeDef.cpp b/mlir/lib/TableGen/AttrOrTypeDef.cpp --- a/mlir/lib/TableGen/AttrOrTypeDef.cpp +++ b/mlir/lib/TableGen/AttrOrTypeDef.cpp @@ -85,19 +85,13 @@ "'assemblyFormat' or 'hasCustomAssemblyFormat' can only be " "used when 'mnemonic' is set"); } - // Assembly format parser requires builders with the same prototype - // as the default-builders. - // TODO: attempt to detect when a custom builder matches the prototype. - if (hasDeclarativeFormat && skipDefaultBuilders()) { - PrintWarning(getLoc(), - "using 'assemblyFormat' with 'skipDefaultBuilders=1' may " - "result in C++ compilation errors"); - } // Assembly format printer requires accessors to be generated. if (hasDeclarativeFormat && !genAccessors()) { PrintFatalError(getLoc(), "'assemblyFormat' requires 'genAccessors' to be true"); } + // TODO: Ensure that a suitable builder prototype can be generated: + // https://llvm.org/PR56415 } Dialect AttrOrTypeDef::getDialect() const {