This is an archive of the discontinued LLVM Phabricator instance.

[libc] Make div test names unique
ClosedPublic

Authored by abrachet on Jul 6 2022, 10:27 PM.

Details

Summary

In Fuchsia, all tests in a directory, ie stdlib, are linked into one executable, this causes problems for multiple definitions of the vtables of the div tests because their class has the same name. This patch just trivially changes their name to be unique between all div tests.

Diff Detail

Event Timeline

abrachet created this revision.Jul 6 2022, 10:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2022, 10:27 PM
abrachet requested review of this revision.Jul 6 2022, 10:27 PM
abrachet added a subscriber: libc-commits.
sivachandra accepted this revision.Jul 6 2022, 11:25 PM
sivachandra added inline comments.
libc/test/src/stdlib/DivTest.h
37

Can CAT be inlined?

This revision is now accepted and ready to land.Jul 6 2022, 11:25 PM
This revision was landed with ongoing or failed builds.Jul 7 2022, 8:08 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2022, 8:08 AM
abrachet marked an inline comment as done.Jul 7 2022, 8:08 AM
abrachet added inline comments.
libc/test/src/stdlib/DivTest.h
37

Ah you're right. For some reason I thought there would be some issue with not forcing this to be evaluated first. I have committed it with just SimpleTest##ReturnType