diff --git a/llvm/include/llvm/IR/OptBisect.h b/llvm/include/llvm/IR/OptBisect.h --- a/llvm/include/llvm/IR/OptBisect.h +++ b/llvm/include/llvm/IR/OptBisect.h @@ -15,7 +15,6 @@ #define LLVM_IR_OPTBISECT_H #include "llvm/ADT/StringRef.h" -#include "llvm/Support/ManagedStatic.h" #include namespace llvm { @@ -90,7 +89,8 @@ /// Singleton instance of the OptBisect class, so multiple pass managers don't /// need to coordinate their uses of OptBisect. -extern ManagedStatic OptBisector; +OptBisect &getOptBisector(); + } // end namespace llvm #endif // LLVM_IR_OPTBISECT_H diff --git a/llvm/lib/Analysis/TFUtils.cpp b/llvm/lib/Analysis/TFUtils.cpp --- a/llvm/lib/Analysis/TFUtils.cpp +++ b/llvm/lib/Analysis/TFUtils.cpp @@ -18,7 +18,6 @@ #include "llvm/Support/CommandLine.h" #include "llvm/Support/Debug.h" #include "llvm/Support/JSON.h" -#include "llvm/Support/ManagedStatic.h" #include "llvm/Support/MemoryBuffer.h" #include "llvm/Support/Path.h" #include "llvm/Support/raw_ostream.h" @@ -49,19 +48,17 @@ struct TFInitializer { TFInitializer() { - assert(!IsInitialized && "TFInitialized should be called only once"); int Argc = 1; const char *Name = ""; const char **NamePtr = &Name; TF_InitMain(Name, &Argc, const_cast(&NamePtr)); - IsInitialized = true; } - bool IsInitialized = false; }; -llvm::ManagedStatic TFLibInitializer; - -bool ensureInitTF() { return TFLibInitializer->IsInitialized; } +bool ensureInitTF() { + static TFInitializer TFLibInitializer; + return true; +} TFGraphPtr createTFGraph() { return TFGraphPtr(TF_NewGraph(), &TF_DeleteGraph); diff --git a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp --- a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp +++ b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp @@ -69,7 +69,6 @@ #include "llvm/Support/Error.h" #include "llvm/Support/ErrorHandling.h" #include "llvm/Support/ErrorOr.h" -#include "llvm/Support/ManagedStatic.h" #include "llvm/Support/MathExtras.h" #include "llvm/Support/MemoryBuffer.h" #include "llvm/Support/raw_ostream.h" @@ -7446,10 +7445,9 @@ } // end anonymous namespace -static ManagedStatic ErrorCategory; - const std::error_category &llvm::BitcodeErrorCategory() { - return *ErrorCategory; + static BitcodeErrorCategoryType ErrorCategory; + return ErrorCategory; } static Expected readBlobInRecord(BitstreamCursor &Stream, diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp --- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp @@ -60,7 +60,6 @@ #include "llvm/Support/ErrorHandling.h" #include "llvm/Support/KnownBits.h" #include "llvm/Support/MachineValueType.h" -#include "llvm/Support/ManagedStatic.h" #include "llvm/Support/MathExtras.h" #include "llvm/Support/Mutex.h" #include "llvm/Support/raw_ostream.h" @@ -10754,19 +10753,19 @@ } // end anonymous namespace -static ManagedStatic> EVTs; -static ManagedStatic SimpleVTArray; -static ManagedStatic> VTMutex; - /// getValueTypeList - Return a pointer to the specified value type. /// const EVT *SDNode::getValueTypeList(EVT VT) { + static std::set EVTs; + static EVTArray SimpleVTArray; + static sys::SmartMutex VTMutex; + if (VT.isExtended()) { - sys::SmartScopedLock Lock(*VTMutex); - return &(*EVTs->insert(VT).first); + sys::SmartScopedLock Lock(VTMutex); + return &(*EVTs.insert(VT).first); } assert(VT.getSimpleVT() < MVT::VALUETYPE_SIZE && "Value type out of range!"); - return &SimpleVTArray->VTs[VT.getSimpleVT().SimpleTy]; + return &SimpleVTArray.VTs[VT.getSimpleVT().SimpleTy]; } /// hasNUsesOfValue - Return true if there are exactly NUSES uses of the diff --git a/llvm/lib/DebugInfo/CodeView/CodeViewError.cpp b/llvm/lib/DebugInfo/CodeView/CodeViewError.cpp --- a/llvm/lib/DebugInfo/CodeView/CodeViewError.cpp +++ b/llvm/lib/DebugInfo/CodeView/CodeViewError.cpp @@ -8,7 +8,6 @@ #include "llvm/DebugInfo/CodeView/CodeViewError.h" #include "llvm/Support/ErrorHandling.h" -#include "llvm/Support/ManagedStatic.h" #include using namespace llvm; @@ -42,9 +41,9 @@ }; } // namespace -static llvm::ManagedStatic CodeViewErrCategory; const std::error_category &llvm::codeview::CVErrorCategory() { - return *CodeViewErrCategory; + static CodeViewErrorCategory CodeViewErrCategory; + return CodeViewErrCategory; } char CodeViewError::ID; diff --git a/llvm/lib/DebugInfo/MSF/MSFError.cpp b/llvm/lib/DebugInfo/MSF/MSFError.cpp --- a/llvm/lib/DebugInfo/MSF/MSFError.cpp +++ b/llvm/lib/DebugInfo/MSF/MSFError.cpp @@ -8,7 +8,6 @@ #include "llvm/DebugInfo/MSF/MSFError.h" #include "llvm/Support/ErrorHandling.h" -#include "llvm/Support/ManagedStatic.h" #include using namespace llvm; @@ -50,7 +49,9 @@ }; } // namespace -static llvm::ManagedStatic MSFCategory; -const std::error_category &llvm::msf::MSFErrCategory() { return *MSFCategory; } +const std::error_category &llvm::msf::MSFErrCategory() { + static MSFErrorCategory MSFCategory; + return MSFCategory; +} char MSFError::ID; diff --git a/llvm/lib/DebugInfo/PDB/DIA/DIAError.cpp b/llvm/lib/DebugInfo/PDB/DIA/DIAError.cpp --- a/llvm/lib/DebugInfo/PDB/DIA/DIAError.cpp +++ b/llvm/lib/DebugInfo/PDB/DIA/DIAError.cpp @@ -1,6 +1,5 @@ #include "llvm/DebugInfo/PDB/DIA/DIAError.h" #include "llvm/Support/ErrorHandling.h" -#include "llvm/Support/ManagedStatic.h" using namespace llvm; using namespace llvm::pdb; @@ -31,7 +30,9 @@ } }; -static llvm::ManagedStatic DIACategory; -const std::error_category &llvm::pdb::DIAErrCategory() { return *DIACategory; } +const std::error_category &llvm::pdb::DIAErrCategory() { + static DIAErrorCategory DIACategory; + return DIACategory; +} char DIAError::ID; diff --git a/llvm/lib/DebugInfo/PDB/GenericError.cpp b/llvm/lib/DebugInfo/PDB/GenericError.cpp --- a/llvm/lib/DebugInfo/PDB/GenericError.cpp +++ b/llvm/lib/DebugInfo/PDB/GenericError.cpp @@ -8,7 +8,6 @@ #include "llvm/DebugInfo/PDB/GenericError.h" #include "llvm/Support/ErrorHandling.h" -#include "llvm/Support/ManagedStatic.h" using namespace llvm; using namespace llvm::pdb; @@ -42,7 +41,9 @@ }; } // namespace -static llvm::ManagedStatic PDBCategory; -const std::error_category &llvm::pdb::PDBErrCategory() { return *PDBCategory; } +const std::error_category &llvm::pdb::PDBErrCategory() { + static PDBErrorCategory PDBCategory; + return PDBCategory; +} char PDBError::ID; diff --git a/llvm/lib/DebugInfo/PDB/Native/RawError.cpp b/llvm/lib/DebugInfo/PDB/Native/RawError.cpp --- a/llvm/lib/DebugInfo/PDB/Native/RawError.cpp +++ b/llvm/lib/DebugInfo/PDB/Native/RawError.cpp @@ -1,6 +1,5 @@ #include "llvm/DebugInfo/PDB/Native/RawError.h" #include "llvm/Support/ErrorHandling.h" -#include "llvm/Support/ManagedStatic.h" using namespace llvm; using namespace llvm::pdb; @@ -47,7 +46,9 @@ }; } // namespace -static llvm::ManagedStatic RawCategory; -const std::error_category &llvm::pdb::RawErrCategory() { return *RawCategory; } +const std::error_category &llvm::pdb::RawErrCategory() { + static RawErrorCategory RawCategory; + return RawCategory; +} char RawError::ID; diff --git a/llvm/lib/ExecutionEngine/GDBRegistrationListener.cpp b/llvm/lib/ExecutionEngine/GDBRegistrationListener.cpp --- a/llvm/lib/ExecutionEngine/GDBRegistrationListener.cpp +++ b/llvm/lib/ExecutionEngine/GDBRegistrationListener.cpp @@ -12,7 +12,6 @@ #include "llvm/Object/ObjectFile.h" #include "llvm/Support/Compiler.h" #include "llvm/Support/ErrorHandling.h" -#include "llvm/Support/ManagedStatic.h" #include "llvm/Support/MemoryBuffer.h" #include "llvm/Support/Mutex.h" #include @@ -123,7 +122,10 @@ /// Lock used to serialize all jit registration events, since they /// modify global variables. -ManagedStatic JITDebugLock; +sys::Mutex &getJITDebugLock() { + static sys::Mutex JITDebugLock; + return JITDebugLock; +} /// Do the registration. void NotifyDebugger(jit_code_entry* JITCodeEntry) { @@ -143,7 +145,7 @@ GDBJITRegistrationListener::~GDBJITRegistrationListener() { // Free all registered object files. - std::lock_guard locked(*JITDebugLock); + std::lock_guard locked(getJITDebugLock()); for (RegisteredObjectBufferMap::iterator I = ObjectBufferMap.begin(), E = ObjectBufferMap.end(); I != E; ++I) { @@ -167,7 +169,7 @@ const char *Buffer = DebugObj.getBinary()->getMemoryBufferRef().getBufferStart(); size_t Size = DebugObj.getBinary()->getMemoryBufferRef().getBufferSize(); - std::lock_guard locked(*JITDebugLock); + std::lock_guard locked(getJITDebugLock()); assert(ObjectBufferMap.find(K) == ObjectBufferMap.end() && "Second attempt to perform debug registration."); jit_code_entry* JITCodeEntry = new jit_code_entry(); @@ -186,7 +188,7 @@ } void GDBJITRegistrationListener::notifyFreeingObject(ObjectKey K) { - std::lock_guard locked(*JITDebugLock); + std::lock_guard locked(getJITDebugLock()); RegisteredObjectBufferMap::iterator I = ObjectBufferMap.find(K); if (I != ObjectBufferMap.end()) { @@ -228,14 +230,13 @@ JITCodeEntry = nullptr; } -llvm::ManagedStatic GDBRegListener; - } // end namespace namespace llvm { JITEventListener* JITEventListener::createGDBRegistrationListener() { - return &*GDBRegListener; + static GDBJITRegistrationListener GDBRegListener; + return &GDBRegListener; } } // namespace llvm diff --git a/llvm/lib/ExecutionEngine/JITLink/JITLink.cpp b/llvm/lib/ExecutionEngine/JITLink/JITLink.cpp --- a/llvm/lib/ExecutionEngine/JITLink/JITLink.cpp +++ b/llvm/lib/ExecutionEngine/JITLink/JITLink.cpp @@ -12,7 +12,6 @@ #include "llvm/ExecutionEngine/JITLink/ELF.h" #include "llvm/ExecutionEngine/JITLink/MachO.h" #include "llvm/Support/Format.h" -#include "llvm/Support/ManagedStatic.h" #include "llvm/Support/MemoryBuffer.h" #include "llvm/Support/raw_ostream.h" @@ -41,8 +40,6 @@ } }; -static ManagedStatic JITLinkerErrorCategory; - } // namespace namespace llvm { @@ -53,7 +50,8 @@ void JITLinkError::log(raw_ostream &OS) const { OS << ErrMsg; } std::error_code JITLinkError::convertToErrorCode() const { - return std::error_code(GenericJITLinkError, *JITLinkerErrorCategory); + static JITLinkerErrorCategory TheJITLinkerErrorCategory; + return std::error_code(GenericJITLinkError, TheJITLinkerErrorCategory); } const char *getGenericEdgeKindName(Edge::Kind K) { diff --git a/llvm/lib/ExecutionEngine/Orc/Shared/OrcError.cpp b/llvm/lib/ExecutionEngine/Orc/Shared/OrcError.cpp --- a/llvm/lib/ExecutionEngine/Orc/Shared/OrcError.cpp +++ b/llvm/lib/ExecutionEngine/Orc/Shared/OrcError.cpp @@ -12,7 +12,6 @@ #include "llvm/ExecutionEngine/Orc/Shared/OrcError.h" #include "llvm/Support/ErrorHandling.h" -#include "llvm/Support/ManagedStatic.h" #include @@ -70,7 +69,10 @@ } }; -static ManagedStatic OrcErrCat; +OrcErrorCategory &getOrcErrCat() { + static OrcErrorCategory OrcErrCat; + return OrcErrCat; +} } // namespace namespace llvm { @@ -81,7 +83,7 @@ std::error_code orcError(OrcErrorCode ErrCode) { typedef std::underlying_type::type UT; - return std::error_code(static_cast(ErrCode), *OrcErrCat); + return std::error_code(static_cast(ErrCode), getOrcErrCat()); } DuplicateDefinition::DuplicateDefinition(std::string SymbolName) @@ -105,7 +107,7 @@ std::error_code JITSymbolNotFound::convertToErrorCode() const { typedef std::underlying_type::type UT; return std::error_code(static_cast(OrcErrorCode::JITSymbolNotFound), - *OrcErrCat); + getOrcErrCat()); } void JITSymbolNotFound::log(raw_ostream &OS) const { diff --git a/llvm/lib/ExecutionEngine/Orc/TargetProcess/JITLoaderGDB.cpp b/llvm/lib/ExecutionEngine/Orc/TargetProcess/JITLoaderGDB.cpp --- a/llvm/lib/ExecutionEngine/Orc/TargetProcess/JITLoaderGDB.cpp +++ b/llvm/lib/ExecutionEngine/Orc/TargetProcess/JITLoaderGDB.cpp @@ -11,7 +11,6 @@ #include "llvm/ExecutionEngine/JITSymbol.h" #include "llvm/Support/BinaryStreamReader.h" #include "llvm/Support/FormatVariadic.h" -#include "llvm/Support/ManagedStatic.h" #include #include @@ -67,9 +66,6 @@ using namespace llvm; using namespace llvm::orc; -// Serialize rendezvous with the debugger as well as access to shared data. -ManagedStatic JITDebugLock; - // Register debug object, return error message or null for success. static void registerJITLoaderGDBImpl(const char *ObjAddr, size_t Size) { LLVM_DEBUG({ @@ -85,7 +81,9 @@ E->symfile_size = Size; E->prev_entry = nullptr; - std::lock_guard Lock(*JITDebugLock); + // Serialize rendezvous with the debugger as well as access to shared data. + static std::mutex JITDebugLock; + std::lock_guard Lock(JITDebugLock); // Insert this entry at the head of the list. jit_code_entry *NextEntry = __jit_debug_descriptor.first_entry; diff --git a/llvm/lib/ExecutionEngine/PerfJITEvents/PerfJITEventListener.cpp b/llvm/lib/ExecutionEngine/PerfJITEvents/PerfJITEventListener.cpp --- a/llvm/lib/ExecutionEngine/PerfJITEvents/PerfJITEventListener.cpp +++ b/llvm/lib/ExecutionEngine/PerfJITEvents/PerfJITEventListener.cpp @@ -24,7 +24,6 @@ #include "llvm/Support/Debug.h" #include "llvm/Support/Errno.h" #include "llvm/Support/FileSystem.h" -#include "llvm/Support/ManagedStatic.h" #include "llvm/Support/MemoryBuffer.h" #include "llvm/Support/Mutex.h" #include "llvm/Support/Path.h" @@ -488,15 +487,14 @@ } } -// There should be only a single event listener per process, otherwise perf gets -// confused. -llvm::ManagedStatic PerfListener; - } // end anonymous namespace namespace llvm { JITEventListener *JITEventListener::createPerfJITEventListener() { - return &*PerfListener; + // There should be only a single event listener per process, otherwise perf + // gets confused. + static PerfJITEventListener PerfListener; + return &PerfListener; } } // namespace llvm diff --git a/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp b/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp --- a/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp +++ b/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp @@ -19,7 +19,6 @@ #include "llvm/Object/ELFObjectFile.h" #include "llvm/Support/Alignment.h" #include "llvm/Support/MSVCErrorWorkarounds.h" -#include "llvm/Support/ManagedStatic.h" #include "llvm/Support/MathExtras.h" #include @@ -51,8 +50,6 @@ } }; -static ManagedStatic RTDyldErrorCategory; - } char RuntimeDyldError::ID = 0; @@ -62,7 +59,8 @@ } std::error_code RuntimeDyldError::convertToErrorCode() const { - return std::error_code(GenericRTDyldError, *RTDyldErrorCategory); + static RuntimeDyldErrorCategory RTDyldErrorCategory; + return std::error_code(GenericRTDyldError, RTDyldErrorCategory); } // Empty out-of-line virtual destructor as the key function. diff --git a/llvm/lib/IR/Core.cpp b/llvm/lib/IR/Core.cpp --- a/llvm/lib/IR/Core.cpp +++ b/llvm/lib/IR/Core.cpp @@ -74,13 +74,16 @@ /*===-- Operations on contexts --------------------------------------------===*/ -static ManagedStatic GlobalContext; +static LLVMContext &getGlobalContext() { + static LLVMContext GlobalContext; + return GlobalContext; +} LLVMContextRef LLVMContextCreate() { return wrap(new LLVMContext()); } -LLVMContextRef LLVMGetGlobalContext() { return wrap(&*GlobalContext); } +LLVMContextRef LLVMGetGlobalContext() { return wrap(&getGlobalContext()); } void LLVMContextSetDiagnosticHandler(LLVMContextRef C, LLVMDiagnosticHandler Handler, @@ -251,7 +254,7 @@ /*===-- Operations on modules ---------------------------------------------===*/ LLVMModuleRef LLVMModuleCreateWithName(const char *ModuleID) { - return wrap(new Module(ModuleID, *GlobalContext)); + return wrap(new Module(ModuleID, getGlobalContext())); } LLVMModuleRef LLVMModuleCreateWithNameInContext(const char *ModuleID, diff --git a/llvm/lib/IR/LLVMContextImpl.cpp b/llvm/lib/IR/LLVMContextImpl.cpp --- a/llvm/lib/IR/LLVMContextImpl.cpp +++ b/llvm/lib/IR/LLVMContextImpl.cpp @@ -27,7 +27,6 @@ #include "llvm/Support/CommandLine.h" #include "llvm/Support/Compiler.h" #include "llvm/Support/ErrorHandling.h" -#include "llvm/Support/ManagedStatic.h" #include "llvm/Support/TypeSize.h" #include #include @@ -241,7 +240,7 @@ /// singleton OptBisect if not explicitly set. OptPassGate &LLVMContextImpl::getOptPassGate() const { if (!OPG) - OPG = &(*OptBisector); + OPG = &getOptBisector(); return *OPG; } diff --git a/llvm/lib/IR/OptBisect.cpp b/llvm/lib/IR/OptBisect.cpp --- a/llvm/lib/IR/OptBisect.cpp +++ b/llvm/lib/IR/OptBisect.cpp @@ -23,7 +23,7 @@ static cl::opt OptBisectLimit("opt-bisect-limit", cl::Hidden, cl::init(OptBisect::Disabled), cl::Optional, cl::cb([](int Limit) { - llvm::OptBisector->setLimit(Limit); + llvm::getOptBisector().setLimit(Limit); }), cl::desc("Maximum optimization to perform")); @@ -52,4 +52,7 @@ const int OptBisect::Disabled; -ManagedStatic llvm::OptBisector; +OptBisect &llvm::getOptBisector() { + static OptBisect OptBisector; + return OptBisector; +} diff --git a/llvm/lib/IR/PassRegistry.cpp b/llvm/lib/IR/PassRegistry.cpp --- a/llvm/lib/IR/PassRegistry.cpp +++ b/llvm/lib/IR/PassRegistry.cpp @@ -15,21 +15,15 @@ #include "llvm/ADT/STLExtras.h" #include "llvm/Pass.h" #include "llvm/PassInfo.h" -#include "llvm/Support/ManagedStatic.h" #include #include #include using namespace llvm; -// FIXME: We use ManagedStatic to erase the pass registrar on shutdown. -// Unfortunately, passes are registered with static ctors, and having -// llvm_shutdown clear this map prevents successful resurrection after -// llvm_shutdown is run. Ideally we should find a solution so that we don't -// leak the map, AND can still resurrect after shutdown. -static ManagedStatic PassRegistryObj; PassRegistry *PassRegistry::getPassRegistry() { - return &*PassRegistryObj; + static PassRegistry PassRegistryObj; + return &PassRegistryObj; } //===----------------------------------------------------------------------===// diff --git a/llvm/lib/Object/Error.cpp b/llvm/lib/Object/Error.cpp --- a/llvm/lib/Object/Error.cpp +++ b/llvm/lib/Object/Error.cpp @@ -13,7 +13,6 @@ #include "llvm/Object/Error.h" #include "llvm/ADT/Twine.h" #include "llvm/Support/ErrorHandling.h" -#include "llvm/Support/ManagedStatic.h" using namespace llvm; using namespace object; @@ -75,10 +74,9 @@ OS << Msg; } -static ManagedStatic<_object_error_category> error_category; - const std::error_category &object::object_category() { - return *error_category; + static _object_error_category error_category; + return error_category; } llvm::Error llvm::object::isNotObjectErrorInvalidFileType(llvm::Error Err) { diff --git a/llvm/lib/Passes/StandardInstrumentations.cpp b/llvm/lib/Passes/StandardInstrumentations.cpp --- a/llvm/lib/Passes/StandardInstrumentations.cpp +++ b/llvm/lib/Passes/StandardInstrumentations.cpp @@ -901,10 +901,11 @@ void OptBisectInstrumentation::registerCallbacks( PassInstrumentationCallbacks &PIC) { - if (!OptBisector->isEnabled()) + if (!getOptBisector().isEnabled()) return; PIC.registerShouldRunOptionalPassCallback([](StringRef PassID, Any IR) { - return isIgnored(PassID) || OptBisector->checkPass(PassID, getIRName(IR)); + return isIgnored(PassID) || + getOptBisector().checkPass(PassID, getIRName(IR)); }); } diff --git a/llvm/lib/ProfileData/Coverage/CoverageMapping.cpp b/llvm/lib/ProfileData/Coverage/CoverageMapping.cpp --- a/llvm/lib/ProfileData/Coverage/CoverageMapping.cpp +++ b/llvm/lib/ProfileData/Coverage/CoverageMapping.cpp @@ -25,7 +25,6 @@ #include "llvm/Support/Errc.h" #include "llvm/Support/Error.h" #include "llvm/Support/ErrorHandling.h" -#include "llvm/Support/ManagedStatic.h" #include "llvm/Support/MemoryBuffer.h" #include "llvm/Support/raw_ostream.h" #include @@ -897,10 +896,9 @@ return getCoverageMapErrString(Err); } -static ManagedStatic ErrorCategory; - const std::error_category &llvm::coverage::coveragemap_category() { - return *ErrorCategory; + static CoverageMappingErrorCategoryType ErrorCategory; + return ErrorCategory; } char CoverageMapError::ID = 0; diff --git a/llvm/lib/ProfileData/InstrProf.cpp b/llvm/lib/ProfileData/InstrProf.cpp --- a/llvm/lib/ProfileData/InstrProf.cpp +++ b/llvm/lib/ProfileData/InstrProf.cpp @@ -39,7 +39,6 @@ #include "llvm/Support/Error.h" #include "llvm/Support/ErrorHandling.h" #include "llvm/Support/LEB128.h" -#include "llvm/Support/ManagedStatic.h" #include "llvm/Support/MathExtras.h" #include "llvm/Support/Path.h" #include "llvm/Support/SwapByteOrder.h" @@ -177,10 +176,9 @@ } // end anonymous namespace -static ManagedStatic ErrorCategory; - const std::error_category &llvm::instrprof_category() { - return *ErrorCategory; + static InstrProfErrorCategoryType ErrorCategory; + return ErrorCategory; } namespace { diff --git a/llvm/lib/ProfileData/SampleProf.cpp b/llvm/lib/ProfileData/SampleProf.cpp --- a/llvm/lib/ProfileData/SampleProf.cpp +++ b/llvm/lib/ProfileData/SampleProf.cpp @@ -20,7 +20,6 @@ #include "llvm/Support/Compiler.h" #include "llvm/Support/Debug.h" #include "llvm/Support/ErrorHandling.h" -#include "llvm/Support/ManagedStatic.h" #include "llvm/Support/raw_ostream.h" #include #include @@ -98,10 +97,9 @@ } // end anonymous namespace -static ManagedStatic ErrorCategory; - const std::error_category &llvm::sampleprof_category() { - return *ErrorCategory; + static SampleProfErrorCategoryType ErrorCategory; + return ErrorCategory; } void LineLocation::print(raw_ostream &OS) const { diff --git a/llvm/lib/Support/Error.cpp b/llvm/lib/Support/Error.cpp --- a/llvm/lib/Support/Error.cpp +++ b/llvm/lib/Support/Error.cpp @@ -9,7 +9,6 @@ #include "llvm/Support/Error.h" #include "llvm/ADT/Twine.h" #include "llvm/Support/ErrorHandling.h" -#include "llvm/Support/ManagedStatic.h" #include using namespace llvm; @@ -46,7 +45,10 @@ } -static ManagedStatic ErrorErrorCat; +ErrorErrorCategory &getErrorErrorCat() { + static ErrorErrorCategory ErrorErrorCat; + return ErrorErrorCat; +} namespace llvm { @@ -71,19 +73,19 @@ std::error_code ErrorList::convertToErrorCode() const { return std::error_code(static_cast(ErrorErrorCode::MultipleErrors), - *ErrorErrorCat); + getErrorErrorCat()); } std::error_code inconvertibleErrorCode() { return std::error_code(static_cast(ErrorErrorCode::InconvertibleError), - *ErrorErrorCat); + getErrorErrorCat()); } std::error_code FileError::convertToErrorCode() const { std::error_code NestedEC = Err->convertToErrorCode(); if (NestedEC == inconvertibleErrorCode()) return std::error_code(static_cast(ErrorErrorCode::FileError), - *ErrorErrorCat); + getErrorErrorCat()); return NestedEC; } diff --git a/llvm/lib/Support/Unix/Process.inc b/llvm/lib/Support/Unix/Process.inc --- a/llvm/lib/Support/Unix/Process.inc +++ b/llvm/lib/Support/Unix/Process.inc @@ -14,7 +14,6 @@ #include "llvm/ADT/Hashing.h" #include "llvm/ADT/StringRef.h" #include "llvm/Config/config.h" -#include "llvm/Support/ManagedStatic.h" #include #if HAVE_FCNTL_H #include @@ -327,10 +326,6 @@ extern "C" int tigetnum(char *capname); #endif -#ifdef LLVM_ENABLE_TERMINFO -static ManagedStatic TermColorMutex; -#endif - bool checkTerminalEnvironmentForColors() { if (const char *TermStr = std::getenv("TERM")) { return StringSwitch(TermStr) @@ -351,7 +346,8 @@ static bool terminalHasColors(int fd) { #ifdef LLVM_ENABLE_TERMINFO // First, acquire a global lock because these C routines are thread hostile. - std::lock_guard G(*TermColorMutex); + static std::mutex TermColorMutex; + std::lock_guard G(TermColorMutex); struct term *previous_term = set_curterm(nullptr); int errret = 0; diff --git a/llvm/lib/Target/NVPTX/NVPTXUtilities.cpp b/llvm/lib/Target/NVPTX/NVPTXUtilities.cpp --- a/llvm/lib/Target/NVPTX/NVPTXUtilities.cpp +++ b/llvm/lib/Target/NVPTX/NVPTXUtilities.cpp @@ -18,7 +18,6 @@ #include "llvm/IR/InstIterator.h" #include "llvm/IR/Module.h" #include "llvm/IR/Operator.h" -#include "llvm/Support/ManagedStatic.h" #include "llvm/Support/Mutex.h" #include #include @@ -32,19 +31,27 @@ namespace { typedef std::map > key_val_pair_t; typedef std::map global_val_annot_t; -typedef std::map per_module_annot_t; -} // anonymous namespace -static ManagedStatic annotationCache; -static sys::Mutex Lock; +struct AnnotationCache { + sys::Mutex Lock; + std::map Cache; +}; + +AnnotationCache &getAnnotationCache() { + static AnnotationCache AC; + return AC; +} +} // anonymous namespace void clearAnnotationCache(const Module *Mod) { - std::lock_guard Guard(Lock); - annotationCache->erase(Mod); + auto &AC = getAnnotationCache(); + std::lock_guard Guard(AC.Lock); + AC.Cache.erase(Mod); } static void cacheAnnotationFromMD(const MDNode *md, key_val_pair_t &retval) { - std::lock_guard Guard(Lock); + auto &AC = getAnnotationCache(); + std::lock_guard Guard(AC.Lock); assert(md && "Invalid mdnode for annotation"); assert((md->getNumOperands() % 2) == 1 && "Invalid number of operands"); // start index = 1, to skip the global variable key @@ -70,7 +77,8 @@ } static void cacheAnnotationFromMD(const Module *m, const GlobalValue *gv) { - std::lock_guard Guard(Lock); + auto &AC = getAnnotationCache(); + std::lock_guard Guard(AC.Lock); NamedMDNode *NMD = m->getNamedMetadata("nvvm.annotations"); if (!NMD) return; @@ -93,40 +101,42 @@ if (tmp.empty()) // no annotations for this gv return; - if ((*annotationCache).find(m) != (*annotationCache).end()) - (*annotationCache)[m][gv] = std::move(tmp); + if (AC.Cache.find(m) != AC.Cache.end()) + AC.Cache[m][gv] = std::move(tmp); else { global_val_annot_t tmp1; tmp1[gv] = std::move(tmp); - (*annotationCache)[m] = std::move(tmp1); + AC.Cache[m] = std::move(tmp1); } } bool findOneNVVMAnnotation(const GlobalValue *gv, const std::string &prop, unsigned &retval) { - std::lock_guard Guard(Lock); + auto &AC = getAnnotationCache(); + std::lock_guard Guard(AC.Lock); const Module *m = gv->getParent(); - if ((*annotationCache).find(m) == (*annotationCache).end()) + if (AC.Cache.find(m) == AC.Cache.end()) cacheAnnotationFromMD(m, gv); - else if ((*annotationCache)[m].find(gv) == (*annotationCache)[m].end()) + else if (AC.Cache[m].find(gv) == AC.Cache[m].end()) cacheAnnotationFromMD(m, gv); - if ((*annotationCache)[m][gv].find(prop) == (*annotationCache)[m][gv].end()) + if (AC.Cache[m][gv].find(prop) == AC.Cache[m][gv].end()) return false; - retval = (*annotationCache)[m][gv][prop][0]; + retval = AC.Cache[m][gv][prop][0]; return true; } bool findAllNVVMAnnotation(const GlobalValue *gv, const std::string &prop, std::vector &retval) { - std::lock_guard Guard(Lock); + auto &AC = getAnnotationCache(); + std::lock_guard Guard(AC.Lock); const Module *m = gv->getParent(); - if ((*annotationCache).find(m) == (*annotationCache).end()) + if (AC.Cache.find(m) == AC.Cache.end()) cacheAnnotationFromMD(m, gv); - else if ((*annotationCache)[m].find(gv) == (*annotationCache)[m].end()) + else if (AC.Cache[m].find(gv) == AC.Cache[m].end()) cacheAnnotationFromMD(m, gv); - if ((*annotationCache)[m][gv].find(prop) == (*annotationCache)[m][gv].end()) + if (AC.Cache[m][gv].find(prop) == AC.Cache[m][gv].end()) return false; - retval = (*annotationCache)[m][gv][prop]; + retval = AC.Cache[m][gv][prop]; return true; } diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.cpp b/llvm/lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.cpp --- a/llvm/lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.cpp +++ b/llvm/lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.cpp @@ -21,7 +21,6 @@ #include "WebAssemblyRuntimeLibcallSignatures.h" #include "WebAssemblySubtarget.h" #include "llvm/CodeGen/RuntimeLibcalls.h" -#include "llvm/Support/ManagedStatic.h" using namespace llvm; @@ -482,10 +481,13 @@ } }; -ManagedStatic RuntimeLibcallSignatures; +RuntimeLibcallSignatureTable &getRuntimeLibcallSignatures() { + static RuntimeLibcallSignatureTable RuntimeLibcallSignatures; + return RuntimeLibcallSignatures; +} // Maps libcall names to their RTLIB::Libcall number. Builds the map in a -// constructor for use with ManagedStatic +// constructor for use with a static variable struct StaticLibcallNameMap { StringMap Map; StaticLibcallNameMap() { @@ -496,7 +498,8 @@ }; for (const auto &NameLibcall : NameLibcalls) { if (NameLibcall.first != nullptr && - RuntimeLibcallSignatures->Table[NameLibcall.second] != unsupported) { + getRuntimeLibcallSignatures().Table[NameLibcall.second] != + unsupported) { assert(Map.find(NameLibcall.first) == Map.end() && "duplicate libcall names in name map"); Map[NameLibcall.first] = NameLibcall.second; @@ -523,7 +526,7 @@ wasm::ValType PtrTy = Subtarget.hasAddr64() ? wasm::ValType::I64 : wasm::ValType::I32; - auto &Table = RuntimeLibcallSignatures->Table; + auto &Table = getRuntimeLibcallSignatures().Table; switch (Table[LC]) { case func: break; @@ -885,14 +888,14 @@ } } -static ManagedStatic LibcallNameMap; // TODO: If the RTLIB::Libcall-taking flavor of GetSignature remains unsed // other than here, just roll its logic into this version. void llvm::getLibcallSignature(const WebAssemblySubtarget &Subtarget, StringRef Name, SmallVectorImpl &Rets, SmallVectorImpl &Params) { - auto &Map = LibcallNameMap->Map; + static StaticLibcallNameMap LibcallNameMap; + auto &Map = LibcallNameMap.Map; auto Val = Map.find(Name); #ifndef NDEBUG if (Val == Map.end()) { diff --git a/llvm/lib/Target/X86/MCTargetDesc/X86InstrRelaxTables.cpp b/llvm/lib/Target/X86/MCTargetDesc/X86InstrRelaxTables.cpp --- a/llvm/lib/Target/X86/MCTargetDesc/X86InstrRelaxTables.cpp +++ b/llvm/lib/Target/X86/MCTargetDesc/X86InstrRelaxTables.cpp @@ -13,6 +13,7 @@ #include "X86InstrRelaxTables.h" #include "X86InstrInfo.h" #include "llvm/ADT/STLExtras.h" +#include using namespace llvm; @@ -119,7 +120,7 @@ namespace { // This class stores the short form tables. It is instantiated as a -// ManagedStatic to lazily init the short form table. +// function scope static variable to lazily init the short form table. struct X86ShortFormTable { // Stores relaxation table entries sorted by relaxed form opcode. SmallVector Table; @@ -137,10 +138,9 @@ }; } // namespace -static ManagedStatic ShortTable; - const X86InstrRelaxTableEntry *llvm::lookupShortTable(unsigned RelaxOp) { - auto &Table = ShortTable->Table; + static X86ShortFormTable ShortTable; + auto &Table = ShortTable.Table; auto I = llvm::lower_bound(Table, RelaxOp); if (I != Table.end() && I->KeyOp == RelaxOp) return &*I; diff --git a/llvm/lib/Target/X86/X86EvexToVex.cpp b/llvm/lib/Target/X86/X86EvexToVex.cpp --- a/llvm/lib/Target/X86/X86EvexToVex.cpp +++ b/llvm/lib/Target/X86/X86EvexToVex.cpp @@ -31,6 +31,7 @@ #include "llvm/CodeGen/MachineOperand.h" #include "llvm/MC/MCInstrDesc.h" #include "llvm/Pass.h" +#include #include #include diff --git a/llvm/lib/Target/X86/X86InstrFoldTables.cpp b/llvm/lib/Target/X86/X86InstrFoldTables.cpp --- a/llvm/lib/Target/X86/X86InstrFoldTables.cpp +++ b/llvm/lib/Target/X86/X86InstrFoldTables.cpp @@ -13,6 +13,7 @@ #include "X86InstrFoldTables.h" #include "X86InstrInfo.h" #include "llvm/ADT/STLExtras.h" +#include #include using namespace llvm; @@ -6102,7 +6103,7 @@ namespace { // This class stores the memory unfolding tables. It is instantiated as a -// ManagedStatic to lazily init the unfolding table. +// function scope static variable to lazily init the unfolding table. struct X86MemUnfoldTable { // Stores memory unfolding tables entries sorted by opcode. std::vector Table; @@ -6159,11 +6160,10 @@ }; } -static ManagedStatic MemUnfoldTable; - const X86MemoryFoldTableEntry * llvm::lookupUnfoldTable(unsigned MemOp) { - auto &Table = MemUnfoldTable->Table; + static X86MemUnfoldTable MemUnfoldTable; + auto &Table = MemUnfoldTable.Table; auto I = llvm::lower_bound(Table, MemOp); if (I != Table.end() && I->KeyOp == MemOp) return &*I; diff --git a/llvm/tools/llc/llc.cpp b/llvm/tools/llc/llc.cpp --- a/llvm/tools/llc/llc.cpp +++ b/llvm/tools/llc/llc.cpp @@ -47,7 +47,6 @@ #include "llvm/Support/FormattedStream.h" #include "llvm/Support/Host.h" #include "llvm/Support/InitLLVM.h" -#include "llvm/Support/ManagedStatic.h" #include "llvm/Support/PluginLoader.h" #include "llvm/Support/SourceMgr.h" #include "llvm/Support/TargetSelect.h" @@ -192,7 +191,11 @@ cl::value_desc("format"), cl::init("yaml")); namespace { -static ManagedStatic> RunPassNames; + +std::vector &getRunPassNames() { + static std::vector RunPassNames; + return RunPassNames; +} struct RunPassOption { void operator=(const std::string &Val) const { @@ -201,7 +204,7 @@ SmallVector PassNames; StringRef(Val).split(PassNames, ',', -1, false); for (auto PassName : PassNames) - RunPassNames->push_back(std::string(PassName)); + getRunPassNames().push_back(std::string(PassName)); } }; } @@ -676,7 +679,7 @@ // Construct a custom pass pipeline that starts after instruction // selection. - if (!RunPassNames->empty()) { + if (!getRunPassNames().empty()) { if (!MIR) { WithColor::warning(errs(), argv[0]) << "run-pass is for .mir file only.\n"; @@ -694,7 +697,7 @@ PM.add(&TPC); PM.add(MMIWP); TPC.printAndVerify(""); - for (const std::string &RunPassName : *RunPassNames) { + for (const std::string &RunPassName : getRunPassNames()) { if (addPass(PM, argv0, RunPassName, TPC)) return 1; } diff --git a/llvm/tools/llvm-xray/xray-registry.cpp b/llvm/tools/llvm-xray/xray-registry.cpp --- a/llvm/tools/llvm-xray/xray-registry.cpp +++ b/llvm/tools/llvm-xray/xray-registry.cpp @@ -11,7 +11,6 @@ //===----------------------------------------------------------------------===// #include "xray-registry.h" -#include "llvm/Support/ManagedStatic.h" #include namespace llvm { @@ -19,19 +18,22 @@ using HandlerType = std::function; -ManagedStatic> Commands; +static std::unordered_map &getCommands() { + static std::unordered_map Commands; + return Commands; +} CommandRegistration::CommandRegistration(cl::SubCommand *SC, HandlerType Command) { - assert(Commands->count(SC) == 0 && + assert(getCommands().count(SC) == 0 && "Attempting to overwrite a command handler"); assert(Command && "Attempting to register an empty std::function"); - (*Commands)[SC] = Command; + getCommands()[SC] = Command; } HandlerType dispatch(cl::SubCommand *SC) { - auto It = Commands->find(SC); - assert(It != Commands->end() && + auto It = getCommands().find(SC); + assert(It != getCommands().end() && "Attempting to dispatch on un-registered SubCommand."); return It->second; } diff --git a/llvm/unittests/Support/ErrorTest.cpp b/llvm/unittests/Support/ErrorTest.cpp --- a/llvm/unittests/Support/ErrorTest.cpp +++ b/llvm/unittests/Support/ErrorTest.cpp @@ -12,7 +12,6 @@ #include "llvm/ADT/Twine.h" #include "llvm/Support/Errc.h" #include "llvm/Support/ErrorHandling.h" -#include "llvm/Support/ManagedStatic.h" #include "llvm/Testing/Support/Error.h" #include "gtest/gtest-spi.h" #include "gtest/gtest.h" @@ -1039,8 +1038,10 @@ } }; -static llvm::ManagedStatic TestErrCategory; -const std::error_category &TErrorCategory() { return *TestErrCategory; } +const std::error_category &TErrorCategory() { + static TestErrorCategory TestErrCategory; + return TestErrCategory; +} char TestDebugError::ID;