diff --git a/clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp b/clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp --- a/clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp +++ b/clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp @@ -97,8 +97,8 @@ void VisitForStmt(const ForStmt *S) { auto *Cond = S->getCond(); - assert(Cond != nullptr); - extendFlowCondition(*Cond); + if (Cond != nullptr) + extendFlowCondition(*Cond); } void VisitBinaryOperator(const BinaryOperator *S) { diff --git a/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp b/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp --- a/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp +++ b/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp @@ -3827,4 +3827,30 @@ }); } +TEST_F(TransferTest, ForStmtBranchWithoutConditionDoesNotExtendFlowCondition) { + std::string Code = R"( + void target(bool Foo) { + for (;;) { + (void)0; + // [[loop_body]] + } + } + )"; + runDataflow( + Code, [](llvm::ArrayRef< + std::pair>> + Results, + ASTContext &ASTCtx) { + ASSERT_THAT(Results, ElementsAre(Pair("loop_body", _))); + const Environment &LoopBodyEnv = Results[0].second.Env; + + const ValueDecl *FooDecl = findValueDecl(ASTCtx, "Foo"); + ASSERT_THAT(FooDecl, NotNull()); + + BoolValue &LoopBodyFooVal = + *cast(LoopBodyEnv.getValue(*FooDecl, SkipPast::None)); + EXPECT_FALSE(LoopBodyEnv.flowConditionImplies(LoopBodyFooVal)); + }); +} + } // namespace