[mlir] Make verifyMemoryOpIndexing external

[kmistryic]

I have some dialects which uses this, making it external solves linking problem.

[kmistryic]

clang formatted

[kmistryic]

ping?

[nicolasvasilache]

sure

[kmistryic]

can someone merge this?

mlir/include/mlir/Dialect/Affine/IR/AffineOps.h

void fullyComposeAffineMapAndOperands(AffineMap *map,
                                       SmallVectorImpl<Value> *operands);
 } // namespace mlir
 #include "mlir/Dialect/Affine/IR/AffineOpsDialect.h.inc"
 
 #define GET_OP_CLASSES
 #include "mlir/Dialect/Affine/IR/AffineOps.h.inc"
 
 namespace mlir {
+/// Verify common indexing invariants of affine.load, affine.store,
+/// affine.vector_load and affine.vector_store.
+LogicalResult verifyMemoryOpIndexing(Operation *op, AffineMapAttr mapAttr,
+                                     Operation::operand_range mapOperands,
+                                     MemRefType memrefType,
+                                     unsigned numIndexOperands);
 /// Returns true if the provided value is the induction variable of a
 /// AffineForOp.
 bool isForInductionVar(Value val);
 
 /// Returns the loop parent of an induction variable. If the provided value is
 /// not an induction variable, then return nullptr.
 AffineForOp getForInductionVarOwner(Value val);
 

mlir/lib/Dialect/Affine/IR/AffineOps.cpp

void AffineLoadOp::print(OpAsmPrinter &p) {
   p << ']';
   p.printOptionalAttrDict((*this)->getAttrs(),
                           /*elidedAttrs=*/{getMapAttrStrName()});
   p << " : " << getMemRefType();
 }
 
 /// Verify common indexing invariants of affine.load, affine.store,
 /// affine.vector_load and affine.vector_store.
-static LogicalResult
-verifyMemoryOpIndexing(Operation *op, AffineMapAttr mapAttr,
+LogicalResult mlir::verifyMemoryOpIndexing(Operation *op, AffineMapAttr mapAttr,
                                            Operation::operand_range mapOperands,
-                       MemRefType memrefType, unsigned numIndexOperands) {
+                                           MemRefType memrefType,
+                                           unsigned numIndexOperands) {
   if (mapAttr) {
     AffineMap map = mapAttr.getValue();
     if (map.getNumResults() != memrefType.getRank())
       return op->emitOpError("affine map num results must equal memref rank");
     if (map.getNumInputs() != numIndexOperands)
       return op->emitOpError("expects as many subscripts as affine map inputs");
   } else {
     if (memrefType.getRank() != numIndexOperands)