diff --git a/clang/include/clang/Analysis/FlowSensitive/MatchSwitch.h b/clang/include/clang/Analysis/FlowSensitive/MatchSwitch.h --- a/clang/include/clang/Analysis/FlowSensitive/MatchSwitch.h +++ b/clang/include/clang/Analysis/FlowSensitive/MatchSwitch.h @@ -46,8 +46,8 @@ /// Matches against `Stmt` and, based on its structure, dispatches to an /// appropriate handler. -template -using MatchSwitch = std::function; +template +using MatchSwitch = std::function; /// Collects cases of a "match switch": a collection of matchers paired with /// callbacks, which together define a switch that can be applied to a @@ -68,7 +68,7 @@ /// .Build(); /// } /// \endcode -template class MatchSwitchBuilder { +template class MatchSwitchBuilder { public: /// Registers an action that will be triggered by the match of a pattern /// against the input statement. @@ -79,24 +79,24 @@ template MatchSwitchBuilder && CaseOf(ast_matchers::internal::Matcher M, - std::function + std::function A) && { Matchers.push_back(std::move(M)); Actions.push_back( [A = std::move(A)](const Stmt *Stmt, const ast_matchers::MatchFinder::MatchResult &R, - State &S) { A(cast(Stmt), R, S); }); + State &S) { return A(cast(Stmt), R, S); }); return std::move(*this); } - MatchSwitch Build() && { + MatchSwitch Build() && { return [Matcher = BuildMatcher(), Actions = std::move(Actions)]( - const Stmt &Stmt, ASTContext &Context, State &S) { + const Stmt &Stmt, ASTContext &Context, State &S) -> Result { auto Results = ast_matchers::matchDynamic(Matcher, Stmt, Context); if (Results.empty()) - return; + return {}; // Look through the map for the first binding of the form "TagN..." use // that to select the action. for (const auto &Element : Results[0].getMap()) { @@ -104,12 +104,12 @@ size_t Index = 0; if (ID.consume_front("Tag") && !ID.getAsInteger(10, Index) && Index < Actions.size()) { - Actions[Index]( + return Actions[Index]( &Stmt, ast_matchers::MatchFinder::MatchResult(Results[0], &Context), S); - return; } } + return {}; }; } @@ -142,7 +142,7 @@ } std::vector Matchers; - std::vector> Actions; }; diff --git a/clang/unittests/Analysis/FlowSensitive/MatchSwitchTest.cpp b/clang/unittests/Analysis/FlowSensitive/MatchSwitchTest.cpp --- a/clang/unittests/Analysis/FlowSensitive/MatchSwitchTest.cpp +++ b/clang/unittests/Analysis/FlowSensitive/MatchSwitchTest.cpp @@ -204,3 +204,29 @@ RunDataflow(Code, UnorderedElementsAre(Pair("p", Holds(BooleanLattice(false))))); } + +TEST_F(MatchSwitchTest, ReturnNonVoid) { + using namespace ast_matchers; + + auto Unit = + tooling::buildASTFromCode("void f() { int x = 42; }", "input.cc", + std::make_shared()); + auto &Context = Unit->getASTContext(); + const auto *S = + selectFirst( + "f", + match(functionDecl(isDefinition(), hasName("f")).bind("f"), Context)) + ->getBody(); + + MatchSwitch> Switch = + MatchSwitchBuilder>() + .CaseOf(stmt(), + [](const Stmt *, const MatchFinder::MatchResult &, + const int &State) -> std::vector { + return {1, State, 3}; + }) + .Build(); + std::vector Actual = Switch(*S, Context, 7); + std::vector Expected{1, 7, 3}; + EXPECT_EQ(Actual, Expected); +}