diff --git a/lldb/source/Plugins/Process/Windows/Common/ExceptionRecord.h b/lldb/source/Plugins/Process/Windows/Common/ExceptionRecord.h --- a/lldb/source/Plugins/Process/Windows/Common/ExceptionRecord.h +++ b/lldb/source/Plugins/Process/Windows/Common/ExceptionRecord.h @@ -27,9 +27,19 @@ ExceptionRecord(const EXCEPTION_RECORD &record, lldb::tid_t thread_id) { m_code = record.ExceptionCode; m_continuable = (record.ExceptionFlags == 0); + // This marks some old code which tried to parse the nested exception. In + // practice, this code just causes Access Violation. I suspect + // `ExceptionRecord` here actually points to the address space of the + // debuggee process. However, I did not manage to find any official or + // unofficial reference that clarifies this point. If anyone would like to + // reimplement this, please also keep in mind to check how this behaves when + // debugging a WOW64 process. I suspect you may have to use the explicit + // `EXCEPTION_RECORD32` and `EXCEPTION_RECORD64` structs. +#if 0 if (record.ExceptionRecord) m_next_exception.reset( new ExceptionRecord(*record.ExceptionRecord, thread_id)); +#endif m_exception_addr = reinterpret_cast(record.ExceptionAddress); m_thread_id = thread_id; m_arguments.assign(record.ExceptionInformation, @@ -39,17 +49,18 @@ // MINIDUMP_EXCEPTIONs are almost identical to EXCEPTION_RECORDs. ExceptionRecord(const MINIDUMP_EXCEPTION &record, lldb::tid_t thread_id) : m_code(record.ExceptionCode), m_continuable(record.ExceptionFlags == 0), - m_next_exception(nullptr), m_exception_addr(static_cast(record.ExceptionAddress)), m_thread_id(thread_id), m_arguments(record.ExceptionInformation, record.ExceptionInformation + record.NumberParameters) { +#if 0 // Set up link to nested exception. if (record.ExceptionRecord) { m_next_exception.reset(new ExceptionRecord( *reinterpret_cast(record.ExceptionRecord), thread_id)); } +#endif } virtual ~ExceptionRecord() {} @@ -57,9 +68,11 @@ DWORD GetExceptionCode() const { return m_code; } bool IsContinuable() const { return m_continuable; } +#if 0 const ExceptionRecord *GetNextException() const { return m_next_exception.get(); } +#endif lldb::addr_t GetExceptionAddress() const { return m_exception_addr; } lldb::tid_t GetThreadID() const { return m_thread_id; } @@ -69,7 +82,9 @@ private: DWORD m_code; bool m_continuable; +#if 0 std::shared_ptr m_next_exception; +#endif lldb::addr_t m_exception_addr; lldb::tid_t m_thread_id; std::vector m_arguments;