This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Remove macros for IBM compiler
ClosedPublic

Authored by ldionne on Jun 13 2022, 8:22 AM.

Details

Reviewers
Mordante
daltenty
SeanP
Group Reviewers
Restricted Project
Commits
rGee78181f34ca: [libc++] Remove macros for IBM compiler
Summary

It's not tested or used anymore -- instead a Clang-based compiler is
used on IBM nowadays.

Diff Detail

Event Timeline

ldionne created this revision.Jun 13 2022, 8:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 8:22 AM
ldionne requested review of this revision.Jun 13 2022, 8:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 8:22 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante accepted this revision as: Mordante.Jun 13 2022, 9:29 AM
Mordante added a subscriber: Mordante.

Nice cleanup LGTM! I think it would be good to add some of the IBM people as reviewer too.

libcxx/include/__config
520

Can _LIBCPP_HAS_NO_UNICODE_CHARS be set in CMake by users? If not this seems to be the only place where _LIBCPP_HAS_NO_UNICODE_CHARS is defined.

In that case do you want to make a followup patch to remove this, or do you want me to do it?

ldionne marked an inline comment as done.Jun 13 2022, 3:04 PM

Nice cleanup LGTM! I think it would be good to add some of the IBM people as reviewer too.

We discussed this with @SeanP, but adding others as well.

libcxx/include/__config
520

Oh, wow, that's freakin' great. I've been meaning to clean this up for a very long time, but I didn't know how to. I'll actually fold the removal into this patch since it's directly tied to _LIBCPP_COMPILER_IBM.

We discussed this with @SeanP, but adding others as well.

I am on board for this.

ldionne updated this revision to Diff 436585.Jun 13 2022, 3:18 PM
ldionne marked an inline comment as done.

Remove _LIBCPP_HAS_NO_UNICODE_CHARS

daltenty accepted this revision.Jun 13 2022, 4:50 PM

LGTM, as noted the the configuration for the IBM XL compiler is unused, modern Open XL goes down the clang paths.

SeanP accepted this revision.Jun 13 2022, 4:52 PM

These look good to me. I do see the the AIX CI build is broken. This is due to -X32_64 being passed to llvm-ar. That appears independent of this change. @daltenty will need to take a look at that.

ldionne accepted this revision as: Restricted Project.Jun 14 2022, 6:13 AM

Thanks for double-checking folks!

This revision is now accepted and ready to land.Jun 14 2022, 6:13 AM
This revision was landed with ongoing or failed builds.Jun 14 2022, 6:15 AM
This revision was automatically updated to reflect the committed changes.

Remove _LIBCPP_HAS_NO_UNICODE_CHARS

Great, thanks a lot!