[sanitizer] Fix the posix_spawn test on FreeBSD

[andrew]

Summary

FreeBSD needs posix_spawnattr_init and posix_spawn_file_actions_init to
be used before calling posix_spawn. Keep the trivial version for Darwin.

[vitalybuka]

compiler-rt/test/sanitizer_common/TestCases/Posix/posix_spawn.c

11

can you include public header instead of internal one?
#include <spawn.h>

[andrew]

compiler-rt/test/sanitizer_common/TestCases/Posix/posix_spawn.c

11

spawn.h is already included above. This include is to pick up the SANITIZER_APPLE definition.

[arichardson]

compiler-rt/test/sanitizer_common/TestCases/Posix/posix_spawn.c

11

I'm not sure if other tests do the same, if not I'd just use defined(__APPLE__)?

[vitalybuka]

compiler-rt/test/sanitizer_common/TestCases/Posix/posix_spawn.c

11

I would prefer avoid including imp/lib/ headers here and use defined(APPLE)

compiler-rt/test/sanitizer_common/TestCases/Posix/posix_spawn.c

 // RUN: %clang %s -o %t && %run %t 2>&1 | FileCheck %s
 //
 // Older versions of Android do not have certain posix_spawn* functions.
 // UNSUPPORTED: android
 
 #include <assert.h>
 #include <spawn.h>
 #include <stdio.h>
 #include <sys/wait.h>
 
+#include "../../../../lib/sanitizer_common/sanitizer_platform.h"
+
 int main(int argc, char **argv) {
   if (argc > 1) {
     // CHECK: SPAWNED
     // CHECK: SPAWNED
     printf("SPAWNED\n");
     return 0;
   }
 
+  int s;
+
   posix_spawnattr_t attr = {0};
   posix_spawn_file_actions_t file_actions = {0};
 
+#if !SANITIZER_APPLE
+  s = posix_spawnattr_init(&attr);
+  assert(!s);
+
+  s = posix_spawn_file_actions_init(&file_actions);
+  assert(!s);
+#endif
+
   char *const args[] = {
       argv[0], "2", "3", "4", "2", "3", "4", "2", "3", "4",
       "2",     "3", "4", "2", "3", "4", "2", "3", "4", NULL,
   };
   char *const env[] = {
       "A=B", "A=B", "A=B", "A=B", "A=B", "A=B", "A=B", "A=B", "A=B", "A=B",
       "A=B", "A=B", "A=B", "A=B", "A=B", "A=B", "A=B", "A=B", "A=B", NULL,
   };
 
   pid_t pid;
-  int s = posix_spawn(&pid, argv[0], &file_actions, &attr, args, env);
+  s = posix_spawn(&pid, argv[0], &file_actions, &attr, args, env);
   assert(!s);
 
   waitpid(pid, &s, WUNTRACED | WCONTINUED);
 
   s = posix_spawnp(&pid, argv[0], &file_actions, &attr, args, env);
   assert(!s);
 
   waitpid(pid, &s, WUNTRACED | WCONTINUED);
   return 0;
 }