diff --git a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp --- a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp +++ b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp @@ -374,11 +374,7 @@ if (auto *StructVal = dyn_cast(&Val)) { auto &AggregateLoc = *cast(&Loc); - - const QualType Type = AggregateLoc.getType(); - assert(Type->isStructureOrClassType()); - - for (const FieldDecl *Field : getObjectFields(Type)) { + for (const FieldDecl *Field : getObjectFields(AggregateLoc.getType())) { assert(Field != nullptr); StorageLocation &FieldLoc = AggregateLoc.getChild(*Field); MemberLocToStruct[&FieldLoc] = std::make_pair(StructVal, Field); diff --git a/clang/unittests/Analysis/FlowSensitive/DataflowEnvironmentTest.cpp b/clang/unittests/Analysis/FlowSensitive/DataflowEnvironmentTest.cpp --- a/clang/unittests/Analysis/FlowSensitive/DataflowEnvironmentTest.cpp +++ b/clang/unittests/Analysis/FlowSensitive/DataflowEnvironmentTest.cpp @@ -10,6 +10,7 @@ #include "NoopAnalysis.h" #include "TestingSupport.h" #include "clang/Analysis/FlowSensitive/DataflowAnalysisContext.h" +#include "clang/Analysis/FlowSensitive/StorageLocation.h" #include "clang/Analysis/FlowSensitive/Value.h" #include "clang/Analysis/FlowSensitive/WatchedLiteralsSolver.h" #include "gmock/gmock.h" @@ -20,8 +21,7 @@ using namespace clang; using namespace dataflow; -using ::testing::ElementsAre; -using ::testing::Pair; +using ::testing::NotNull; class EnvironmentTest : public ::testing::Test { DataflowAnalysisContext Context; @@ -98,4 +98,25 @@ EXPECT_NE(PV, nullptr); } +TEST_F(EnvironmentTest, SetValueAdmitsNonStructAggregateStorageLocations) { + using namespace ast_matchers; + + std::string Code = "bool X;"; + auto Unit = + tooling::buildASTFromCodeWithArgs(Code, {"-fsyntax-only", "-std=c++11"}); + auto &Context = Unit->getASTContext(); + + ASSERT_EQ(Context.getDiagnostics().getClient()->getNumErrors(), 0U); + + const auto *Ty = selectFirst( + "target", match(qualType(builtinType()).bind("target"), Context)); + ASSERT_TRUE(Ty != nullptr && !Ty->isNull()); + + // Create an `AggregateStorageLocation` that is *not* backed by a struct. + auto &Loc = + Env.takeOwnership(std::make_unique(*Ty)); + auto &V = Env.takeOwnership(std::make_unique()); + Env.setValue(Loc, V); + EXPECT_EQ(Env.getValue(Loc), &V); +} } // namespace