Index: test/tools/lldb-mi/variable/TestMiVar.py =================================================================== --- test/tools/lldb-mi/variable/TestMiVar.py +++ test/tools/lldb-mi/variable/TestMiVar.py @@ -36,6 +36,10 @@ self.expect("\^error,msg=\"error: error: use of undeclared identifier \'undef\'\\\\nerror: 1 errors parsing expression\\\\n\"") self.runCmd("-data-evaluate-expression undef") self.expect("\^error,msg=\"Could not evaluate expression\"") + + # Check 2d array + self.runCmd("-data-evaluate-expression g_blk") + self.expect("\^done,value=\"\{\[0\] = \{\[0\] = 1, \[1\] = 2, \[2\] = 3\}, \[1\] = \{\[0\] = 4, \[1\] = 5, \[2\] = 6\}\}\"") # Print global "g_MyVar", modify, delete and create again self.runCmd("-data-evaluate-expression g_MyVar") Index: test/tools/lldb-mi/variable/main.cpp =================================================================== --- test/tools/lldb-mi/variable/main.cpp +++ test/tools/lldb-mi/variable/main.cpp @@ -96,11 +96,18 @@ int g_MyVar = 3; static int s_MyVar = 4; +int g_blk[2][3]; int main(int argc, char const *argv[]) { int a = 10, b = 20; + g_blk[0][0] = 1; + g_blk[0][1] = 2; + g_blk[0][2] = 3; + g_blk[1][0] = 4; + g_blk[1][1] = 5; + g_blk[1][2] = 6; s_MyVar = a + b; var_update_test(); var_list_children_test(); Index: tools/lldb-mi/MICmdCmdData.h =================================================================== --- tools/lldb-mi/MICmdCmdData.h +++ tools/lldb-mi/MICmdCmdData.h @@ -73,7 +73,6 @@ bool m_bEvaluatedExpression; // True = yes is expression evaluated, false = failed CMIUtilString m_strValue; CMICmnMIValueTuple m_miValueTuple; - bool m_bCompositeVarType; // True = yes composite type, false = internal type bool m_bFoundInvalidChar; // True = yes found unexpected character in the expression, false = all ok char m_cExpressionInvalidChar; const CMIUtilString m_constStrArgThread; // Not specified in MI spec but Eclipse gives this option. Not handled by command. Index: tools/lldb-mi/MICmdCmdData.cpp =================================================================== --- tools/lldb-mi/MICmdCmdData.cpp +++ tools/lldb-mi/MICmdCmdData.cpp @@ -54,7 +54,6 @@ : m_bExpressionValid(true) , m_bEvaluatedExpression(true) , m_strValue("??") - , m_bCompositeVarType(false) , m_bFoundInvalidChar(false) , m_cExpressionInvalidChar(0x00) , m_constStrArgThread("thread") @@ -145,41 +144,7 @@ m_strValue = rExpression.Trim('\"'); return MIstatus::success; } - - MIuint64 nNumber = 0; - if (CMICmnLLDBProxySBValue::GetValueAsUnsigned(value, nNumber) == MIstatus::success) - { - const lldb::ValueType eValueType = value.GetValueType(); - MIunused(eValueType); - m_strValue = utilValue.GetValue().Escape().AddSlashes(); - return MIstatus::success; - } - - // Composite type i.e. struct - m_bCompositeVarType = true; - const MIuint nChild = value.GetNumChildren(); - for (MIuint i = 0; i < nChild; i++) - { - lldb::SBValue member = value.GetChildAtIndex(i); - const bool bValid = member.IsValid(); - CMIUtilString strType(MIRSRC(IDS_WORD_UNKNOWNTYPE_BRKTS)); - if (bValid) - { - const CMIUtilString strValue( - CMICmnLLDBDebugSessionInfoVarObj::GetValueStringFormatted(member, CMICmnLLDBDebugSessionInfoVarObj::eVarFormat_Natural)); - const char *pTypeName = member.GetName(); - if (pTypeName != nullptr) - strType = pTypeName; - - // MI print "{variable = 1, variable2 = 3, variable3 = 5}" - const bool bNoQuotes = true; - const CMICmnMIValueConst miValueConst(strValue, bNoQuotes); - const bool bUseSpaces = true; - const CMICmnMIValueResult miValueResult(strType, miValueConst, bUseSpaces); - m_miValueTuple.Add(miValueResult, bUseSpaces); - } - } - + m_strValue = utilValue.GetValue(true).Escape().AddSlashes(); return MIstatus::success; } @@ -199,15 +164,6 @@ { if (m_bEvaluatedExpression) { - if (m_bCompositeVarType) - { - const CMICmnMIValueConst miValueConst(m_miValueTuple.GetString()); - const CMICmnMIValueResult miValueResult("value", miValueConst); - const CMICmnMIResultRecord miRecordResult(m_cmdData.strMiCmdToken, CMICmnMIResultRecord::eResultClass_Done, miValueResult); - m_miResultRecord = miRecordResult; - return MIstatus::success; - } - if (m_bFoundInvalidChar) { const CMICmnMIValueConst miValueConst(