[flang] Set red bold color for the keyword "fatal internal error"

[peixin]

Summary

Set red bold color for the keyword "fatal internal error".
Also fix several typos.

[peixin]

Please check the following example. This patch highlight the color for the "fatal internal error:" to red bold.

$ cat test.f90 
program m
contains
  subroutine sub()
    type my_type (k)
      integer, KIND :: k = 4
      integer :: x = 10
    end type
  end
end
$ bbc -emit-fir test.f90 

fatal internal error: node has not been analyzed:
Expr -> LiteralConstant -> IntLiteralConstant = '10'

PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.

BTW, there is one bug in semantic analysis for the derived type. Check https://github.com/llvm/llvm-project/blob/9d0d24eec44787b4a762d01866d0b9b733bee778/flang/lib/Semantics/resolve-names.cpp#L6678-L6686. It does not check if the symbol kind/len is from the parameter of derived type or intrinsic type. Will fix it later.

[klausler]

flang/lib/Common/idioms.cpp

19

Unnecessary and nonportable, and should at least be sensitive to whether the standard error output is a terminal or not.

[tschuett]

There is:
https://llvm.org/doxygen/classllvm_1_1WithColor.html
and
https://reviews.llvm.org/rG990d0c71090836fb117e72c262d6d19b76f346cc

[peixin]

@klausler I think you wanted to click "request change" instead of "approve", right?

@tschuett Thanks for the info.

This common::die does not use llvm ostream. Using it to set color in common::die will require more changes. Considering that @klausler thinks it is unnecessary, I will abandon this if no one wants to set color for the keyword.

flang/docs/FIRArrayOperations.md

 ```
 
 This operation merges the original loaded array value, `%v`, with the
 chained updates, `%r`, and stores the result to the array at address, `%a`.
 
 This operation taken with `array_load`'s captures Fortran's
 copy-in/copy-out semantics. The first operands of `array_merge_store` is the
 result of the initial `array_load` operation. While this value could be
-retrieved by reference chasiing through the different array operations it is
+retrieved by reference chasing through the different array operations it is
 useful to have it on hand directly for analysis passes since this directly
 defines the "bounds" of the Fortran statement represented by these operations.
 The intention is to allow copy-in/copy-out regions to be easily delineated,
 analyzed, and optimized.
 
 ## array_fetch
 
 The `array_fetch` operation fetches the value of an element in an array value.

 will be changed at the accessed position when `fir.array_merge_store` is
 performed.
 
 ## array_access
 
 The `array_access` provides a reference to a single element from an array value.
 This is *not* a view in the immutable array, otherwise it couldn't be stored to.
 It can be see as a logical copy of the element and its position in the array.
-Tis reference can be written to and modified withoiut changing the original
+Tis reference can be written to and modified without changing the original
 array.
 
 The `array_access` operation is used to fetch the memory reference of an element
 in an array value.
 
 ```fortran
   real :: a(n,m)
   ...

flang/lib/Common/idioms.cpp

 #include <cstdio>
 #include <cstdlib>
 
 namespace Fortran::common {
 
 [[noreturn]] void die(const char *msg, ...) {
   va_list ap;
   va_start(ap, msg);
-  std::fputs("\nfatal internal error: ", stderr);
+  std::fputs("\n\033[31m\033[1mfatal internal error: \033[0m", stderr);
   std::vfprintf(stderr, msg, ap);
   va_end(ap);
   fputc('\n', stderr);
   std::abort();
 }
 
 // Convert the int index of an enumerator to a string.
 // enumNames is a list of the names, separated by commas with optional spaces.

flang/lib/Optimizer/Builder/BoxValue.cpp

 static inline bool isUndefOp(mlir::Value v) {
   return mlir::isa_and_nonnull<fir::UndefOp>(v.getDefiningOp());
 }
 
 bool fir::ExtendedValue::isAssumedSize() const {
   return match(
       [](const fir::ArrayBoxValue &box) -> bool {
         return !box.getExtents().empty() && isUndefOp(box.getExtents().back());
-        ;
       },
       [](const fir::CharArrayBoxValue &box) -> bool {
         return !box.getExtents().empty() && isUndefOp(box.getExtents().back());
       },
       [](const auto &box) -> bool { return false; });
 }