diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -2761,18 +2761,11 @@ bool CodeGenModule::isInNoSanitizeList(llvm::GlobalVariable *GV, SourceLocation Loc, QualType Ty, StringRef Category) const { - // For now globals can be ignored only in ASan and KASan. - const SanitizerMask EnabledAsanMask = - LangOpts.Sanitize.Mask & - (SanitizerKind::Address | SanitizerKind::KernelAddress | - SanitizerKind::HWAddress | SanitizerKind::KernelHWAddress | - SanitizerKind::MemTag); - if (!EnabledAsanMask) - return false; const auto &NoSanitizeL = getContext().getNoSanitizeList(); - if (NoSanitizeL.containsGlobal(EnabledAsanMask, GV->getName(), Category)) + if (NoSanitizeL.containsGlobal(LangOpts.Sanitize.Mask, GV->getName(), + Category)) return true; - if (NoSanitizeL.containsLocation(EnabledAsanMask, Loc, Category)) + if (NoSanitizeL.containsLocation(LangOpts.Sanitize.Mask, Loc, Category)) return true; // Check global type. if (!Ty.isNull()) { @@ -2784,7 +2777,7 @@ // Only record types (classes, structs etc.) are ignored. if (Ty->isRecordType()) { std::string TypeStr = Ty.getAsString(getContext().getPrintingPolicy()); - if (NoSanitizeL.containsType(EnabledAsanMask, TypeStr, Category)) + if (NoSanitizeL.containsType(LangOpts.Sanitize.Mask, TypeStr, Category)) return true; } } diff --git a/clang/lib/CodeGen/SanitizerMetadata.h b/clang/lib/CodeGen/SanitizerMetadata.h --- a/clang/lib/CodeGen/SanitizerMetadata.h +++ b/clang/lib/CodeGen/SanitizerMetadata.h @@ -14,6 +14,7 @@ #include "clang/AST/Type.h" #include "clang/Basic/LLVM.h" +#include "clang/Basic/Sanitizers.h" #include "clang/Basic/SourceLocation.h" namespace llvm { @@ -47,7 +48,7 @@ private: void reportGlobal(llvm::GlobalVariable *GV, SourceLocation Loc, StringRef Name, QualType Ty, bool IsDynInit, - bool IsExcluded); + SanitizerMask NoSanitizeMask); llvm::MDNode *getLocationMetadata(SourceLocation Loc); }; } // end namespace CodeGen diff --git a/clang/lib/CodeGen/SanitizerMetadata.cpp b/clang/lib/CodeGen/SanitizerMetadata.cpp --- a/clang/lib/CodeGen/SanitizerMetadata.cpp +++ b/clang/lib/CodeGen/SanitizerMetadata.cpp @@ -16,6 +16,7 @@ #include "clang/Basic/SourceManager.h" #include "llvm/ADT/StringRef.h" #include "llvm/IR/Constants.h" +#include "llvm/IR/GlobalVariable.h" using namespace clang; using namespace CodeGen; @@ -23,6 +24,10 @@ SanitizerMetadata::SanitizerMetadata(CodeGenModule &CGM) : CGM(CGM) {} static bool isAsanHwasanOrMemTag(const SanitizerSet &SS) { + // TODO(hctim): Can be removed when we migrate off of llvm.asan.globals. This + // prevents llvm.asan.globals from being emitted for + // __attribute__((disable_sanitizer_instrumentation)) and uses of + // -fsanitize-ignorelist when a sanitizer isn't enabled. return SS.hasOneOf(SanitizerKind::Address | SanitizerKind::KernelAddress | SanitizerKind::HWAddress | SanitizerKind::KernelHWAddress | SanitizerKind::MemTag); @@ -31,10 +36,43 @@ void SanitizerMetadata::reportGlobal(llvm::GlobalVariable *GV, SourceLocation Loc, StringRef Name, QualType Ty, bool IsDynInit, - bool IsExcluded) { - IsDynInit &= !CGM.isInNoSanitizeList(GV, Loc, Ty, "init"); - IsExcluded |= CGM.isInNoSanitizeList(GV, Loc, Ty); + SanitizerMask NoSanitizeMask) { + llvm::GlobalVariable::SanitizerMetadata Meta; + if (GV->hasSanitizerMetadata()) + Meta = GV->getSanitizerMetadata(); + if (CGM.isInNoSanitizeList(GV, Loc, Ty)) + Meta.NoSanitize = true; + + if (NoSanitizeMask & SanitizerKind::Address) + NoSanitizeMask |= SanitizerKind::KernelAddress; + if (NoSanitizeMask & SanitizerKind::HWAddress) + NoSanitizeMask |= SanitizerKind::KernelHWAddress; + if (NoSanitizeMask & SanitizerKind::HWAddress) + NoSanitizeMask |= SanitizerKind::KernelHWAddress; + if (NoSanitizeMask & SanitizerKind::Memory) + NoSanitizeMask |= SanitizerKind::KernelMemory; + + SanitizerSet NoSanitizeSet = {NoSanitizeMask & + CGM.getLangOpts().Sanitize.Mask}; + + Meta.NoAddress |= NoSanitizeSet.hasOneOf(SanitizerKind::Address | + SanitizerKind::KernelAddress); + Meta.NoHWAddress |= NoSanitizeSet.hasOneOf(SanitizerKind::HWAddress | + SanitizerKind::KernelHWAddress); + Meta.NoMemtag |= NoSanitizeSet.hasOneOf(SanitizerKind::MemTag); + bool IsExcluded = + Meta.NoSanitize || Meta.NoAddress || Meta.NoHWAddress || Meta.NoMemtag; + + if (CGM.getLangOpts().Sanitize.hasOneOf(SanitizerKind::Address | + SanitizerKind::KernelAddress)) { + Meta.IsDynInit = IsDynInit && !CGM.isInNoSanitizeList(GV, Loc, Ty, "init"); + } + + GV->setSanitizerMetadata(Meta); + + // TODO(hctim): Code below can be removed when we migrate off of + // llvm.asan.globals onto the new metadata attributes. llvm::Metadata *LocDescr = nullptr; llvm::Metadata *GlobalName = nullptr; llvm::LLVMContext &VMContext = CGM.getLLVMContext(); @@ -48,8 +86,8 @@ llvm::Metadata *GlobalMetadata[] = { llvm::ConstantAsMetadata::get(GV), LocDescr, GlobalName, - llvm::ConstantAsMetadata::get( - llvm::ConstantInt::get(llvm::Type::getInt1Ty(VMContext), IsDynInit)), + llvm::ConstantAsMetadata::get(llvm::ConstantInt::get( + llvm::Type::getInt1Ty(VMContext), Meta.IsDynInit)), llvm::ConstantAsMetadata::get(llvm::ConstantInt::get( llvm::Type::getInt1Ty(VMContext), IsExcluded))}; @@ -63,6 +101,7 @@ bool IsDynInit) { if (!isAsanHwasanOrMemTag(CGM.getLangOpts().Sanitize)) return; + std::string QualName; llvm::raw_string_ostream OS(QualName); D.printQualifiedName(OS); @@ -78,7 +117,7 @@ return NoSanitizeMask; }; reportGlobal(GV, D.getLocation(), OS.str(), D.getType(), IsDynInit, - SanitizerSet{getNoSanitizeMask(D)}.has(SanitizerKind::Address)); + getNoSanitizeMask(D)); } void SanitizerMetadata::reportGlobal(llvm::GlobalVariable *GV, @@ -86,14 +125,13 @@ QualType Ty, bool IsDynInit) { if (!isAsanHwasanOrMemTag(CGM.getLangOpts().Sanitize)) return; - reportGlobal(GV, Loc, Name, Ty, IsDynInit, false); + reportGlobal(GV, Loc, Name, Ty, IsDynInit, {}); } void SanitizerMetadata::disableSanitizerForGlobal(llvm::GlobalVariable *GV) { - // For now, just make sure the global is not modified by the ASan - // instrumentation. - if (isAsanHwasanOrMemTag(CGM.getLangOpts().Sanitize)) - reportGlobal(GV, SourceLocation(), "", QualType(), false, true); + if (!isAsanHwasanOrMemTag(CGM.getLangOpts().Sanitize)) + return; + reportGlobal(GV, SourceLocation(), "", QualType(), false, SanitizerKind::All); } void SanitizerMetadata::disableSanitizerForInstruction(llvm::Instruction *I) { diff --git a/clang/test/CodeGen/asan-globals.cpp b/clang/test/CodeGen/asan-globals.cpp --- a/clang/test/CodeGen/asan-globals.cpp +++ b/clang/test/CodeGen/asan-globals.cpp @@ -23,6 +23,9 @@ const char *literal = "Hello, world!"; } +// ASAN: @dyn_init_global = global {{.*}}, sanitize_address_dyninit +// KASAN: @dyn_init_global = global {{.*}}, sanitize_address_dyninit + // ASAN: sectioned_global{{.*}} global { i32, [28 x i8] }{{.*}}, align 32 // KASAN: sectioned_global{{.*}} global i32 // ASAN: @__special_global{{.*}} global { i32, [28 x i8] }{{.*}}, align 32 diff --git a/clang/test/CodeGen/sanitize-init-order.cpp b/clang/test/CodeGen/sanitize-init-order.cpp --- a/clang/test/CodeGen/sanitize-init-order.cpp +++ b/clang/test/CodeGen/sanitize-init-order.cpp @@ -36,12 +36,29 @@ // Check that ASan init-order checking ignores structs with trivial default // constructor. + +// CHECK: @s1 = global +// CHECK-NOT: sanitize_address_dyninit +// CHECK: @s2 = global +// CHECK-NOT: sanitize_address_dyninit +// CHECK: @s3 = global {{.*}}, sanitize_address_dyninit +// CHECK: @{{.*}}array{{.*}} = global {{.*}}, sanitize_address_dyninit + // CHECK: !llvm.asan.globals = !{![[GLOB_1:[0-9]+]], ![[GLOB_2:[0-9]+]], ![[GLOB_3:[0-9]+]], ![[GLOB_4:[0-9]+]] // CHECK: ![[GLOB_1]] = !{%struct.PODStruct* {{.*}}, i1 false, i1 false} // CHECK: ![[GLOB_2]] = !{%struct.PODWithDtor* {{.*}}, i1 false, i1 false} // CHECK: ![[GLOB_3]] = !{%struct.PODWithCtorAndDtor* {{.*}}, i1 true, i1 false} // CHECK: ![[GLOB_4]] = !{{{.*}}class.NS::PODWithCtor{{.*}}, i1 true, i1 false} +// IGNORELIST: @s1 = global +// IGNORELIST-NOT: sanitize_address_dyninit +// IGNORELIST: @s2 = global +// IGNORELIST-NOT: sanitize_address_dyninit +// IGNORELIST: @s3 = global +// IGNORELIST-NOT: sanitize_address_dyninit +// IGNORELIST: @{{.*}}array{{.*}} = global +// IGNORELIST-NOT: sanitize_address_dyninit + // IGNORELIST: !llvm.asan.globals = !{![[GLOB_1:[0-9]+]], ![[GLOB_2:[0-9]+]], ![[GLOB_3:[0-9]+]], ![[GLOB_4:[0-9]+]]} // IGNORELIST: ![[GLOB_1]] = !{%struct.PODStruct* {{.*}}, i1 false, i1 false} // IGNORELIST: ![[GLOB_2]] = !{%struct.PODWithDtor* {{.*}}, i1 false, i1 false}