This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP][libomp] Fix fallthrough attribute detection for Intel compilers
ClosedPublic

Authored by jlpeyton on May 19 2022, 11:48 AM.

Details

Summary

Force the feature off for icc.

icc does not properly detect lack of fallthrough attribute since it
defines __GNU__ > 7 and also icc's __has_cpp_attribute/__has_attribute
feature detectors do not properly detect the lack of fallthrough attribute.

Diff Detail

Event Timeline

jlpeyton created this revision.May 19 2022, 11:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2022, 11:48 AM
jlpeyton requested review of this revision.May 19 2022, 11:48 AM
This revision is now accepted and ready to land.Jul 15 2022, 8:58 AM