diff --git a/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h b/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h --- a/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h +++ b/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h @@ -221,11 +221,7 @@ class UndefinedVal : public SVal { public: UndefinedVal() : SVal(UndefinedValKind) {} - static bool classof(SVal V) { return V.getBaseKind() == UndefinedValKind; } - -private: - friend class SVal; }; class DefinedOrUnknownSVal : public SVal { @@ -242,9 +238,6 @@ explicit DefinedOrUnknownSVal(const void *d, bool isLoc, unsigned ValKind) : SVal(d, isLoc, ValKind) {} explicit DefinedOrUnknownSVal(BaseKind k, void *D = nullptr) : SVal(k, D) {} - -private: - friend class SVal; }; class UnknownVal : public DefinedOrUnknownSVal { @@ -252,9 +245,6 @@ explicit UnknownVal() : DefinedOrUnknownSVal(UnknownValKind) {} static bool classof(SVal V) { return V.getBaseKind() == UnknownValKind; } - -private: - friend class SVal; }; class DefinedSVal : public DefinedOrUnknownSVal { @@ -271,14 +261,10 @@ DefinedSVal() = default; explicit DefinedSVal(const void *d, bool isLoc, unsigned ValKind) : DefinedOrUnknownSVal(d, isLoc, ValKind) {} - -private: - friend class SVal; }; /// Represents an SVal that is guaranteed to not be UnknownVal. class KnownSVal : public SVal { - friend class SVal; KnownSVal() = default; public: @@ -302,9 +288,6 @@ } static bool classof(SVal V) { return V.getBaseKind() == NonLocKind; } - -private: - friend class SVal; }; class Loc : public DefinedSVal { @@ -322,9 +305,6 @@ } static bool classof(SVal V) { return V.getBaseKind() == LocKind; } - -private: - friend class SVal; }; //==------------------------------------------------------------------------==// @@ -355,9 +335,6 @@ } static bool classof(NonLoc V) { return V.getSubKind() == SymbolValKind; } - -private: - friend class SVal; }; /// Value representing integer constant. @@ -384,7 +361,6 @@ static bool classof(NonLoc V) { return V.getSubKind() == ConcreteIntKind; } private: - friend class SVal; ConcreteInt() = default; }; @@ -427,7 +403,6 @@ static bool classof(NonLoc V) { return V.getSubKind() == LocAsIntegerKind; } private: - friend class SVal; LocAsInteger() = default; }; @@ -453,7 +428,6 @@ static bool classof(NonLoc V) { return V.getSubKind() == CompoundValKind; } private: - friend class SVal; CompoundVal() = default; }; @@ -481,7 +455,6 @@ } private: - friend class SVal; LazyCompoundVal() = default; }; @@ -530,8 +503,6 @@ } private: - friend class SVal; - PointerToMember() = default; explicit PointerToMember(const PTMDataType D) : NonLoc(PointerToMemberKind, D.getOpaqueValue()) {} @@ -562,7 +533,6 @@ static bool classof(Loc V) { return V.getSubKind() == GotoLabelKind; } private: - friend class SVal; GotoLabel() = default; }; @@ -600,7 +570,6 @@ static bool classof(Loc V) { return V.getSubKind() == MemRegionValKind; } private: - friend class SVal; MemRegionVal() = default; }; @@ -623,7 +592,6 @@ static bool classof(Loc V) { return V.getSubKind() == ConcreteIntKind; } private: - friend class SVal; ConcreteInt() = default; };