SelectionDAGDumper: Hide [ID=X], [ORD=X] and source locations by default.

[MatzeB]

Summary

You can still show them with the new -dag-dump-verbose switch.

[MatzeB]

ping

[resistor]

LGTM.

llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp

 #include "llvm/Support/raw_ostream.h"
 #include "llvm/Target/TargetInstrInfo.h"
 #include "llvm/Target/TargetIntrinsicInfo.h"
 #include "llvm/Target/TargetMachine.h"
 #include "llvm/Target/TargetRegisterInfo.h"
 #include "llvm/Target/TargetSubtargetInfo.h"
 using namespace llvm;
 
+static cl::opt<bool>
+VerboseDAGDumping("dag-dump-verbose", cl::Hidden,
+                  cl::desc("Display more information when dumping selection "
+                           "DAG nodes."));
+
 std::string SDNode::getOperationName(const SelectionDAG *G) const {
   switch (getOpcode()) {
   default:
     if (getOpcode() < ISD::BUILTIN_OP_END)
       return "<<Unknown DAG Node>>";
     if (isMachineOpcode()) {
       if (G)
         if (const TargetInstrInfo *TII = G->getSubtarget().getInstrInfo())
if (unsigned int TF = BA->getTargetFlags())
                dyn_cast<AddrSpaceCastSDNode>(this)) {
     OS << '['
        << ASC->getSrcAddressSpace()
        << " -> "
        << ASC->getDestAddressSpace()
        << ']';
   }
 
+  if (VerboseDAGDumping) {
     if (unsigned Order = getIROrder())
         OS << " [ORD=" << Order << ']';
 
     if (getNodeId() != -1)
       OS << " [ID=" << getNodeId() << ']';
 
     if (!G)
       return;
 
     DILocation *L = getDebugLoc();
     if (!L)
       return;
 
     if (auto *Scope = L->getScope())
       OS << Scope->getFilename();
     else
       OS << "<unknown>";
     OS << ':' << L->getLine();
     if (unsigned C = L->getColumn())
       OS << ':' << C;
   }
+}
 
 static void DumpNodes(const SDNode *N, unsigned indent, const SelectionDAG *G) {
   for (const SDValue &Op : N->op_values())
     if (Op.getNode()->hasOneUse())
       DumpNodes(Op.getNode(), indent+2, G);
     else
       dbgs() << "\n" << std::string(indent+2, ' ')
              << PrintNodeId(*Op.getNode()) << ": <multiple use>";

llvm/trunk/test/DebugInfo/Generic/constant-sdnodes-have-dbg-location.ll

-; RUN: llc -debug < %s 2>&1 | FileCheck %s
+; RUN: llc -debug -dag-dump-verbose < %s 2>&1 | FileCheck %s
 ; REQUIRES: asserts
 
 ; CHECK: t{{[0-9]+}}: i32 = Constant<-1>test.c:4:5
 
 define i32 @main() {
 entry:
   %retval = alloca i32, align 4
   store i32 0, i32* %retval

llvm/trunk/test/DebugInfo/Generic/constantfp-sdnodes-have-dbg-location.ll

-; RUN: llc -debug < %s 2>&1 | FileCheck %s
+; RUN: llc -debug -dag-dump-verbose < %s 2>&1 | FileCheck %s
 ; REQUIRES: asserts
 
 ; CHECK: t{{[0-9]+}}: f64 = ConstantFP<1.500000e+00>test.c:3:5
 
 define double @f() {
 entry:
   ret double 1.500000e+00, !dbg !10
 }