diff --git a/bolt/lib/Core/BinaryFunction.cpp b/bolt/lib/Core/BinaryFunction.cpp --- a/bolt/lib/Core/BinaryFunction.cpp +++ b/bolt/lib/Core/BinaryFunction.cpp @@ -419,7 +419,7 @@ if (AllNames.size() > 1) { OS << "\n All names : "; const char *Sep = ""; - for (const StringRef Name : AllNames) { + for (const StringRef &Name : AllNames) { OS << Sep << Name; Sep = "\n "; } diff --git a/bolt/lib/Profile/DataReader.cpp b/bolt/lib/Profile/DataReader.cpp --- a/bolt/lib/Profile/DataReader.cpp +++ b/bolt/lib/Profile/DataReader.cpp @@ -56,7 +56,7 @@ /// Return true if the function name can change across compilations. bool hasVolatileName(const BinaryFunction &BF) { - for (const StringRef Name : BF.getNames()) + for (const StringRef &Name : BF.getNames()) if (getLTOCommonName(Name)) return true; diff --git a/bolt/lib/Rewrite/BoltDiff.cpp b/bolt/lib/Rewrite/BoltDiff.cpp --- a/bolt/lib/Rewrite/BoltDiff.cpp +++ b/bolt/lib/Rewrite/BoltDiff.cpp @@ -219,7 +219,7 @@ const BinaryFunction &Function = BFI.second; const double Score = getNormalizedScore(Function, RI1); LargestBin1.insert(std::make_pair<>(Score, &Function)); - for (const StringRef Name : Function.getNames()) { + for (const StringRef &Name : Function.getNames()) { if (Optional OptionalLTOName = getLTOCommonName(Name)) LTOName = *OptionalLTOName; NameLookup[Name] = &Function; @@ -239,7 +239,7 @@ const BinaryFunction &Function = BFI.second; const double Score = getNormalizedScore(Function, RI2); LargestBin2.insert(std::make_pair<>(Score, &Function)); - for (const StringRef Name : Function.getNames()) { + for (const StringRef &Name : Function.getNames()) { if (Optional OptionalLTOName = getLTOCommonName(Name)) LTOName = *OptionalLTOName; } @@ -261,7 +261,7 @@ const BinaryFunction &Function2 = BFI2.second; StringRef LTOName; bool Match = false; - for (const StringRef Name : Function2.getNames()) { + for (const StringRef &Name : Function2.getNames()) { auto Iter = NameLookup.find(Name); if (Optional OptionalLTOName = getLTOCommonName(Name)) LTOName = *OptionalLTOName;