diff --git a/clang/lib/AST/Decl.cpp b/clang/lib/AST/Decl.cpp --- a/clang/lib/AST/Decl.cpp +++ b/clang/lib/AST/Decl.cpp @@ -3281,7 +3281,7 @@ } bool FunctionDecl::isInExternCContext() const { - if (hasAttr()) + if (hasAttr() || hasAttr()) return true; return getLexicalDeclContext()->isExternCContext(); } diff --git a/clang/lib/CodeGen/CGHLSLRuntime.h b/clang/lib/CodeGen/CGHLSLRuntime.h --- a/clang/lib/CodeGen/CGHLSLRuntime.h +++ b/clang/lib/CodeGen/CGHLSLRuntime.h @@ -15,8 +15,13 @@ #ifndef LLVM_CLANG_LIB_CODEGEN_CGHLSLRUNTIME_H #define LLVM_CLANG_LIB_CODEGEN_CGHLSLRUNTIME_H +namespace llvm { +class Function; +} namespace clang { +class FunctionDecl; + namespace CodeGen { class CodeGenModule; @@ -30,6 +35,8 @@ virtual ~CGHLSLRuntime() {} void finishCodeGen(); + + void setHLSLFnuctionAttributes(llvm::Function *, const FunctionDecl *); }; } // namespace CodeGen diff --git a/clang/lib/CodeGen/CGHLSLRuntime.cpp b/clang/lib/CodeGen/CGHLSLRuntime.cpp --- a/clang/lib/CodeGen/CGHLSLRuntime.cpp +++ b/clang/lib/CodeGen/CGHLSLRuntime.cpp @@ -50,3 +50,12 @@ llvm::Module &M = CGM.getModule(); addDxilValVersion(TargetOpts.DxilValidatorVersion, M); } + +void clang::CodeGen::CGHLSLRuntime::setHLSLFnuctionAttributes( + llvm::Function *F, const FunctionDecl *FD) { + if (HLSLShaderAttr *ShaderAttr = FD->getAttr()) { + const StringRef ShaderAttrKindStr = "dx.shader"; + F->addFnAttr(ShaderAttrKindStr, + ShaderAttr->ConvertShaderTypeToStr(ShaderAttr->getType())); + } +} diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -1650,6 +1650,10 @@ /*AttrOnCallSite=*/false, IsThunk); F->setAttributes(PAL); F->setCallingConv(static_cast(CallingConv)); + if (getLangOpts().HLSL) { + if (const FunctionDecl *FD = dyn_cast_or_null(GD.getDecl())) + getHLSLRuntime().setHLSLFnuctionAttributes(F, FD); + } } static void removeImageAccessQualifier(std::string& TyName) { diff --git a/clang/test/CodeGenHLSL/entry.hlsl b/clang/test/CodeGenHLSL/entry.hlsl new file mode 100644 --- /dev/null +++ b/clang/test/CodeGenHLSL/entry.hlsl @@ -0,0 +1,10 @@ +// RUN: %clang --driver-mode=dxc -Tcs_6_1 -Efoo -fcgl -Fo - %s | FileCheck %s + +// Make sure not mangle entry. +// CHECK:define void @foo() +// Make sure add function attribute. +// CHECK:"dx.shader"="compute" +[numthreads(1,1,1)] +void foo() { + +} diff --git a/clang/test/CodeGenHLSL/shader_type_attr.hlsl b/clang/test/CodeGenHLSL/shader_type_attr.hlsl new file mode 100644 --- /dev/null +++ b/clang/test/CodeGenHLSL/shader_type_attr.hlsl @@ -0,0 +1,11 @@ +// RUN: %clang --driver-mode=dxc -Tlib_6_x -fcgl -Fo - %s | FileCheck %s + +// Make sure not mangle entry. +// CHECK:define void @foo() +// Make sure add function attribute. +// CHECK:"dx.shader"="compute" +[shader("compute")] +[numthreads(1,1,1)] +void foo() { + +}