diff --git a/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp b/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp --- a/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp +++ b/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp @@ -122,7 +122,7 @@ AGPR_OFFSET = 256, // Maximum programmable ArchVGPRs across all targets. SQ_MAX_PGM_SGPRS = 256, // Maximum programmable SGPRs across all targets. NUM_EXTRA_VGPRS = 1, // A reserved slot for DS. - EXTRA_VGPR_LDS = 0, // This is a placeholder the Shader algorithm uses. + EXTRA_VGPR_LDS = 0, // An artificial register to track LDS writes. NUM_ALL_VGPRS = SQ_MAX_PGM_VGPRS + NUM_EXTRA_VGPRS, // Where SGPR starts. }; @@ -496,6 +496,14 @@ } } +// MUBUF and FLAT LDS DMA operations need a wait on vmcnt before LDS written +// can be accessed. A load from LDS to VMEM does not need a wait. +static bool mayWriteLDSThroughDMA(const MachineInstr &MI) { + return SIInstrInfo::isVALU(MI) && + (SIInstrInfo::isMUBUF(MI) || SIInstrInfo::isFLAT(MI)) && + MI.getOpcode() != AMDGPU::BUFFER_STORE_LDS_DWORD; +} + void WaitcntBrackets::updateByEvent(const SIInstrInfo *TII, const SIRegisterInfo *TRI, const MachineRegisterInfo *MRI, @@ -644,7 +652,7 @@ setRegScore(RegNo, T, CurrScore); } } - if (TII->isDS(Inst) && Inst.mayStore()) { + if (Inst.mayStore() && (TII->isDS(Inst) || mayWriteLDSThroughDMA(Inst))) { setRegScore(SQ_MAX_PGM_VGPRS + EXTRA_VGPR_LDS, T, CurrScore); } } @@ -1089,7 +1097,7 @@ SLoadAddresses.erase(Ptr); } unsigned AS = Memop->getAddrSpace(); - if (AS != AMDGPUAS::LOCAL_ADDRESS) + if (AS != AMDGPUAS::LOCAL_ADDRESS && AS != AMDGPUAS::FLAT_ADDRESS) continue; unsigned RegNo = SQ_MAX_PGM_VGPRS + EXTRA_VGPR_LDS; // VM_CNT is only relevant to vgpr or LDS. diff --git a/llvm/test/CodeGen/AMDGPU/lds-dma-waitcnt.mir b/llvm/test/CodeGen/AMDGPU/lds-dma-waitcnt.mir new file mode 100644 --- /dev/null +++ b/llvm/test/CodeGen/AMDGPU/lds-dma-waitcnt.mir @@ -0,0 +1,98 @@ +# RUN: llc -march=amdgcn -mcpu=gfx940 -verify-machineinstrs -run-pass si-insert-waitcnts -o - %s | FileCheck -check-prefix=GCN %s + +# GCN-LABEL: name: buffer_load_dword_lds_ds_read +# GCN: BUFFER_LOAD_DWORD_LDS_IDXEN +# GCN-NEXT: S_WAITCNT 3952 +# vmcnt(0) +# GCN-NEXT: DS_READ_B32_gfx9 +--- +name: buffer_load_dword_lds_ds_read +body: | + bb.0: + $m0 = S_MOV_B32 0 + BUFFER_LOAD_DWORD_LDS_IDXEN $vgpr0, $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr4, 4, 0, 0, implicit $exec, implicit $m0 :: (load (s32) from `i32 addrspace(1)* undef` + 4), (store (s32) into `i32 addrspace(3)* undef` + 4) + $vgpr0 = DS_READ_B32_gfx9 $vgpr1, 0, 0, implicit $m0, implicit $exec :: (load (s32) from `i32 addrspace(3)* undef`) + S_ENDPGM 0 + +... + +# GCN-LABEL: name: buffer_load_dword_lds_vmcnt_1 +# GCN: BUFFER_LOAD_DWORD_LDS_IDXEN +# GCN-NEXT: BUFFER_LOAD_DWORD_IDXEN +# GCN-NEXT: S_WAITCNT 3953 +# vmcnt(1) +# GCN-NEXT: DS_READ_B32_gfx9 +--- +name: buffer_load_dword_lds_vmcnt_1 +body: | + bb.0: + $m0 = S_MOV_B32 0 + BUFFER_LOAD_DWORD_LDS_IDXEN $vgpr0, $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr4, 4, 0, 0, implicit $exec, implicit $m0 :: (load (s32) from `i32 addrspace(1)* undef`), (store (s32) into `i32 addrspace(3)* undef`) + $vgpr10 = BUFFER_LOAD_DWORD_IDXEN $vgpr0, $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr4, 4, 0, 0, 0, implicit $exec, implicit $m0 :: (load (s32) from `i32 addrspace(1)* undef`) + $vgpr0 = DS_READ_B32_gfx9 $vgpr1, 0, 0, implicit $m0, implicit $exec :: (load (s32) from `i32 addrspace(3)* undef`) + S_ENDPGM 0 + +... + +# GCN-LABEL: name: buffer_load_dword_lds_flat_read +# GCN: BUFFER_LOAD_DWORD_LDS_IDXEN +# GCN-NEXT: S_WAITCNT 3952 +# vmcnt(0) +# GCN-NEXT: FLAT_LOAD_DWORD +--- +name: buffer_load_dword_lds_flat_read +body: | + bb.0: + $m0 = S_MOV_B32 0 + BUFFER_LOAD_DWORD_LDS_IDXEN $vgpr0, $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr4, 4, 0, 0, implicit $exec, implicit $m0 :: (load (s32) from `i32 addrspace(1)* undef`), (store (s32) into `i32 addrspace(3)* undef`) + $vgpr0 = FLAT_LOAD_DWORD $vgpr0_vgpr1, 0, 0, implicit $exec, implicit $flat_scr :: (load (s32) from `i32* undef`) + + S_ENDPGM 0 + +... + +# GCN-LABEL: name: global_load_lds_dword_ds_read +# GCN: GLOBAL_LOAD_LDS_DWORD +# GCN-NEXT: S_WAITCNT 3952 +# vmcnt(0) +# GCN-NEXT: DS_READ_B32_gfx9 +--- +name: global_load_lds_dword_ds_read +body: | + bb.0: + $m0 = S_MOV_B32 0 + GLOBAL_LOAD_LDS_DWORD $vgpr0_vgpr1, 4, 0, implicit $exec, implicit $m0 :: (load (s32) from `i32 addrspace(1)* undef` + 4), (store (s32) into `i32 addrspace(3)* undef` + 4) + $vgpr0 = DS_READ_B32_gfx9 $vgpr1, 0, 0, implicit $m0, implicit $exec :: (load (s32) from `i32 addrspace(3)* undef`) + S_ENDPGM 0 + +... + +# GCN-LABEL: name: scratch_load_lds_dword_ds_read +# GCN: SCRATCH_LOAD_LDS_DWORD +# GCN-NEXT: S_WAITCNT 3952 +# vmcnt(0) +# GCN-NEXT: DS_READ_B32_gfx9 +--- +name: scratch_load_lds_dword_ds_read +body: | + bb.0: + $m0 = S_MOV_B32 0 + SCRATCH_LOAD_LDS_DWORD $vgpr0, 4, 0, implicit $exec, implicit $m0 :: (load (s32) from `i32 addrspace(5)* undef` + 4), (store (s32) into `i32 addrspace(3)* undef` + 4) + $vgpr0 = DS_READ_B32_gfx9 $vgpr1, 0, 0, implicit $m0, implicit $exec :: (load (s32) from `i32 addrspace(3)* undef`) + S_ENDPGM 0 + +... + +# GCN-LABEL: name: buffer_store_lds_dword_ds_read +# GCN: BUFFER_STORE_LDS_DWORD +# GCN-NEXT: DS_READ_B32_gfx9 +--- +name: buffer_store_lds_dword_ds_read +body: | + bb.0: + $m0 = S_MOV_B32 0 + BUFFER_STORE_LDS_DWORD $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr4, 4, 0, 0, implicit $exec, implicit $m0 :: (load (s32) from `i32 addrspace(3)* undef` + 4), (store (s32) into `i32 addrspace(1)* undef` + 4) + $vgpr0 = DS_READ_B32_gfx9 $vgpr1, 0, 0, implicit $m0, implicit $exec :: (load (s32) from `i32 addrspace(3)* undef`) + S_ENDPGM 0 + +...