diff --git a/clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h b/clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h --- a/clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h +++ b/clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h @@ -48,7 +48,6 @@ public: DependencyScanningService(ScanningMode Mode, ScanningOutputFormat Format, bool ReuseFileManager = true, - bool SkipExcludedPPRanges = true, bool OptimizeArgs = false); ScanningMode getMode() const { return Mode; } @@ -57,8 +56,6 @@ bool canReuseFileManager() const { return ReuseFileManager; } - bool canSkipExcludedPPRanges() const { return SkipExcludedPPRanges; } - bool canOptimizeArgs() const { return OptimizeArgs; } DependencyScanningFilesystemSharedCache &getSharedCache() { @@ -69,10 +66,6 @@ const ScanningMode Mode; const ScanningOutputFormat Format; const bool ReuseFileManager; - /// Set to true to use the preprocessor optimization that skips excluded PP - /// ranges by bumping the buffer pointer in the lexer instead of lexing the - /// tokens in the range until reaching the corresponding directive. - const bool SkipExcludedPPRanges; /// Whether to optimize the modules' command-line arguments. const bool OptimizeArgs; /// The global file system cache. diff --git a/clang/lib/Tooling/DependencyScanning/DependencyScanningService.cpp b/clang/lib/Tooling/DependencyScanning/DependencyScanningService.cpp --- a/clang/lib/Tooling/DependencyScanning/DependencyScanningService.cpp +++ b/clang/lib/Tooling/DependencyScanning/DependencyScanningService.cpp @@ -15,9 +15,9 @@ DependencyScanningService::DependencyScanningService( ScanningMode Mode, ScanningOutputFormat Format, bool ReuseFileManager, - bool SkipExcludedPPRanges, bool OptimizeArgs) + bool OptimizeArgs) : Mode(Mode), Format(Format), ReuseFileManager(ReuseFileManager), - SkipExcludedPPRanges(SkipExcludedPPRanges), OptimizeArgs(OptimizeArgs) { + OptimizeArgs(OptimizeArgs) { // Initialize targets for object file support. llvm::InitializeAllTargets(); llvm::InitializeAllTargetMCs(); diff --git a/clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp b/clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp --- a/clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp +++ b/clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp @@ -288,9 +288,7 @@ OverlayFS->pushOverlay(InMemoryFS); RealFS = OverlayFS; - if (Service.canSkipExcludedPPRanges()) - PPSkipMappings = - std::make_unique(); + PPSkipMappings = std::make_unique(); if (Service.getMode() == ScanningMode::MinimizedSourcePreprocessing) DepFS = new DependencyScanningWorkerFilesystem( Service.getSharedCache(), RealFS, PPSkipMappings.get()); diff --git a/clang/test/ClangScanDeps/regular_cdb.cpp b/clang/test/ClangScanDeps/regular_cdb.cpp --- a/clang/test/ClangScanDeps/regular_cdb.cpp +++ b/clang/test/ClangScanDeps/regular_cdb.cpp @@ -20,11 +20,6 @@ // RUN: clang-scan-deps -compilation-database %t_clangcl.cdb -j 1 -mode preprocess | \ // RUN: FileCheck --check-prefixes=CHECK1,CHECK2,CHECK2NO,CHECK3 %s -// RUN: clang-scan-deps -compilation-database %t.cdb -j 1 -mode preprocess-minimized-sources \ -// RUN: -skip-excluded-pp-ranges=0 | FileCheck --check-prefixes=CHECK1,CHECK2,CHECK2NO,CHECK3 %s -// RUN: clang-scan-deps -compilation-database %t_clangcl.cdb -j 1 -mode preprocess-minimized-sources \ -// RUN: -skip-excluded-pp-ranges=0 | FileCheck --check-prefixes=CHECK1,CHECK2,CHECK2NO,CHECK3 %s -// // Make sure we didn't produce any dependency files! // RUN: not cat %t.dir/regular_cdb.d // RUN: not cat %t.dir/regular_cdb_clangcl.d diff --git a/clang/tools/clang-scan-deps/ClangScanDeps.cpp b/clang/tools/clang-scan-deps/ClangScanDeps.cpp --- a/clang/tools/clang-scan-deps/ClangScanDeps.cpp +++ b/clang/tools/clang-scan-deps/ClangScanDeps.cpp @@ -191,14 +191,6 @@ llvm::cl::desc("Reuse the file manager and its cache between invocations."), llvm::cl::init(true), llvm::cl::cat(DependencyScannerCategory)); -llvm::cl::opt SkipExcludedPPRanges( - "skip-excluded-pp-ranges", - llvm::cl::desc( - "Use the preprocessor optimization that skips excluded conditionals by " - "bumping the buffer pointer in the lexer instead of lexing the tokens " - "until reaching the end directive."), - llvm::cl::init(true), llvm::cl::cat(DependencyScannerCategory)); - llvm::cl::opt ModuleName( "module-name", llvm::cl::Optional, llvm::cl::desc("the module of which the dependencies are to be computed"), @@ -522,7 +514,7 @@ SharedStream DependencyOS(llvm::outs()); DependencyScanningService Service(ScanMode, Format, ReuseFileManager, - SkipExcludedPPRanges, OptimizeArgs); + OptimizeArgs); llvm::ThreadPool Pool(llvm::hardware_concurrency(NumThreads)); std::vector> WorkerTools; for (unsigned I = 0; I < Pool.getThreadCount(); ++I)