diff --git a/clang-tools-extra/clang-tidy/ClangTidy.cpp b/clang-tools-extra/clang-tidy/ClangTidy.cpp --- a/clang-tools-extra/clang-tidy/ClangTidy.cpp +++ b/clang-tools-extra/clang-tidy/ClangTidy.cpp @@ -402,11 +402,7 @@ Context.setCurrentBuildDirectory(WorkingDir.get()); std::vector> Checks = - CheckFactories->createChecks(&Context); - - llvm::erase_if(Checks, [&](std::unique_ptr &Check) { - return !Check->isLanguageVersionSupported(Context.getLangOpts()); - }); + CheckFactories->createChecksForLanguage(&Context); ast_matchers::MatchFinder::MatchFinderOptions FinderOptions; diff --git a/clang-tools-extra/clang-tidy/ClangTidyModule.h b/clang-tools-extra/clang-tidy/ClangTidyModule.h --- a/clang-tools-extra/clang-tidy/ClangTidyModule.h +++ b/clang-tools-extra/clang-tidy/ClangTidyModule.h @@ -67,6 +67,10 @@ std::vector> createChecks(ClangTidyContext *Context); + /// Create instances of checks that are enabled for the current Language. + std::vector> + createChecksForLanguage(ClangTidyContext *Context); + typedef llvm::StringMap FactoryMap; FactoryMap::const_iterator begin() const { return Factories.begin(); } FactoryMap::const_iterator end() const { return Factories.end(); } diff --git a/clang-tools-extra/clang-tidy/ClangTidyModule.cpp b/clang-tools-extra/clang-tidy/ClangTidyModule.cpp --- a/clang-tools-extra/clang-tidy/ClangTidyModule.cpp +++ b/clang-tools-extra/clang-tidy/ClangTidyModule.cpp @@ -31,6 +31,21 @@ return Checks; } +std::vector> +ClangTidyCheckFactories::createChecksForLanguage(ClangTidyContext *Context) { + std::vector> Checks; + const LangOptions &LO = Context->getLangOpts(); + for (const auto &Factory : Factories) { + if (!Context->isCheckEnabled(Factory.getKey())) + continue; + std::unique_ptr Check = + Factory.getValue()(Factory.getKey(), Context); + if (Check->isLanguageVersionSupported(LO)) + Checks.push_back(std::move(Check)); + } + return Checks; +} + ClangTidyOptions ClangTidyModule::getModuleOptions() { return ClangTidyOptions(); } diff --git a/clang-tools-extra/clangd/ParsedAST.cpp b/clang-tools-extra/clangd/ParsedAST.cpp --- a/clang-tools-extra/clangd/ParsedAST.cpp +++ b/clang-tools-extra/clangd/ParsedAST.cpp @@ -480,10 +480,7 @@ CTContext->setASTContext(&Clang->getASTContext()); CTContext->setCurrentFile(Filename); CTContext->setSelfContainedDiags(true); - CTChecks = CTFactories.createChecks(CTContext.getPointer()); - llvm::erase_if(CTChecks, [&](const auto &Check) { - return !Check->isLanguageVersionSupported(CTContext->getLangOpts()); - }); + CTChecks = CTFactories.createChecksForLanguage(CTContext.getPointer()); Preprocessor *PP = &Clang->getPreprocessor(); for (const auto &Check : CTChecks) { Check->registerPPCallbacks(Clang->getSourceManager(), PP, PP);