Use $<TARGET_FILE:...> to get the path lf lldb in test runs.

[sas]

Summary

Instead of hardcoding the path, we should use $<TARGET_FILE:...> which
works better when the output path differs, e.g. when building with MSVC.

$<TARGET_FILE:...> is expanded during the generation of the final build
files, so we can't use it in output messages/comments. This patch
modifies build messages to display the full command instead of "Testing
LLDB with ..." messages.

[zturner]

I'm not familiar with that $<TARGET_FILE> expression, but if you're certain
that it's equivalent to what was there previously, this looks fine.

But why were the two "Testing LLDB..." messages removed?

[sas]

I removed the "Testing..." messages because $<TARGET_FILE:...> won't be expanded in the context of a log message. Basically, you'll end up with ninja/msvc/make printing "Testing LLDB with args: --arch=x86_64;--executable;$<TARGET_FILE:lldb>;-s;/..." (even though it will be running the right command with the actual lldb path).

[zturner]

I think it's still worth printing something, even if it's just "Testing
LLDB with N processes", where you fill in the value for N

test/CMakeLists.txt

-function(add_python_test_target name test_script args comment)
+function(add_python_test_target name test_script args)
   set(PYTHON_TEST_COMMAND
     ${PYTHON_EXECUTABLE}
     ${test_script}
     ${args}
     )
 
   add_custom_target(${name}
     COMMAND ${PYTHON_TEST_COMMAND} ${ARG_DEFAULT_ARGS}
-    COMMENT "${comment}"
     )
 endfunction()
 
 if ("${LLDB_TEST_COMPILER}" STREQUAL "")
     string(REGEX REPLACE ".*ccache\ +" "" LLDB_TEST_COMPILER ${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1})
 endif()
 
 # The default architecture with which to compile test executables is the default LLVM target

 # Users can override LLDB_TEST_USER_ARGS to specify arbitrary arguments to pass to the script
 set(LLDB_TEST_USER_ARGS
   -C ${LLDB_TEST_COMPILER}
   CACHE STRING "Specify additional arguments to pass to test runner. For example: '-C gcc -C clang -A i386 -A x86_64'")
 
 set(LLDB_TEST_COMMON_ARGS
   --arch=${LLDB_TEST_ARCH}
   --executable
-  ${CMAKE_BINARY_DIR}/bin/lldb${CMAKE_EXECUTABLE_SUFFIX}
+  $<TARGET_FILE:lldb>
   -s
   ${CMAKE_BINARY_DIR}/lldb-test-traces
   -u CXXFLAGS
   -u CFLAGS
   )
 
 if ( CMAKE_SYSTEM_NAME MATCHES "Windows" )
   set(LLDB_TEST_DEBUG_TEST_CRASHES
if ( CMAKE_SYSTEM_NAME MATCHES "Windows" )
   if (NOT LLDB_TEST_HIDE_CONSOLE_WINDOWS)
     set(LLDB_TEST_COMMON_ARGS ${LLDB_TEST_COMMON_ARGS} --show-inferior-console)
   endif()
 endif()
 
 add_python_test_target(check-lldb-single
   ${LLDB_SOURCE_DIR}/test/dotest.py
   "${LLDB_TEST_COMMON_ARGS};${LLDB_TEST_USER_ARGS}"
-  "Testing LLDB with args: ${LLDB_TEST_COMMON_ARGS};${LLDB_TEST_USER_ARGS}"
   )
 
 set(LLDB_DOSEP_ARGS -o;\"-q;${LLDB_TEST_COMMON_ARGS};${LLDB_TEST_USER_ARGS}\")
 
 # If tests crash cause LLDB to crash, or things are otherwise unstable, or if machine-parsable
 # output is desired (i.e. in continuous integration contexts) check-lldb-single is a better target.
 add_python_test_target(check-lldb
   ${LLDB_SOURCE_DIR}/test/dosep.py
   "${LLDB_DOSEP_ARGS}"
-  "Testing LLDB (with a separate subprocess per test)"
   )