Page MenuHomePhabricator

Comment out DWARFCompileUnit printf spam
ClosedPublic

Authored by tfiala on Aug 26 2015, 2:25 PM.

Details

Reviewers
sivachandra
Summary

Comment out a line of diagnostic information that is printed many times during test runs when using DWARFCompileUnit.cpp to build the address range table.

Diff Detail

Event Timeline

tfiala updated this revision to Diff 33250.Aug 26 2015, 2:25 PM
tfiala retitled this revision from to Comment out DWARFCompileUnit printf spam.
tfiala updated this object.
tfiala added a reviewer: sivachandra.
tfiala added a subscriber: lldb-commits.
sivachandra accepted this revision.Aug 26 2015, 2:41 PM
sivachandra edited edge metadata.
sivachandra added inline comments.
source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
445

I do not know the policy around such debug print statements; I would just remove it.

This revision is now accepted and ready to land.Aug 26 2015, 2:41 PM
sas added a subscriber: sas.Aug 26 2015, 2:43 PM
sas added inline comments.
source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
445

Yeah removing (or redirecting to an actual log channel maybe?) might be a better fix than commenting out.

tfiala added inline comments.Aug 26 2015, 2:53 PM
source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
445

I'll just go ahead and remove it. It would be easy enough to add back in if somebody wants it, and they would be in a better position to determine what they'd want to enshrine in a log message. This one is very spammy.

Thanks, all!

tfiala closed this revision.Aug 26 2015, 3:09 PM

Committed:

Sending source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
Transmitting file data .
Committed revision 246091.