diff --git a/llvm/lib/Target/AMDGPU/SIISelLowering.h b/llvm/lib/Target/AMDGPU/SIISelLowering.h --- a/llvm/lib/Target/AMDGPU/SIISelLowering.h +++ b/llvm/lib/Target/AMDGPU/SIISelLowering.h @@ -87,6 +87,8 @@ SDValue LowerINTRINSIC_W_CHAIN(SDValue Op, SelectionDAG &DAG) const; SDValue LowerINTRINSIC_VOID(SDValue Op, SelectionDAG &DAG) const; + SDValue makeV_ILLEGAL(SDValue Op, SelectionDAG &DAG) const; + // The raw.tbuffer and struct.tbuffer intrinsics have two offset args: offset // (the offset that is included in bounds checking and swizzling, to be split // between the instruction's voffset and immoffset fields) and soffset (the diff --git a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp --- a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp +++ b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp @@ -6632,8 +6632,7 @@ Opcode = AMDGPU::getMIMGOpcode(IntrOpcode, AMDGPU::MIMGEncGfx90a, NumVDataDwords, NumVAddrDwords); if (Opcode == -1) - report_fatal_error( - "requested image instruction is not supported on this GPU"); + return makeV_ILLEGAL(Op, DAG); } if (Opcode == -1 && Subtarget->getGeneration() >= AMDGPUSubtarget::VOLCANIC_ISLANDS) @@ -7823,6 +7822,9 @@ unsigned Opcode = 0; switch (IntrID) { case Intrinsic::amdgcn_global_atomic_fadd: + if (!Subtarget->hasAtomicFaddNoRtnInsts()) + return makeV_ILLEGAL(Op, DAG); + LLVM_FALLTHROUGH; case Intrinsic::amdgcn_flat_atomic_fadd: { EVT VT = Op.getOperand(3).getValueType(); return DAG.getAtomic(ISD::ATOMIC_LOAD_FADD, DL, VT, @@ -8390,6 +8392,34 @@ } } +SDValue SITargetLowering::makeV_ILLEGAL(SDValue Op, SelectionDAG & DAG) const { + // Create the V_ILLEGAL node. + auto DL = SDLoc(Op); + auto Opcode = Subtarget->getGeneration() >= AMDGPUSubtarget::GFX10 ? + AMDGPU::V_ILLEGAL_ALL_SET : AMDGPU::V_ILLEGAL_ALL_UNSET; + + auto IllegalNode = [&]() { + if (auto MemNode = dyn_cast(Op.getNode())) { + auto Chain = MemNode->getChain(); + return DAG.getMachineNode(Opcode, DL, MVT::Other, Chain); + } + return DAG.getMachineNode(Opcode, DL, MVT::Other); + }(); + + auto IllegalVal = SDValue(IllegalNode, 0u); + + // Add the V_ILLEGAL node to the root chain to prevent its removal. + auto Chains = SmallVector(); + Chains.push_back(IllegalVal); + Chains.push_back(DAG.getRoot()); + auto Root = DAG.getTokenFactor(SDLoc(Chains.back()), Chains); + DAG.setRoot(Root); + + // Merge with UNDEF to satisfy return value requirements. + auto UndefVal = DAG.getUNDEF(Op.getValueType()); + return DAG.getMergeValues({UndefVal, IllegalVal}, DL); +} + // The raw.(t)buffer and struct.(t)buffer intrinsics have two offset args: // offset (the offset that is included in bounds checking and swizzling, to be // split between the instruction's voffset and immoffset fields) and soffset diff --git a/llvm/lib/Target/AMDGPU/SIInstructions.td b/llvm/lib/Target/AMDGPU/SIInstructions.td --- a/llvm/lib/Target/AMDGPU/SIInstructions.td +++ b/llvm/lib/Target/AMDGPU/SIInstructions.td @@ -3356,3 +3356,19 @@ let InOperandList = (ins type1:$src0); let hasSideEffects = 0; } + +//============================================================================// +// Dummy Instructions +//============================================================================// + +def V_ILLEGAL_ALL_SET : Enc32, InstSI<(outs), (ins), "v_illegal_all_set"> { + let Inst{31-0} = 1; + let FixedSize = 1; + let Uses = [EXEC]; +} + +def V_ILLEGAL_ALL_UNSET : Enc32, InstSI<(outs), (ins), "v_illegal_all_unset"> { + let Inst{31-0} = 0; + let FixedSize = 1; + let Uses = [EXEC]; +} diff --git a/llvm/test/CodeGen/AMDGPU/v_illegal-atomics.ll b/llvm/test/CodeGen/AMDGPU/v_illegal-atomics.ll new file mode 100644 --- /dev/null +++ b/llvm/test/CodeGen/AMDGPU/v_illegal-atomics.ll @@ -0,0 +1,38 @@ +; RUN: llc -march=amdgcn -mcpu=gfx906 -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX906 %s +; RUN: llc -march=amdgcn -mcpu=gfx908 -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX908 %s +; RUN: llc -march=amdgcn -mcpu=gfx90a -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX90A %s +; RUN: llc -march=amdgcn -mcpu=gfx940 -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX940 %s +; RUN: llc -march=amdgcn -mcpu=gfx1030 -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX1030 %s +; RUN: llc -march=amdgcn -mcpu=gfx1100 -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX1100 %s + +; GFX906-LABEL: fadd_test: +; GFX906-NOT: global_atomic_add_f32 +; GFX906: v_illegal_all_unset + +; GFX908-LABEL: fadd_test: +; GFX908-NOT: v_illegal +; GFX908: global_atomic_add_f32 + +; GFX90A-LABEL: fadd_test: +; GFX90A-NOT: v_illegal +; GFX90A: global_atomic_add_f32 + +; GFX940-LABEL: fadd_test: +; GFX940-NOT: v_illegal +; GFX940: global_atomic_add_f32 + +; GFX1030-LABEL: fadd_test: +; GFX1030-NOT: global_atomic_add_f32 +; GFX1030: v_illegal_all_set + +; GFX1100-LABEL: fadd_test: +; GFX1100-NOT: v_illegal +; GFX1100: global_atomic_add_f32 + +define fastcc void @fadd_test(float addrspace(1)* nocapture noundef %0, float noundef %1) unnamed_addr #0 { + %3 = tail call float @llvm.amdgcn.global.atomic.fadd.f32.p1f32.f32(float addrspace(1)* noundef %0, float noundef %1) #1 + ret void +} +declare float @llvm.amdgcn.global.atomic.fadd.f32.p1f32.f32(float addrspace(1)* nocapture, float) + +attributes #0 = { argmemonly convergent mustprogress norecurse nounwind willreturn }