Index: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp =================================================================== --- llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp +++ llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp @@ -891,6 +891,18 @@ } } + StringRef Str; + if (!getConstantStringInfo(SrcStr, Str, 0, /*TrimAtNul=*/false)) + return nullptr; + + uint64_t EndOff = UINT64_MAX; + if (LenC) { + EndOff = LenC->getZExtValue(); + if (Str.size() < EndOff) + // Punt out-of-bounds accesses to sanitizers and/or libc. + return nullptr; + } + return nullptr; } Index: llvm/test/Transforms/InstCombine/memrchr-2.ll =================================================================== --- llvm/test/Transforms/InstCombine/memrchr-2.ll +++ llvm/test/Transforms/InstCombine/memrchr-2.ll @@ -1,7 +1,8 @@ ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; RUN: opt < %s -passes=instcombine -S | FileCheck %s ; -; Verify that memrchr calls with an out of bounds size are folded to null. +; Verify that memrchr calls with an out of bounds size are not folded to +; null (they might be intercepted by sanitizers). declare i8* @memrchr(i8*, i32, i64) @@ -10,13 +11,14 @@ @a12345 = constant [5 x i8] c"\01\02\03\04\05" -; Fold memrchr(a12345, C, UINT32_MAX + 1LU) to null (and not to a12345 -; as might happen if the size were to be truncated to int32_t). +; Do not fold memrchr(a12345, C, UINT32_MAX + 1LU) to null or to a12345 +; as might happen if the size were to be truncated to int32_t. -define i8* @fold_memrchr_a12345_c_ui32max_p1(i32 %C) { -; CHECK-LABEL: @fold_memrchr_a12345_1_ui32max_p1( +define i8* @call_memrchr_a12345_c_ui32max_p1(i32 %C) { +; CHECK-LABEL: @call_memrchr_a12345_c_ui32max_p1( ; CHECK-NEXT: [[RET:%.*]] = call i8* @memrchr(i8* noundef nonnull dereferenceable(4294967296) getelementptr inbounds ([5 x i8], [5 x i8]* @a12345, i64 0, i64 0), i32 [[TMP0:%.*]], i64 4294967296) ; CHECK-NEXT: ret i8* [[RET]] +; %ptr = getelementptr [5 x i8], [5 x i8]* @a12345, i64 0, i64 0 %ret = call i8* @memrchr(i8* %ptr, i32 %C, i64 4294967296) @@ -24,12 +26,13 @@ } -; Fold memrchr(ax1, C, UINT32_MAX + 2LU) to null (and not to *ax1 == 1). +; Do not fold memrchr(ax1, C, UINT32_MAX + 2LU) to null or to *ax1 == 1. -define i8* @fold_memrchr_ax1_1_ui32max_p2(i32 %C) { -; CHECK-LABEL: @fold_memrchr_ax1_1_ui32max_p2( +define i8* @call_memrchr_ax1_c_ui32max_p2(i32 %C) { +; CHECK-LABEL: @call_memrchr_ax1_c_ui32max_p2( ; CHECK-NEXT: [[RET:%.*]] = call i8* @memrchr(i8* noundef nonnull dereferenceable(4294967297) getelementptr inbounds ([1 x i8], [1 x i8]* @ax1, i64 0, i64 0), i32 [[TMP0:%.*]], i64 4294967297) ; CHECK-NEXT: ret i8* [[RET]] +; %ptr = getelementptr [1 x i8], [1 x i8]* @ax1, i64 0, i64 0 %ret = call i8* @memrchr(i8* %ptr, i32 %C, i64 4294967297) @@ -37,26 +40,27 @@ } -; But don't fold memrchr(ax, C, UINT32_MAX + 2LU) to *ax == 1. +; Do not fold memrchr(ax, C, UINT32_MAX + 2LU) to *ax == 1. -define i8* @fold_memrchr_ax_1_ui32max_p2(i32 %C) { -; CHECK-LABEL: @fold_memrchr_ax_1_ui32max_p2( -; CHECK-NEXT: [[RET:%.*]] = call i8* @memrchr(i8* noundef nonnull dereferenceable(4294967297) getelementptr inbounds ([5 x i8], [5 x i8]* @a12345, i64 0, i64 0), i32 [[TMP0:%.*]], i64 4294967297) +define i8* @call_memrchr_ax_c_ui32max_p2(i32 %C) { +; CHECK-LABEL: @call_memrchr_ax_c_ui32max_p2( +; CHECK-NEXT: [[RET:%.*]] = call i8* @memrchr(i8* noundef nonnull dereferenceable(4294967297) getelementptr inbounds ([0 x i8], [0 x i8]* @ax, i64 0, i64 0), i32 [[TMP0:%.*]], i64 4294967297) ; CHECK-NEXT: ret i8* [[RET]] ; - %ptr = getelementptr [5 x i8], [5 x i8]* @a12345, i64 0, i64 0 + %ptr = getelementptr [0 x i8], [0 x i8]* @ax, i64 0, i64 0 %ret = call i8* @memrchr(i8* %ptr, i32 %C, i64 4294967297) ret i8* %ret } -; Fold memrchr(a12345, C, 6) to null. +; Do not fold memrchr(a12345, C, 6) to null. -define i8* @fold_memrchr_a12345_c_6(i32 %C) { -; CHECK-LABEL: @fold_memrchr_a12345_c_6( +define i8* @call_memrchr_a12345_c_6(i32 %C) { +; CHECK-LABEL: @call_memrchr_a12345_c_6( ; CHECK-NEXT: [[RET:%.*]] = call i8* @memrchr(i8* noundef nonnull dereferenceable(6) getelementptr inbounds ([5 x i8], [5 x i8]* @a12345, i64 0, i64 0), i32 [[TMP0:%.*]], i64 6) ; CHECK-NEXT: ret i8* [[RET]] +; %ptr = getelementptr [5 x i8], [5 x i8]* @a12345, i64 0, i64 0 %ret = call i8* @memrchr(i8* %ptr, i32 %C, i64 6) @@ -64,12 +68,13 @@ } -; Fold memrchr(a12345, C, SIZE_MAX) to null. +; Do not fold memrchr(a12345, C, SIZE_MAX) to null. -define i8* @fold_memrchr_a12345_c_szmax(i32 %C) { -; CHECK-LABEL: @fold_memrchr_a12345_c_szmax( +define i8* @call_memrchr_a12345_c_szmax(i32 %C) { +; CHECK-LABEL: @call_memrchr_a12345_c_szmax( ; CHECK-NEXT: [[RET:%.*]] = call i8* @memrchr(i8* noundef nonnull dereferenceable(18446744073709551615) getelementptr inbounds ([5 x i8], [5 x i8]* @a12345, i64 0, i64 0), i32 [[TMP0:%.*]], i64 -1) ; CHECK-NEXT: ret i8* [[RET]] +; %ptr = getelementptr [5 x i8], [5 x i8]* @a12345, i64 0, i64 0 %ret = call i8* @memrchr(i8* %ptr, i32 %C, i64 18446744073709551615)