diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp --- a/clang/lib/Sema/SemaDecl.cpp +++ b/clang/lib/Sema/SemaDecl.cpp @@ -17969,8 +17969,22 @@ // Handle attributes before checking the layout. ProcessDeclAttributeList(S, Record, Attrs); - // Maybe randomize the field order. - if (!getLangOpts().CPlusPlus && Record->hasAttr() && + // Check to see if a FieldDecl is a pointer to a function. + auto IsFunctionPointer = [&](const FieldDecl *FD) { + QualType FieldType = FD->getType().getDesugaredType(Context); + if (isa(FieldType)) { + QualType PointeeType = cast(FieldType)->getPointeeType(); + return PointeeType.getDesugaredType(Context)->isFunctionType(); + } + return false; + }; + + // Maybe randomize the field order. We automatically randomize a structure + // of function pointers, unless it has the "no_randomize_layout" attribute. + if (!getLangOpts().CPlusPlus && + (Record->hasAttr() || + (!Record->hasAttr() && + llvm::all_of(Record->fields(), IsFunctionPointer))) && !Record->isUnion() && !getLangOpts().RandstructSeed.empty() && !Record->isRandomized()) { SmallVector OrigFieldOrdering(Record->fields()); diff --git a/clang/unittests/AST/RandstructTest.cpp b/clang/unittests/AST/RandstructTest.cpp --- a/clang/unittests/AST/RandstructTest.cpp +++ b/clang/unittests/AST/RandstructTest.cpp @@ -417,5 +417,49 @@ EXPECT_TRUE(AnonUnionTested); } +TEST(RANDSTRUCT_TEST, AutoRandomizeStructOfFunctionPointers) { + const std::unique_ptr AST = makeAST(R"c( + typedef void (*func_ptr)(); + + struct test { + func_ptr a; + func_ptr b; + func_ptr c; + func_ptr d; + func_ptr e; + func_ptr f; + func_ptr g; + }; + )c"); + + EXPECT_FALSE(AST->getDiagnostics().hasErrorOccurred()); + + const RecordDecl *RD = getRecordDeclFromAST(AST->getASTContext(), "test"); + + EXPECT_TRUE(RD->isRandomized()); +} + +TEST(RANDSTRUCT_TEST, DisableAutoRandomizeStructOfFunctionPointers) { + const std::unique_ptr AST = makeAST(R"c( + typedef void (*func_ptr)(); + + struct test { + func_ptr a; + func_ptr b; + func_ptr c; + func_ptr d; + func_ptr e; + func_ptr f; + func_ptr g; + } __attribute__((no_randomize_layout)); + )c"); + + EXPECT_FALSE(AST->getDiagnostics().hasErrorOccurred()); + + const RecordDecl *RD = getRecordDeclFromAST(AST->getASTContext(), "test"); + + EXPECT_FALSE(RD->isRandomized()); +} + } // namespace ast_matchers } // namespace clang