diff --git a/flang/lib/Optimizer/Dialect/FIROps.cpp b/flang/lib/Optimizer/Dialect/FIROps.cpp --- a/flang/lib/Optimizer/Dialect/FIROps.cpp +++ b/flang/lib/Optimizer/Dialect/FIROps.cpp @@ -566,9 +566,11 @@ //===----------------------------------------------------------------------===// mlir::OpFoldResult fir::BoxAddrOp::fold(llvm::ArrayRef opnds) { - if (auto v = getVal().getDefiningOp()) { - if (auto box = dyn_cast(v)) - return box.getMemref(); + if (auto *v = getVal().getDefiningOp()) { + if (auto box = dyn_cast(v)) { + if (!box.getSlice()) // Fold only if not sliced + return box.getMemref(); + } if (auto box = dyn_cast(v)) return box.getMemref(); } diff --git a/flang/test/Fir/boxaddr-folding.fir b/flang/test/Fir/boxaddr-folding.fir new file mode 100644 --- /dev/null +++ b/flang/test/Fir/boxaddr-folding.fir @@ -0,0 +1,46 @@ +// RUN: fir-opt --canonicalize %s -split-input-file | FileCheck %s + +// CHECK-LABEL: func @check_no_folding +func @check_no_folding(%arg0 : !fir.ref>) { + %0 = fir.alloca i32 {adapt.valuebyref} + %c1_i32 = arith.constant 1 : i32 + %1 = fir.load %0 : !fir.ref + %2 = arith.addi %1, %c1_i32 : i32 + %3 = fir.convert %2 : (i32) -> index + %c1 = arith.constant 1 : index + %5 = arith.subi %3, %c1 : index + %6 = fir.shape %3 : (index) -> !fir.shape<1> + %7 = fir.slice %3, %5, %3 : (index, index, index) -> !fir.slice<1> + %8 = fir.embox %arg0(%6) [%7] : (!fir.ref>, !fir.shape<1>, !fir.slice<1>) -> !fir.box> + %9 = fir.box_addr %8 : (!fir.box>) -> !fir.ref> + // CHECK: %[[BOX_ADDR:.*]] = fir.box_addr + // CHECK: fir.call @check(%[[BOX_ADDR]]) + fir.call @check(%9) : (!fir.ref>) -> () + return +} + +func @check(%arg0: !fir.ref>) { + return +} + +// ----- + +// CHECK-LABEL: func @check_folding +func @check_folding(%arg0 : !fir.ref>) { + %0 = fir.alloca i32 {adapt.valuebyref} + %c1_i32 = arith.constant 1 : i32 + %1 = fir.load %0 : !fir.ref + %2 = arith.addi %1, %c1_i32 : i32 + %3 = fir.convert %2 : (i32) -> index + %c1 = arith.constant 1 : index + %6 = fir.shape %3 : (index) -> !fir.shape<1> + %7 = fir.embox %arg0(%6) : (!fir.ref>, !fir.shape<1>) -> !fir.box> + %8 = fir.box_addr %7 : (!fir.box>) -> !fir.ref> + // CHECK-NOT: fir.box_addr + fir.call @check(%8) : (!fir.ref>) -> () + return +} + +func @check(%arg0: !fir.ref>) { + return +}