diff --git a/clang/include/clang/Driver/Compilation.h b/clang/include/clang/Driver/Compilation.h --- a/clang/include/clang/Driver/Compilation.h +++ b/clang/include/clang/Driver/Compilation.h @@ -139,7 +139,7 @@ const ToolChain &getDefaultToolChain() const { return DefaultToolChain; } - unsigned isOffloadingHostKind(Action::OffloadKind Kind) const { + unsigned isOffloadingHostKind(unsigned int Kind) const { return ActiveOffloadMask & Kind; } diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td --- a/clang/include/clang/Driver/Options.td +++ b/clang/include/clang/Driver/Options.td @@ -2523,6 +2523,8 @@ HelpText<"Use the new driver for OpenMP offloading.">; def fno_openmp_new_driver : Flag<["-"], "fno-openmp-new-driver">, Flags<[CC1Option]>, Group, HelpText<"Don't use the new driver for OpenMP offloading.">; +def foffload_new_driver : Flag<["-"], "foffload-new-driver">, Flags<[CC1Option]>, Group, + HelpText<"Use the new driver for offloading.">; def fno_optimize_sibling_calls : Flag<["-"], "fno-optimize-sibling-calls">, Group, Flags<[CC1Option]>, HelpText<"Disable tail call optimization, keeping the call stack accurate">, MarshallingInfoFlag>; diff --git a/clang/lib/Driver/Driver.cpp b/clang/lib/Driver/Driver.cpp --- a/clang/lib/Driver/Driver.cpp +++ b/clang/lib/Driver/Driver.cpp @@ -3897,9 +3897,12 @@ ActionList LinkerInputs; ActionList MergerInputs; + // We should use the new offloading driver for OpenMP offloading unless + // explicitly disabled. bool UseNewOffloadingDriver = - C.isOffloadingHostKind(Action::OFK_OpenMP) && - !Args.hasArg(options::OPT_fno_openmp_new_driver); + (C.isOffloadingHostKind(Action::OFK_OpenMP) && + !Args.hasArg(options::OPT_fno_openmp_new_driver)) || + Args.hasArg(options::OPT_foffload_new_driver); for (auto &I : Inputs) { types::ID InputType = I.first; @@ -4024,8 +4027,7 @@ // Check if this Linker Job should emit a static library. if (ShouldEmitStaticLibrary(Args)) { LA = C.MakeAction(LinkerInputs, types::TY_Image); - } else if (UseNewOffloadingDriver && - C.getActiveOffloadKinds() != Action::OFK_None) { + } else if (UseNewOffloadingDriver) { LA = C.MakeAction(LinkerInputs, types::TY_Image); LA->propagateHostOffloadInfo(C.getActiveOffloadKinds(), /*BoundArch=*/nullptr); diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp --- a/clang/lib/Driver/ToolChains/Clang.cpp +++ b/clang/lib/Driver/ToolChains/Clang.cpp @@ -4382,7 +4382,8 @@ JA.isDeviceOffloading(Action::OFK_Host)); bool IsHostOffloadingAction = JA.isHostOffloading(C.getActiveOffloadKinds()) && - Args.hasArg(options::OPT_fopenmp_new_driver); + (Args.hasArg(options::OPT_fopenmp_new_driver) || + Args.hasArg(options::OPT_foffload_new_driver)); bool IsUsingLTO = D.isUsingLTO(IsDeviceOffloadAction); auto LTOMode = D.getLTOMode(IsDeviceOffloadAction); @@ -4674,6 +4675,7 @@ // Only AMDGPU supports device-side LTO. if (IsDeviceOffloadAction && Args.hasArg(options::OPT_fno_openmp_new_driver) && + !Args.hasArg(options::OPT_foffload_new_driver) && !Triple.isAMDGPU()) { D.Diag(diag::err_drv_unsupported_opt_for_target) << Args.getLastArg(options::OPT_foffload_lto,