[Fuchsia] Omit the list of projects and runtimes

[phosek]

Summary

The list of projects and runtimes is part of cache now. This addresses the
current failure which is due to a mismatch between the configuration and
the content of the cache file.

In addition, also include bolt in the list of projects that trigger our builders
since bolt is already enabled in the Fuchsia CMake cache file.

[rovka]

zorg/buildbot/builders/FuchsiaBuilder.py

32

Bolt wasn't enabled before. You should at least mention it in the commit message, or even send a separate patch.

96

I think the runtimes will be handled differently than before, unless you specifically set enable_runtimes to 'auto'. AFAICT the default is None, which means the runtimes will be built via LLVM_ENABLE_PROJECTS instead of LLVM_ENABLE_RUNTIMES, which may lead to subtle differences. If this is on purpose, you should document it in the commit message.

[phosek]

zorg/buildbot/builders/FuchsiaBuilder.py

96

This builder uses CMake cache file which already sets these values, see https://github.com/llvm/llvm-project/blob/9b8a04313f0ec9b262c4c3c5182dc5566f53fe67/clang/cmake/caches/Fuchsia-stage2.cmake#L7. I have updated the comment to be more explicit.

[gkistanova]

LGTM with a nit pick.

The list of projects and runtimes is part of cache now.

How about something like this instead?

The list of projects and runtimes is a part of Fuchsia-stage2.cmake <and whatever else cmake files> cache now.

zorg/buildbot/builders/FuchsiaBuilder.py

if env is not None:
         merged_env.update(env)
 
     src_dir = "llvm.src"
     obj_dir = "llvm.obj"
     install_dir = "llvm.install"
 
     f = UnifiedTreeBuilder.getLLVMBuildFactoryAndSourcecodeSteps(
             depends_on_projects=[
-                "llvm",
+                "bolt",
                 "clang",
                 "clang-tools-extra",
                 "compiler-rt",
                 "libcxx",
                 "libcxxabi",
                 "libunwind",
-                "lld"
+                "lld",
+                "llvm",
+                "polly",
             ],
             llvm_srcdir=src_dir,
             obj_dir=obj_dir,
             install_dir=install_dir,
             **kwargs) # Pass through all the extra arguments.
 
     # Get Fuchsia SDK.
     sdk_dir = "fuchsia.sdk"
def getFuchsiaToolchainBuildFactory(
     if extra_configure_args is None:
         cmake_options = []
     else:
         cmake_options = extra_configure_args[:]
 
     # Some options are required for this stage no matter what.
     CmakeCommand.applyRequiredOptions(cmake_options, [
         ("-G",                      "Ninja"),
-        ("-DLLVM_ENABLE_PROJECTS=", "clang;clang-tools-extra;lld"),
-        ("-DLLVM_ENABLE_RUNTIMES=", "compiler-rt;libcxx;libcxxabi;libunwind"),
         ])
 
     # Set proper defaults.
     CmakeCommand.applyDefaultOptions(cmake_options, [
         ("-DBOOTSTRAP_LLVM_ENABLE_LTO=", "OFF"),
         ("-DLLVM_ENABLE_LTO=",           "OFF"),
         ])