Page MenuHomePhabricator

Error checking correction in AArch64 hardware watchpoint code
ClosedPublic

Authored by omjavaid on Aug 25 2015, 12:06 PM.

Details

Summary

This patch fixes a few areas where AArch64 hardware watchpoints were not emitting errors correctly.

This makes sure any ptrace failures are reflected in any packet responses from the server.

Diff Detail

Repository
rL LLVM

Event Timeline

omjavaid updated this revision to Diff 33099.Aug 25 2015, 12:06 PM
omjavaid retitled this revision from to Error checking correction in AArch64 hardware watchpoint code.
omjavaid updated this object.
omjavaid added reviewers: tberghammer, clayborg.
omjavaid added a subscriber: lldb-commits.
tberghammer added inline comments.Aug 26 2015, 2:56 AM
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp
469 ↗(On Diff #33099)

This should be "return false"

490 ↗(On Diff #33099)

This should be "return false"

618 ↗(On Diff #33099)

This should be "return false"

clayborg requested changes to this revision.Aug 26 2015, 9:51 AM
clayborg edited edge metadata.

Fix the incorrect bool return values and this will be good to go.

This revision now requires changes to proceed.Aug 26 2015, 9:51 AM
This revision was automatically updated to reflect the committed changes.