Index: lldb/include/lldb/lldb-private-interfaces.h =================================================================== --- lldb/include/lldb/lldb-private-interfaces.h +++ lldb/include/lldb/lldb-private-interfaces.h @@ -45,7 +45,7 @@ lldb::offset_t data_offset, lldb::offset_t file_offset, lldb::offset_t length, ModuleSpecList &module_specs); typedef ObjectFile *(*ObjectFileCreateInstance)(const lldb::ModuleSP &module_sp, - lldb::DataBufferSP &data_sp, + lldb::DataBufferSP data_sp, lldb::offset_t data_offset, const FileSpec *file, lldb::offset_t file_offset, Index: lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.h =================================================================== --- lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.h +++ lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.h @@ -27,7 +27,7 @@ } static ObjectFile * - CreateInstance(const lldb::ModuleSP &module_sp, lldb::DataBufferSP &data_sp, + CreateInstance(const lldb::ModuleSP &module_sp, lldb::DataBufferSP data_sp, lldb::offset_t data_offset, const FileSpec *file, lldb::offset_t file_offset, lldb::offset_t length); Index: lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp =================================================================== --- lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp +++ lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp @@ -57,7 +57,7 @@ } ObjectFile *ObjectFileBreakpad::CreateInstance( - const ModuleSP &module_sp, DataBufferSP &data_sp, offset_t data_offset, + const ModuleSP &module_sp, DataBufferSP data_sp, offset_t data_offset, const FileSpec *file, offset_t file_offset, offset_t length) { if (!data_sp) { data_sp = MapFileData(*file, length, file_offset); Index: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.h =================================================================== --- lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.h +++ lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.h @@ -68,7 +68,7 @@ } static lldb_private::ObjectFile * - CreateInstance(const lldb::ModuleSP &module_sp, lldb::DataBufferSP &data_sp, + CreateInstance(const lldb::ModuleSP &module_sp, lldb::DataBufferSP data_sp, lldb::offset_t data_offset, const lldb_private::FileSpec *file, lldb::offset_t file_offset, lldb::offset_t length); Index: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp =================================================================== --- lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp +++ lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp @@ -336,7 +336,7 @@ } ObjectFile *ObjectFileELF::CreateInstance(const lldb::ModuleSP &module_sp, - DataBufferSP &data_sp, + DataBufferSP data_sp, lldb::offset_t data_offset, const lldb_private::FileSpec *file, lldb::offset_t file_offset, Index: lldb/source/Plugins/ObjectFile/JIT/ObjectFileJIT.h =================================================================== --- lldb/source/Plugins/ObjectFile/JIT/ObjectFileJIT.h +++ lldb/source/Plugins/ObjectFile/JIT/ObjectFileJIT.h @@ -33,7 +33,7 @@ } static lldb_private::ObjectFile * - CreateInstance(const lldb::ModuleSP &module_sp, lldb::DataBufferSP &data_sp, + CreateInstance(const lldb::ModuleSP &module_sp, lldb::DataBufferSP data_sp, lldb::offset_t data_offset, const lldb_private::FileSpec *file, lldb::offset_t file_offset, lldb::offset_t length); Index: lldb/source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp =================================================================== --- lldb/source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp +++ lldb/source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp @@ -54,7 +54,7 @@ } ObjectFile *ObjectFileJIT::CreateInstance(const lldb::ModuleSP &module_sp, - DataBufferSP &data_sp, + DataBufferSP data_sp, lldb::offset_t data_offset, const FileSpec *file, lldb::offset_t file_offset, Index: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h =================================================================== --- lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h +++ lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h @@ -44,7 +44,7 @@ } static lldb_private::ObjectFile * - CreateInstance(const lldb::ModuleSP &module_sp, lldb::DataBufferSP &data_sp, + CreateInstance(const lldb::ModuleSP &module_sp, lldb::DataBufferSP data_sp, lldb::offset_t data_offset, const lldb_private::FileSpec *file, lldb::offset_t file_offset, lldb::offset_t length); Index: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp =================================================================== --- lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp +++ lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp @@ -817,7 +817,7 @@ } ObjectFile *ObjectFileMachO::CreateInstance(const lldb::ModuleSP &module_sp, - DataBufferSP &data_sp, + DataBufferSP data_sp, lldb::offset_t data_offset, const FileSpec *file, lldb::offset_t file_offset, Index: lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.h =================================================================== --- lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.h +++ lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.h @@ -38,7 +38,7 @@ llvm::StringRef GetPluginName() override { return GetPluginNameStatic(); } static lldb_private::ObjectFile * - CreateInstance(const lldb::ModuleSP &module_sp, lldb::DataBufferSP &data_sp, + CreateInstance(const lldb::ModuleSP &module_sp, lldb::DataBufferSP data_sp, lldb::offset_t data_offset, const lldb_private::FileSpec *file, lldb::offset_t offset, lldb::offset_t length); Index: lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp =================================================================== --- lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp +++ lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp @@ -33,7 +33,7 @@ } ObjectFile *ObjectFileMinidump::CreateInstance( - const lldb::ModuleSP &module_sp, lldb::DataBufferSP &data_sp, + const lldb::ModuleSP &module_sp, lldb::DataBufferSP data_sp, lldb::offset_t data_offset, const lldb_private::FileSpec *file, lldb::offset_t offset, lldb::offset_t length) { return nullptr; Index: lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.h =================================================================== --- lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.h +++ lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.h @@ -31,7 +31,7 @@ loadPDBFile(std::string PdbPath, llvm::BumpPtrAllocator &Allocator); static ObjectFile * - CreateInstance(const lldb::ModuleSP &module_sp, lldb::DataBufferSP &data_sp, + CreateInstance(const lldb::ModuleSP &module_sp, lldb::DataBufferSP data_sp, lldb::offset_t data_offset, const FileSpec *file, lldb::offset_t file_offset, lldb::offset_t length); Index: lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp =================================================================== --- lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp +++ lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp @@ -87,7 +87,7 @@ } ObjectFile * -ObjectFilePDB::CreateInstance(const ModuleSP &module_sp, DataBufferSP &data_sp, +ObjectFilePDB::CreateInstance(const ModuleSP &module_sp, DataBufferSP data_sp, offset_t data_offset, const FileSpec *file, offset_t file_offset, offset_t length) { auto objfile_up = std::make_unique( Index: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h =================================================================== --- lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h +++ lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h @@ -62,7 +62,7 @@ static llvm::StringRef GetPluginDescriptionStatic(); static ObjectFile * - CreateInstance(const lldb::ModuleSP &module_sp, lldb::DataBufferSP &data_sp, + CreateInstance(const lldb::ModuleSP &module_sp, lldb::DataBufferSP data_sp, lldb::offset_t data_offset, const lldb_private::FileSpec *file, lldb::offset_t offset, lldb::offset_t length); Index: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp =================================================================== --- lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp +++ lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp @@ -77,12 +77,10 @@ "(32 and 64 bit)"; } -ObjectFile *ObjectFilePECOFF::CreateInstance(const lldb::ModuleSP &module_sp, - DataBufferSP &data_sp, - lldb::offset_t data_offset, - const lldb_private::FileSpec *file_p, - lldb::offset_t file_offset, - lldb::offset_t length) { +ObjectFile *ObjectFilePECOFF::CreateInstance( + const lldb::ModuleSP &module_sp, DataBufferSP data_sp, + lldb::offset_t data_offset, const lldb_private::FileSpec *file_p, + lldb::offset_t file_offset, lldb::offset_t length) { FileSpec file = file_p ? *file_p : FileSpec(); if (!data_sp) { data_sp = MapFileData(file, length, file_offset); Index: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.h =================================================================== --- lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.h +++ lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.h @@ -30,7 +30,7 @@ } static ObjectFile * - CreateInstance(const lldb::ModuleSP &module_sp, lldb::DataBufferSP &data_sp, + CreateInstance(const lldb::ModuleSP &module_sp, lldb::DataBufferSP data_sp, lldb::offset_t data_offset, const FileSpec *file, lldb::offset_t file_offset, lldb::offset_t length); Index: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp =================================================================== --- lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp +++ lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp @@ -88,7 +88,7 @@ } ObjectFile * -ObjectFileWasm::CreateInstance(const ModuleSP &module_sp, DataBufferSP &data_sp, +ObjectFileWasm::CreateInstance(const ModuleSP &module_sp, DataBufferSP data_sp, offset_t data_offset, const FileSpec *file, offset_t file_offset, offset_t length) { Log *log = GetLog(LLDBLog::Object);