Fix build on mips

[slthakur]

Summary

Setting and getting register values as bytes instead of depending on the 128 bit integer support in register value.
This patch will fix the build failure in the release branch.

[tberghammer]

Looks good and I am fine with merging this into the release branch as it only effects mips/mips64 as the modified file is only compiled on these architectures.

[clayborg]

Looks good.

[hans]

Thanks!

Sagar, are you committing this on trunk so I can merge it to 3.7, or did you intend it to be committed to the branch directly?

[slthakur]

Hi Hans,

I have committed it to the trunk in revision 245927. You can now merge it to the release branch.

Thanks,
Sagar

[hans]

In D12275#231979, @Sagar wrote:

I have committed it to the trunk in revision 245927. You can now merge it to the release branch.

Thanks! Merged in r245947.

source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp

NativeRegisterContextLinux_mips64::ReadRegister (const RegisterInfo *reg_info, RegisterValue &reg_value)
     {
         error.SetErrorString ("MSA not available on this processor");
         return error;
     }
 
     if (IsMSA(reg) || IsFPR(reg))
     {
         uint8_t *src;
-        type128 int128;
 
         error = ReadCP1();
 
         if (!error.Success())
         {
             error.SetErrorString ("failed to read co-processor 1 register");
             return error;
         }
 
         if (IsFPR(reg))
         {
             assert (reg_info->byte_offset < sizeof(UserArea));
             src = (uint8_t *)&m_fpr + reg_info->byte_offset - (sizeof(m_gpr));
         }
         else
         {
             assert (reg_info->byte_offset < sizeof(UserArea));
             src = (uint8_t *)&m_msa + reg_info->byte_offset - (sizeof(m_gpr) + sizeof(m_fpr));
         }
-        int128.x[0] = *(uint64_t *)src;
-        int128.x[1] = *(uint64_t *)(src + 8);
-        llvm::APInt rhs = llvm::APInt(128, 2, int128.x);
         switch (reg_info->byte_size)
         {
             case 4:
                 reg_value.SetUInt32(*(uint32_t *)src);
                 break;
             case 8:
                 reg_value.SetUInt64(*(uint64_t *)src);
                 break;
             case 16:
-                reg_value.SetUInt128(rhs);
+                reg_value.SetBytes((const void *)src, 16, GetByteOrder());
                 break;
             default:
                 assert(false && "Unhandled data size.");
                 error.SetErrorStringWithFormat ("unhandled byte size: %" PRIu32, reg_info->byte_size);
                 break;
         }
     }
     else
NativeRegisterContextLinux_mips64::WriteRegister (const RegisterInfo *reg_info, const RegisterValue &reg_value)
     {
         error.SetErrorString ("MSA not available on this processor");
         return error;
     }
 
     if (IsFPR(reg_index) || IsMSA(reg_index))
     {
         uint8_t *dst;
-        const uint64_t *src;
+        uint64_t *src;
 
         // Initialise the FP and MSA buffers by reading all co-processor 1 registers
         ReadCP1();
 
         if (IsFPR(reg_index))
         {
             assert (reg_info->byte_offset < sizeof(UserArea));
             dst = (uint8_t *)&m_fpr + reg_info->byte_offset - (sizeof(m_gpr));
         }
         else
         {
             assert (reg_info->byte_offset < sizeof(UserArea));
             dst = (uint8_t *)&m_msa + reg_info->byte_offset - (sizeof(m_gpr) + sizeof(m_fpr));
         }
-        llvm::APInt lhs;
-        llvm::APInt fail_value = llvm::APInt::getMaxValue(128);
         switch (reg_info->byte_size)
         {
             case 4:
                 *(uint32_t *)dst = reg_value.GetAsUInt32();
                 break;
             case 8:
                 *(uint64_t *)dst = reg_value.GetAsUInt64();
                 break;
             case 16:
-                lhs = reg_value.GetAsUInt128(fail_value);
-                src = lhs.getRawData();
+                src = (uint64_t *)reg_value.GetBytes();
                 *(uint64_t *)dst = *src;
                 *(uint64_t *)(dst + 8) = *(src + 1);
                 break;
             default:
                 assert(false && "Unhandled data size.");
                 error.SetErrorStringWithFormat ("unhandled byte size: %" PRIu32, reg_info->byte_size);
                 break;
         }