Page MenuHomePhabricator

Fix build on mips
ClosedPublic

Authored by slthakur on Aug 24 2015, 3:41 AM.

Details

Summary

Setting and getting register values as bytes instead of depending on the 128 bit integer support in register value.
This patch will fix the build failure in the release branch.

Diff Detail

Repository
rL LLVM

Event Timeline

slthakur updated this revision to Diff 32941.Aug 24 2015, 3:41 AM
slthakur retitled this revision from to Fix build on mips.
slthakur updated this object.
slthakur added reviewers: clayborg, tberghammer, hans.
slthakur set the repository for this revision to rL LLVM.
slthakur added subscribers: jaydeep, nitesh.jain, bhushan.
tberghammer accepted this revision.Aug 24 2015, 4:45 AM
tberghammer edited edge metadata.

Looks good and I am fine with merging this into the release branch as it only effects mips/mips64 as the modified file is only compiled on these architectures.

This revision is now accepted and ready to land.Aug 24 2015, 4:45 AM
clayborg accepted this revision.Aug 24 2015, 9:37 AM
clayborg edited edge metadata.

Looks good.

hans accepted this revision.Aug 24 2015, 4:42 PM
hans edited edge metadata.

Thanks!

Sagar, are you committing this on trunk so I can merge it to 3.7, or did you intend it to be committed to the branch directly?

slthakur edited edge metadata.Aug 25 2015, 2:52 AM
slthakur added a subscriber: lldb-commits.

Hi Hans,

I have committed it to the trunk in revision 245927. You can now merge it to the release branch.

Thanks,
Sagar

slthakur closed this revision.Aug 25 2015, 2:56 AM
hans added a comment.Aug 25 2015, 9:19 AM
In D12275#231979, @sagar wrote:

I have committed it to the trunk in revision 245927. You can now merge it to the release branch.

Thanks! Merged in r245947.